From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43397: 28.0.50; Adding tool bar items: update tool bar Date: Fri, 27 Aug 2021 19:40:13 +0200 Message-ID: <874kban5vm.fsf@gnus.org> References: <87h7s0jurl.fsf@gmail.com> <83lfhb83hm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25580"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43397@debbugs.gnu.org, Caio Henrique , Stefan Monnier To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 19:41:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJfqw-0006N8-22 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 19:41:18 +0200 Original-Received: from localhost ([::1]:57788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJfqv-0001a5-35 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 13:41:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJfqg-0001V8-KN for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 13:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJfqg-0006Rp-AN for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 13:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJfqg-0006q9-3A for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 13:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43397 X-GNU-PR-Package: emacs Original-Received: via spool by 43397-submit@debbugs.gnu.org id=B43397.163008603626255 (code B ref 43397); Fri, 27 Aug 2021 17:41:02 +0000 Original-Received: (at 43397) by debbugs.gnu.org; 27 Aug 2021 17:40:36 +0000 Original-Received: from localhost ([127.0.0.1]:52920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfqC-0006pL-5M for submit@debbugs.gnu.org; Fri, 27 Aug 2021 13:40:36 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJfq6-0006oz-9V for 43397@debbugs.gnu.org; Fri, 27 Aug 2021 13:40:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+l83P/UHRwA8RXgEJM0PvxnG+A/ZrRhMVZyi7GtGfQk=; b=O+z8pn4/nWnlM6M03pfhQeSrYz C3rghNzfUAHcGo499hklKNM5NVo72xTTS+XS8XzdlSMDbHPQMpjlK7WGl9VziedU3iuFTPz1rm+nc +Qet0sB/qkjGdp0lCu5R4iC6KGxLPEJv+y+U2frKu7f34WFb8nOLPSCP5TxK1SZAgo80=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJfpu-00066N-9n; Fri, 27 Aug 2021 19:40:18 +0200 In-Reply-To: <83lfhb83hm.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 15 Sep 2020 18:27:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212835 Archived-At: Eli Zaretskii writes: > Then evaluate the forms and press F5. The tool bar won't change. This was a year ago, but I can still reproduce this on the current trunk. Here's an even easier variation of the recipe: (progn (blink-cursor-mode -1) (global-eldoc-mode -1) (defun myfun () (interactive) (tool-bar-add-item "redo" 'undo-redo 'undo-redo)) (global-set-key [f5] 'myfun)) And then M-: (garbage-collect) makes the tool bar update. However! The garbage-collect in itself isn't sufficient to trigger it. With this variation: (progn (blink-cursor-mode -1) (global-eldoc-mode -1) (tool-bar-add-item "redo" 'undo-redo 'undo-redo) (global-set-key [f5] (lambda () (interactive) (garbage-collect)))) pressing does not make the icon appear. > Now do some random clicks, watching the echo area: you will see that > the tool bar is updated with the "redo" icon precisely when the > "Garbage collecting..." message appears in the echo area. Very mysterious. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no