all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp <p.stephani2@gmail.com>
Cc: 48350@debbugs.gnu.org
Subject: bug#48350: 28.0.50; bytecomp-tests--dest-mountpoint test failure
Date: Sun, 05 Sep 2021 11:37:17 +0200	[thread overview]
Message-ID: <874kaznz1u.fsf@gnus.org> (raw)
In-Reply-To: <A1C4ADD1-3797-4B45-90D0-5ABA60923BED@gmail.com> (Philipp's message of "Sat, 4 Sep 2021 21:30:50 +0200")

Philipp <p.stephani2@gmail.com> writes:

> Such code is quite brittle.  Code should generally not try to detect
> whether it's running as part of a test, and not make decisions based
> on sich a detection, because such logic thwarts the idea of testing
> the actual code that runs in production.  I'd recommend deleting this
> snippet and finding a better way to achieve its goal.

I agree.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2021-09-05  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 14:05 bug#48350: 28.0.50; bytecomp-tests--dest-mountpoint test failure Lars Ingebrigtsen
2021-05-11 14:42 ` Philipp Stephani
2021-05-11 14:46   ` Lars Ingebrigtsen
2021-05-12 20:08     ` Lars Ingebrigtsen
2021-08-11 22:34       ` Lars Ingebrigtsen
2021-08-11 23:06         ` Lars Ingebrigtsen
2021-08-11 23:20           ` Lars Ingebrigtsen
2021-09-04 19:30           ` Philipp
2021-09-05  9:37             ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kaznz1u.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=48350@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.