* Re: master 5b962a7: Avoid double argument evaluation in vc-call macro [not found] ` <20210921115004.44D90200AF@vcs0.savannah.gnu.org> @ 2021-09-21 12:51 ` Michael Albinus 2021-09-21 13:40 ` Po Lu 2021-09-21 13:45 ` Basil L. Contovounesios 0 siblings, 2 replies; 7+ messages in thread From: Michael Albinus @ 2021-09-21 12:51 UTC (permalink / raw) To: emacs-devel; +Cc: Basil L. Contovounesios blc@savannah.gnu.org (Basil L. Contovounesios) writes: Hi, > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1749,6 +1749,9 @@ tags to be considered as well. > *** New user option 'vc-git-log-switches'. > String or list of strings specifying switches for Git log under VC. > > +--- > +*** The macro 'vc-call' no longer evaluates its second argument twice. > + Being curious: this sounds rather like a bug fix. Is this worth to be mentioned in etc/NEWS? Best regards, Michael. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 5b962a7: Avoid double argument evaluation in vc-call macro 2021-09-21 12:51 ` master 5b962a7: Avoid double argument evaluation in vc-call macro Michael Albinus @ 2021-09-21 13:40 ` Po Lu 2021-09-21 16:51 ` Basil L. Contovounesios 2021-09-21 13:45 ` Basil L. Contovounesios 1 sibling, 1 reply; 7+ messages in thread From: Po Lu @ 2021-09-21 13:40 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel, Basil L. Contovounesios Michael Albinus <michael.albinus@gmx.de> writes: > Being curious: this sounds rather like a bug fix. Is this worth to be > mentioned in etc/NEWS? FWIW I remember the docstring containing something along the lines of: BEWARE!! FILE is evaluated twice!! While it personally doesn't affect me, it seems likely for there to be people who actually rely on this documented behaviour. Is it really a good idea to change it so arbitrarily? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 5b962a7: Avoid double argument evaluation in vc-call macro 2021-09-21 13:40 ` Po Lu @ 2021-09-21 16:51 ` Basil L. Contovounesios 0 siblings, 0 replies; 7+ messages in thread From: Basil L. Contovounesios @ 2021-09-21 16:51 UTC (permalink / raw) To: Po Lu; +Cc: Michael Albinus, emacs-devel Po Lu [2021-09-21 21:40 +0800] wrote: > Michael Albinus <michael.albinus@gmx.de> writes: > >> Being curious: this sounds rather like a bug fix. Is this worth to be >> mentioned in etc/NEWS? > > FWIW I remember the docstring containing something along the lines of: > BEWARE!! FILE is evaluated twice!! > > While it personally doesn't affect me, it seems likely for there to be > people who actually rely on this documented behaviour. Is it really a > good idea to change it so arbitrarily? I think so. No reasonable interpretation of "¡BEWARE! ¡IRREGULAR MACRO!" would involve relying on this pitfall. In most cases it would mean passing a self-evaluating expression as the macro's second argument, to protect against the irregularity. Since it is trivial for users of vc-call to support both its current and previous semantics, there is also little reason to worry about breaking compatibility. -- Basil ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 5b962a7: Avoid double argument evaluation in vc-call macro 2021-09-21 12:51 ` master 5b962a7: Avoid double argument evaluation in vc-call macro Michael Albinus 2021-09-21 13:40 ` Po Lu @ 2021-09-21 13:45 ` Basil L. Contovounesios 2021-09-21 13:52 ` Dmitry Gutov 2021-09-21 14:10 ` Michael Albinus 1 sibling, 2 replies; 7+ messages in thread From: Basil L. Contovounesios @ 2021-09-21 13:45 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel Michael Albinus [2021-09-21 14:51 +0200] wrote: > blc@savannah.gnu.org (Basil L. Contovounesios) writes: > >> --- a/etc/NEWS >> +++ b/etc/NEWS >> @@ -1749,6 +1749,9 @@ tags to be considered as well. >> *** New user option 'vc-git-log-switches'. >> String or list of strings specifying switches for Git log under VC. >> >> +--- >> +*** The macro 'vc-call' no longer evaluates its second argument twice. > > Being curious: this sounds rather like a bug fix. Yes, that was my first thought as well. > Is this worth to be mentioned in etc/NEWS? Personally I think all of my commits are newsworthy ;). Lars argued that the "buggy" behaviour was explicitly documented for a long time, so it's safer to announce it: https://bugs.gnu.org/50690#8 I was happy to oblige to tickle my megalomania and because I'm just a poor student who can't afford to be sued. -- Basil ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 5b962a7: Avoid double argument evaluation in vc-call macro 2021-09-21 13:45 ` Basil L. Contovounesios @ 2021-09-21 13:52 ` Dmitry Gutov 2021-09-21 14:20 ` Eli Zaretskii 2021-09-21 14:10 ` Michael Albinus 1 sibling, 1 reply; 7+ messages in thread From: Dmitry Gutov @ 2021-09-21 13:52 UTC (permalink / raw) To: Basil L. Contovounesios, Michael Albinus; +Cc: emacs-devel On 21.09.2021 16:45, Basil L. Contovounesios wrote: > Lars argued that the "buggy" behaviour was explicitly documented for a > long time, so it's safer to announce it:https://bugs.gnu.org/50690#8 > > I was happy to oblige to tickle my megalomania and because I'm just a > poor student who can't afford to be sued. I think the NEWS entry could be useful for someone who comes later and writes code which needs to be compatible with previous versions of Emacs: if double evaluation is a problem for them, they could at least find the NEWS entry, to see when it was fixed. We don't usually do that for bug fixes, but since this was the documented behavior... *shrug* ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 5b962a7: Avoid double argument evaluation in vc-call macro 2021-09-21 13:52 ` Dmitry Gutov @ 2021-09-21 14:20 ` Eli Zaretskii 0 siblings, 0 replies; 7+ messages in thread From: Eli Zaretskii @ 2021-09-21 14:20 UTC (permalink / raw) To: Dmitry Gutov; +Cc: contovob, michael.albinus, emacs-devel > From: Dmitry Gutov <dgutov@yandex.ru> > Date: Tue, 21 Sep 2021 16:52:43 +0300 > Cc: emacs-devel@gnu.org > > On 21.09.2021 16:45, Basil L. Contovounesios wrote: > > Lars argued that the "buggy" behaviour was explicitly documented for a > > long time, so it's safer to announce it:https://bugs.gnu.org/50690#8 > > > > I was happy to oblige to tickle my megalomania and because I'm just a > > poor student who can't afford to be sued. > > I think the NEWS entry could be useful for someone who comes later and > writes code which needs to be compatible with previous versions of > Emacs: if double evaluation is a problem for them, they could at least > find the NEWS entry, to see when it was fixed. > > We don't usually do that for bug fixes, but since this was the > documented behavior... *shrug* Yes, it's borderline, so I see no harm in having that in NEWS. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master 5b962a7: Avoid double argument evaluation in vc-call macro 2021-09-21 13:45 ` Basil L. Contovounesios 2021-09-21 13:52 ` Dmitry Gutov @ 2021-09-21 14:10 ` Michael Albinus 1 sibling, 0 replies; 7+ messages in thread From: Michael Albinus @ 2021-09-21 14:10 UTC (permalink / raw) To: Basil L. Contovounesios; +Cc: emacs-devel "Basil L. Contovounesios" <contovob@tcd.ie> writes: Hi Basil, >> Is this worth to be mentioned in etc/NEWS? > > Personally I think all of my commits are newsworthy ;). For sure! > Lars argued that the "buggy" behaviour was explicitly documented for a > long time, so it's safer to announce it: https://bugs.gnu.org/50690#8 I don't object; I was just curious :-) Best regards, Michael. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-21 16:51 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20210921115002.28282.50636@vcs0.savannah.gnu.org> [not found] ` <20210921115004.44D90200AF@vcs0.savannah.gnu.org> 2021-09-21 12:51 ` master 5b962a7: Avoid double argument evaluation in vc-call macro Michael Albinus 2021-09-21 13:40 ` Po Lu 2021-09-21 16:51 ` Basil L. Contovounesios 2021-09-21 13:45 ` Basil L. Contovounesios 2021-09-21 13:52 ` Dmitry Gutov 2021-09-21 14:20 ` Eli Zaretskii 2021-09-21 14:10 ` Michael Albinus
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.