From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#50552: 28.0.50; Add context-menu-occur Date: Tue, 28 Sep 2021 20:00:57 +0000 Message-ID: <874ka4v5ae.fsf@posteo.net> References: <87ilz5d9a1.fsf@posteo.net> <87o88xu13p.fsf@mail.linkov.net> <87a6khd316.fsf@posteo.net> <8735q8g9dj.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30612"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50552@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 28 22:02:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mVJIr-0007ng-E3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 22:02:13 +0200 Original-Received: from localhost ([::1]:38062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVJIo-0001zu-Rn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Sep 2021 16:02:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVJIg-0001zS-Ah for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 16:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35566) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mVJIg-0001vd-0e for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 16:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mVJIf-00073O-TF for bug-gnu-emacs@gnu.org; Tue, 28 Sep 2021 16:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Sep 2021 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50552-submit@debbugs.gnu.org id=B50552.163285927027051 (code B ref 50552); Tue, 28 Sep 2021 20:02:01 +0000 Original-Received: (at 50552) by debbugs.gnu.org; 28 Sep 2021 20:01:10 +0000 Original-Received: from localhost ([127.0.0.1]:47112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVJHq-00072E-Jr for submit@debbugs.gnu.org; Tue, 28 Sep 2021 16:01:10 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:56837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVJHl-00071b-Do for 50552@debbugs.gnu.org; Tue, 28 Sep 2021 16:01:09 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 850F6240104 for <50552@debbugs.gnu.org>; Tue, 28 Sep 2021 22:00:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1632859259; bh=r7Fxc19zQ8lHbTWcVqMofKo+Pu6om13ECQf4j5QHop4=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=AUdmsIzU81jwpy2R0EKNr1FCXF8yTCZTQ/fCAC83WEYL9KpQp1ehyVBYgahGAJ+Td McmlhDl02vWMSAqytDT+w5dbEKbMU0Q183/5z2lOieHKFIZiI2Ztjb5yrwU6bd4DBG oPVaZAArmmupTVkBaVsnhxXfTzLSrend0zR29bNIK29vUXHf8iHi+Gagc/ox9ENHl1 zk8PgP9lwWy7oK72q9Sq1idTM1t2pmcqCXfIjbrQZch9kqyYherPhb1C47qLFvq/sZ hkD4eddQGYiJH44xKZjZeYBo7GdatBu8S+UjXrM0A0JYug6taYxNQLaS7LN/jvTMtF TmUTU4/TVVk+w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HJr3b0bVTz9rxG; Tue, 28 Sep 2021 22:00:59 +0200 (CEST) In-Reply-To: <8735q8g9dj.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 13 Sep 2021 11:28:24 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215798 Archived-At: Juri Linkov writes: >> I see, but I wonder why dictionary.el directly manipulates >> context-menu-functions with add-hook. > > The reasoning was the following: by default, dictionary.el is not loaded, > so its context menu item is not used. But when the user wants to use > dictionary.el and explicitly loads it, then automatically provide also > its context menu item. On this topic, I am not sure how good it is to do this automatically. One effect seems to be that context-menu-dictionary inserts itself at an unintended place in the menu (in my case as the first item, even though I'd prefer it to be further down). Might it make more sense to autoload context-menu-dictionary and let the user manually add it to context-menu-functions? -- Philip Kaludercic