From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks Date: Wed, 29 Dec 2021 19:25:52 +0800 Message-ID: <874k6rtzy7.fsf@yahoo.com> References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> <87sfubfzwt.fsf@gmx.net> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28948"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.60 (gnu/linux) Cc: 52856@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 29 12:27:40 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2X7M-0007NQ-FD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Dec 2021 12:27:40 +0100 Original-Received: from localhost ([::1]:40388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2X7K-0003nj-A3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Dec 2021 06:27:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2X6l-0003n3-Re for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 06:27:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36587) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2X6k-0001h2-G4 for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 06:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2X6k-0005KQ-C4 for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 06:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Dec 2021 11:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52856-submit@debbugs.gnu.org id=B52856.164077717220426 (code B ref 52856); Wed, 29 Dec 2021 11:27:02 +0000 Original-Received: (at 52856) by debbugs.gnu.org; 29 Dec 2021 11:26:12 +0000 Original-Received: from localhost ([127.0.0.1]:48133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2X5w-0005JO-5R for submit@debbugs.gnu.org; Wed, 29 Dec 2021 06:26:12 -0500 Original-Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:37147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2X5t-0005J8-DG for 52856@debbugs.gnu.org; Wed, 29 Dec 2021 06:26:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640777163; bh=NJSqyqXMSQ3fYc4sz6P5ZHurYvqbe1pDjswDr+WwBgE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=qMs/GLr3ZtLVhppU8BwZ4jzimJ0sRQ+JUVsldsK9H1xQvdIii/6QWNHmjHN6XmaPrcn4FmC2IiV9qJ66ouCjRaiNhvGVB0t/aIx4EIiv3OiJv3z9Dnht5Arv7xxCkDxx9BnEP1tTPF+OP+yp+7UIB7C69Tf4kpRcZNfluxFXSQpfTZV1iPWpoykcIlWJKC/9DAgrkzy6h5vfeaueLnZzXSvKw9y0aXtBFXLkSHxlGqOjXDHibH1OIEGDxgRFxh3ihN65HtoP6nmjuASlxb3J9l/GKdZEsvuywLG1QsP3HahbrWxjW65kx39M3eYA25wrJsoGFgBSvmV0FUKmkzNv1g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1640777163; bh=c55wA5iKrDehV0WgYfV2UGKxZQY5RtxA4BT+8S7esGJ=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=L3RFMyv6wRu03vpEa2UTGgkSoeZYVChNDIBfH+cNuVJl4+9tcyhiUQDRU+YyVO++u2nvpKb3wJECDRmOsu2DqYKvAvSUNdbHlS47zdA54wBJVI4aRYTRLUuBnXLOvGpPN+c5vdoPV3oA3rI2OWH3naTcQ7G7kt27rSTCAdiPZW+XRhoRUyy97ZuIy/9MoqC8ogW85iLS9TKPyX19XR4qi6WA5b+Ru4XHZeHcq9RF8CId0CY2+WZcAT5lm45WV68jL3UjuHL74jSjB7i/+9kuhpg+CHQG5TNutUxV3ug2/t+Z9DoOz+aioIvG1qUeOhiNwNlsMTEVkFFxvfjw4Tbo0Q== X-YMail-OSG: Z4NNMlYVM1ku.YqMj79kxBv4WijHjAfefrvHdgpHTXgHG2T6vvBfihm4TJv6z5o OwGoEbylbX3zZJzclbJmNMaEIxedNfASvvIM0vfHI3ABiOY_kgmjqQitmni3afz0wJR9N4Pra199 jtgZZ0SgRkivu8ip5f.ptViSDhGSCypF2d7Y.cmMGlGSIVzc0gXlnkkjq7Or4BWIGOQGSJtXQhF8 46dSaMHsTAJN39v7Y_EjfiK6PLMbxB3DCpP5X5DVa7dwqAF3CH.6NVdTi9VUFOem.CEjCvVxa7K. 0QmBOVaEd6vf4t1vXc9vr2vnAO67eOys21CxrK0tOB.4FszOmzqr5A2t4ncqfmB0x3kaMyeJh0Uo XOUwJC6Dwc4MwcieTmcnhCiSbnZW19qk7vUxvWOikhJqGvVOzNB2sQAqKHMH3ulJnAViy26ih_cU RwswrfYozJ0D0WRG4dD2r090nKVRClWghpxyMXonPdnobMUVsS.J2.twCAOu_74u0v4ehpgK1fWy JS3PZm2Ia19AhMqbUQb8L00aGFJtVThsZed2GeEVLk4QCUShAG945ixr6lbYjHgwk9fYN.ZaHT2U jdeuH0bICwMzjGJvJ_weburmh9.0OWWAgLt26IiHxCjTxRGL4KtsjMmeKtAUM8SeyJ2nRaqXNo7f dhMoAQOnIEyz5td7hVKi..YIgk8ns7FhoqRLMv3hrfPUzNsU7iCblWmAL2ME0tXock0MgZ1sg8Zr zmO2maXXqVRCmmIYxS5TnyiZXWCzpD.b.zzBHpX6Lfs_zqMtkclAQ76GorG0igjk3rxZLnsBTpUq 9.P4A1.aoujT_7z30WRmY3uAc1GuUrEPRKOaTbN0Y5 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Wed, 29 Dec 2021 11:26:03 +0000 Original-Received: by kubenode513.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID b040b37441ce86b35d7b026f3293d1e2; Wed, 29 Dec 2021 11:25:56 +0000 (UTC) In-Reply-To: <87sfubfzwt.fsf@gmx.net> (Stephen Berman's message of "Wed, 29 Dec 2021 11:50:26 +0100") X-Mailer: WebService/1.1.19498 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223317 Archived-At: Stephen Berman writes: > I did, but that just ensures that jumping to the bookmarked xwidget > creates a new xwidget session -- it does not prevent the xwidget from > being displayed both in the other window/frame and in the originally > selected window. My patch ensures that the bookmarked xwidget is > displayed only in the other window/frame, which is consistent with the > behavior of `bookmark-jump-other-window' and `bookmark-jump-other-frame' > with other types of bookmarks (e.g. to PDFs in the pdf-tools package), > regardless of whether a new xwidget session is created. Okay, thanks -- some comments below: > + (with-temp-buffer > + (xwidget-webkit-new-session url) > + (current-buffer)) Why with-temp-buffer? xwidget-webkit-new-session creates a new buffer and switches to it, which is not appropriate if you want to obtain a buffer containing the new xwidget. I suggest that you write a new function that creates the buffer, displays the xwidget, and returns the buffer, preferably also updating xwidget-webkit-new-session to use it as well. > + (switch-to-buffer curbuf) > + (set-buffer xwbuf))) See above.