all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: "Johan Tolö" <johan@toloe.se>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-attach-use-inheritance inherits from sibling
Date: Sat, 15 Jan 2022 19:52:51 +0800	[thread overview]
Message-ID: <874k65rzak.fsf@localhost> (raw)
In-Reply-To: <87o886cgst.fsf@localhost>

Ihor Radchenko <yantar92@gmail.com> writes:

> Johan Tolö <johan@toloe.se> writes:
>
>> If "* Top heading" is the first heading in the buffer with nothing 
>> above it, not even a whitespace/newline, then '(org-entry-get nil 
>> "id" t)' with point in "* Second heading" will return the id of 
>> "Top heading". If there is anything before "Top heading" then 
>> 'nil' will be returned.
>>
>> This happens when I run 'emacs -Q' from within the "lisp" 
>> directory of a newly cloned "org-mode" main branch.
>
> Ouch. Thanks for reporting!
>
> Confirmed
>
> The fix is attached.
>
> Dear all,
>
> I had to fix one of the tests, that apparently was only working because
> the bug existed. Please double check.

For record, this patch has been incorporated as parts of two other
patches.

Best,
Ihor


      reply	other threads:[~2022-01-15 11:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06  9:22 org-attach-use-inheritance inherits from sibling Johan Tolö
2021-10-01 14:19 ` Ihor Radchenko
2021-10-03 13:28   ` Johan Tolö
2021-10-03 14:40     ` [PATCH] " Ihor Radchenko
2022-01-15 11:52       ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874k65rzak.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=johan@toloe.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.