From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems Date: Sun, 13 Feb 2022 21:16:19 +0800 Message-ID: <874k52kiu4.fsf@yahoo.com> References: <83czjqrkew.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33613"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 13 14:18:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJElk-0008e1-MN for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 14:18:24 +0100 Original-Received: from localhost ([::1]:52480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJElh-00082h-Pa for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 08:18:21 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJEk1-00077T-Al for emacs-devel@gnu.org; Sun, 13 Feb 2022 08:16:40 -0500 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:41141) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJEjx-0001vP-VJ for emacs-devel@gnu.org; Sun, 13 Feb 2022 08:16:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644758189; bh=SffUQlUSM3LKds5PtGq3/mMjk6o8c/dyJ4KfG3QKyJk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=bPgHvaW3tyW0Kr/OThfbMApTexJUW0uFCTZxqkYFa6iVgkgAv7/kk2jCY5XrtnTTPl/Vm3ublrdC53+X+CRn1mdOJLrs29pT9lOmeptcvL1dfIyQEsD6v17GW04l5Qei3jJXf5Bz559YlhOOltXuZr6oh+zuP/xNlYTTGECcTeakxGoPNEOVgwdrukMD0TL9dDO4cB1cquzNTjg1ULINze4IwUW3SwZajBwRyGFvekSfa91/O7nihkl6cNZMJMEKHSDvYfM+OancGAQTbyBvR333Xe7FGf1Wy02qd7mSYQHoEOuEzDVRuVYdrmfilORZy5Gb1x5wuyDU5+RWXMHhCg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1644758189; bh=8BQobRWR7UogUDq/5uN1h2v+UjGE1saNn2pV3huH0t+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=NYW6clUgREBDL0oIFcuowbJ1YVZxK+/B2iIRjicheCR/n7iMdB8MpK2V17weIjQA5Jr5NGRP4M2mCTbCYcRdf0C7oEh4jwk1i3G1D63WxKzvlfNqYSkPWnHK/Y7iZVUqjkJGXurf2kuALbrgrjO9GSqAWwbGZQh450Ic6jvWwLV8eMokqoRNPUd2AABv5q3YL5ZbcQ3sut1oXK91kPW2IJPL0VEiE4Tcw9cG32or5VOosHr9RZ0c+IlxjILnM3kfz66nUZIL8LHJ3QgLdOvDuwhylyxp8ZYtubznXDZopMq4JquundvwaAPb+Zmlwo8bdyWLx8R3Zuui8JYFS1TxcQ== X-YMail-OSG: S1xdJmIVM1lm1ispXXLSuADxXQts9BxsXqEok2lqIxc9OIu_kTsHYxnVfu7gFpM 87zmspBa0sJEFJaqaM7335SCqLAmRAiNZc2pPS8D7lyikMrB3Iq5Q8RWqVp8rkMjJZYZPs0oFO6Z lERNhtK03eb4fELAztTRO56P7byX5MTiVjxhrVKyeeG3pLmsQLllBcb4StSoCxlhgqmJfLp2YX_w Ck3z0dKSRPYOJNx5Q1JaXR7dKq4jU9.7m4q8OGTFi9zc.kcEkDFTI8.eLhQwy00ioatrTcOziS9Z 9oH4ZZ2iJ.dca6zA119EC.dqFjvwxvw2iu.rgPp4_eCIqw0PDYwMH6eImVWALwFKa6NPRLGH0zmx EDypxqvermodKlhJk_763thNHXIPDKP7l1i.jncX_nS0lfXPiFN0rF.yueJk86DThQtKcnmrf4Z0 FuaGUz9GD93tpzZVDxw..w7jQV674fnz2MDftie148bEuAE.0J9QFLKDU26Yk48LgPm.KLN9Azt6 rMYACuxrw3c1fF3RRXc93qaJ6IPWsgup0harvRrT3cylHZKt3JPNyrOkawUFIZzohrAfj5Ifx3w1 Z0NlxegLRi6lHrSRWUVBVxiPZhtBdVTNTBo1yqOy0cjVGbGymj9Co1nPhWajeZ7uVMvdDWMFMMHn u0nZgpsngxXD8.DsUEI.ywz_6l5Ogmb4lzmEsuWjFXGvOqssRpAPGDfqEbUnZ8YvQV1bTRW2wfaT hAqU0FcV1nsToAg9aYlrPRhm066_kukLTg4fnjvde3cYziKEzxMNZswWsuxmdFtYyJu9NgPSZG6o GBjB7Pb1S7KrWsIzM0fIpqdUBK6OKUsnnkniT4Mset X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Sun, 13 Feb 2022 13:16:29 +0000 Original-Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 78eef56e753c3dadb1aa6c7726da6522; Sun, 13 Feb 2022 13:16:25 +0000 (UTC) In-Reply-To: <83czjqrkew.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Feb 2022 15:00:23 +0200") X-Mailer: WebService/1.1.19724 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.188.204; envelope-from=luangruo@yahoo.com; helo=sonic311-23.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286211 Archived-At: Eli Zaretskii writes: > First, we don't use "illegal" in these cases, we use "invalid": > there's nothing against any law in using bad values of some variables. Okay, thanks. I'll keep that in mind in the future. > More importantly, why punting in these cases is the best possible > solution? why not fall back to some reasonable encoding instead? I think that if the locale coding system is set to an invalid value, then the user probably knows there is a need to set it to something other than the default value, but made a typo somewhere. Decoding multibyte X keyboard input and XIM pre-edit text with any coding system other than the actual locale coding system will result in nonsensical text. Maybe the best thing to do would be to log a message stating that the specified coding system is invalid. > And how come locale-coding-system is not a valid coding-system there > in the first place? The user could have set it to an invalid value, which leads to spectacular crashes when setup_coding_system signals inside a GTK event filter. Thanks.