From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems
Date: Sun, 13 Feb 2022 21:16:19 +0800 [thread overview]
Message-ID: <874k52kiu4.fsf@yahoo.com> (raw)
In-Reply-To: <83czjqrkew.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 13 Feb 2022 15:00:23 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> First, we don't use "illegal" in these cases, we use "invalid":
> there's nothing against any law in using bad values of some variables.
Okay, thanks. I'll keep that in mind in the future.
> More importantly, why punting in these cases is the best possible
> solution? why not fall back to some reasonable encoding instead?
I think that if the locale coding system is set to an invalid value,
then the user probably knows there is a need to set it to something
other than the default value, but made a typo somewhere.
Decoding multibyte X keyboard input and XIM pre-edit text with any
coding system other than the actual locale coding system will result in
nonsensical text.
Maybe the best thing to do would be to log a message stating that the
specified coding system is invalid.
> And how come locale-coding-system is not a valid coding-system there
> in the first place?
The user could have set it to an invalid value, which leads to
spectacular crashes when setup_coding_system signals inside a GTK event
filter.
Thanks.
next prev parent reply other threads:[~2022-02-13 13:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 13:00 master 6ed1994d27: Prevent crashes from illegal locale coding systems Eli Zaretskii
2022-02-13 13:16 ` Po Lu [this message]
2022-02-13 13:45 ` Eli Zaretskii
2022-02-14 0:51 ` Po Lu
2022-02-14 3:32 ` Eli Zaretskii
2022-02-14 4:46 ` Po Lu
2022-02-14 14:07 ` Eli Zaretskii
[not found] ` <87iltheyeu.fsf@yahoo.com>
[not found] ` <83wnhwol2o.fsf@gnu.org>
[not found] ` <87tud0ybhj.fsf@yahoo.com>
[not found] ` <837d9w450e.fsf@gnu.org>
2022-02-15 13:55 ` Po Lu
2022-02-15 14:07 ` Eli Zaretskii
2022-02-16 0:49 ` Po Lu
2022-02-16 2:38 ` Po Lu
2022-02-16 5:12 ` Po Lu
2022-02-16 12:22 ` Eli Zaretskii
2022-02-16 12:33 ` Po Lu
2022-02-16 12:38 ` Eli Zaretskii
2022-02-16 13:05 ` Po Lu
2022-02-16 13:33 ` Eli Zaretskii
2022-02-16 13:40 ` Po Lu
2022-02-16 14:05 ` Eli Zaretskii
2022-02-17 0:45 ` Po Lu
2022-02-17 6:31 ` Eli Zaretskii
2022-02-17 6:51 ` Po Lu
2022-02-17 7:23 ` Eli Zaretskii
2022-02-17 7:44 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k52kiu4.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.