From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting. Date: Fri, 04 Mar 2022 16:15:51 +0100 Message-ID: <874k4dlpeg.fsf@elite.giraud> References: <875yovm1m6.fsf@elite.giraud> <87v8wvkk64.fsf@red-bean.com> <83v8wuj3v0.fsf@gnu.org> <87tucewgu7.fsf@red-bean.com> <83lexqi3z9.fsf@gnu.org> <87tuceuo4b.fsf@red-bean.com> <83czj2hrdv.fsf@gnu.org> <87a6e5lui6.fsf@elite.giraud> <837d99j10x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21015"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) Cc: kfogel@red-bean.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 04 16:33:45 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nQ9w8-0005JF-Va for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 16:33:45 +0100 Original-Received: from localhost ([::1]:40778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ9w7-0006np-KP for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Mar 2022 10:33:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ9f5-0005K4-Jz for emacs-devel@gnu.org; Fri, 04 Mar 2022 10:16:08 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:26398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ9f1-0005BN-W8; Fri, 04 Mar 2022 10:16:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=V82+spCgHmLes2tL v1cJgttPwIUYFZzUk+i31ktmFiw=; h=in-reply-to:date:references:subject: cc:to:from; d=ledu-giraud.fr; b=iUglXLi/63YzA558myz8IOz61aPrvvfsQ4G0Be RnFbWZZVX5jdxYtDzk4Yyi88TmwU3OPA0o6G0CwM4iHcnNnQj3UGC9226e49fzdJrY0pMC yGm0GUHq6sW28XayaBpq0Klpf9qux5pmrIFPrNLP5LIccU+6bVoBf8MBP/KSgCOELsGM/L any+b952ICmUg5wmstIjQnVvWtv84kfqL7mjGsOLEuyV9UrWjEL+bMNgoa6Yf5fNPdHH0g QqaGZ03mEoDHb93DDK5ApdIirZ4E4o48Z8UNgRkFnu9Pcv2HmSlIZ7UgimLKzNG023Ne2S WmsSmKxEwmH6DoYX50wMKiKA== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 7b611be6 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 4 Mar 2022 16:15:53 +0100 (CET) In-Reply-To: <837d99j10x.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 04 Mar 2022 15:33:02 +0200") Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286821 Archived-At: Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: Karl Fogel , emacs-devel@gnu.org >> Date: Fri, 04 Mar 2022 14:25:37 +0100 >>=20 >> I cannot say if it is a regression but it seems that the patch >> 61e51fee9ca3 of october 17, 2020 rewrote bookmark-bmenu-mode to use >> tabulated-list-mode and set the tabulated-list-sort-key on the bookmark >> name. > > Thanks. So this did work correctly in Emacs 27.2? > > Or maybe you can show a simple recipe starting from "emacs -Q", then I > could see for myself what happened in Emacs 27 vs Emacs 28. This would do: --8<---------------cut here---------------start------------->8--- (defun dobook (name) (with-current-buffer (get-buffer-create name) (set-visited-file-name (format "/tmp/%s" name)) (bookmark-set (buffer-name)))) (progn (dobook "a") (dobook "b")) --8<---------------cut here---------------end--------------->8--- And then "M-x bookmark-bmenu-list". As bookmark "b" was the last defined, it should be at the top of the list=E2=80=A6 but I've just tested = in Emacs 27.2 and the bookmark list was already alphabetically sorted. So I guess this is not a regression (and won't make it into 28 then). --=20 Manuel Giraud