From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Kiên Nguyễn Quang" <kien.n.quang@gmail.com>
Cc: 54721@debbugs.gnu.org
Subject: bug#54721: 29.0.50; browse-url-file-url fails on Windows since e06319b
Date: Wed, 06 Apr 2022 11:59:48 +0200 [thread overview]
Message-ID: <874k36edm3.fsf_-_@gnus.org> (raw)
In-Reply-To: <CAL7sU5ji=-NOOTT+-eBD=4PgVAxP+eP-P+u+vkpuxyW=OaHOSg@mail.gmail.com> ("Kiên Nguyễn Quang"'s message of "Wed, 6 Apr 2022 14:39:44 +0900")
Kiên Nguyễn Quang <kien.n.quang@gmail.com> writes:
> - (push "" components)
> + (push (if (string-empty-p dir) "" (substring dir 0 -1)) components)
Thanks; applied with some changes.
> + (let ((url-unreserved-chars `(?: ,@url-unreserved-chars)))
> + (setq file (mapconcat #'url-hexify-string
> + (file-name-split file)
> + "/"))))
This isn't quite correct, because we do want to encode : characters in
file names in general -- just not the first bit on Windows. So I've
adjusted the patch and pushed to Emacs 29.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-04-06 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 6:57 bug#54721: 29.0.50; browse-url-file-url fails on Windows since e06319b Kiên Nguyễn Quang
[not found] ` <handler.54721.B.164914187929306.ack@debbugs.gnu.org>
2022-04-06 0:30 ` bug#54721: Acknowledgement (29.0.50; browse-url-file-url fails on Windows since e06319b) Kiên Nguyễn Quang
2022-04-06 5:39 ` Kiên Nguyễn Quang
2022-04-06 9:59 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k36edm3.fsf_-_@gnus.org \
--to=larsi@gnus.org \
--cc=54721@debbugs.gnu.org \
--cc=kien.n.quang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.