From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: ./configure --enable-check-lisp-object-type Date: Tue, 12 Apr 2022 20:27:42 +0200 Message-ID: <874k2ycg2p.fsf@gnus.org> References: <878rsack6p.fsf@gnus.org> <83o81642pq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6997"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Stefan Monnier , Andrea Corallo To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 12 20:28:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neLG1-0001c1-5U for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 20:28:53 +0200 Original-Received: from localhost ([::1]:46640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1neLFz-0002Ap-Qc for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Apr 2022 14:28:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neLF4-0000kB-EG for emacs-devel@gnu.org; Tue, 12 Apr 2022 14:27:54 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:39642) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1neLF2-0000wn-RR; Tue, 12 Apr 2022 14:27:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5RubPIg5vSU+5DRTfIgUqXPECdkQdz/3vt8lU03zB6E=; b=CgVgsVjiyd9B5kU8jXVUEQ6olm YcZRnsMJZbcnZWjojB7AVIkjh35A9zUVIM6SEwcKtzLYTV3zviI+sGqQh4C4vZgnOQtrChAYYPGrb OmN/s3b1eycc6w++rFwQerYQ1aIEUuAAPMMrz6vMy07QdQiyyft3fqwAwpzytdxaJhmQ=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1neLEt-0002uY-9s; Tue, 12 Apr 2022 20:27:46 +0200 In-Reply-To: <83o81642pq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Apr 2022 20:43:29 +0300") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288331 Archived-At: Eli Zaretskii writes: > That zero corresponds to the 'Lisp_Object command_modes' member of > Aligned_Lisp_Subr, and in a build with --enable-check-lisp-object-type > a Lisp_Object is a struct, so it must be initialized with {0}, not > just a scalar zero. I can confirm that adding braces around the zero makes these warnings go away. There's similar warnings in alloc: alloc.c: In function 'syms_of_alloc': alloc.c:7838:6: warning: missing braces around initializer [-Wmissing-braces] 7838 | {{{ PSEUDOVECTOR_FLAG | (PVEC_SUBR << PSEUDOVECTOR_AREA_BITS) }, | ^ 7839 | { .a4 = watch_gc_cons_threshold }, 7840 | 4, 4, "watch_gc_cons_threshold", {0}, 0}}; | {} And adding braces around the zero does the trick there, too. There's still a number of other warnings which may or may not be valid (I haven't actually looked at them): In file included from dbusbind.c:26: dbusbind.c: In function 'xd_signature': lisp.h:409:38: warning: potential null pointer dereference [-Wnull-dereference] 409 | #define lisp_h_XCAR(c) XCONS (c)->u.s.car | ~~~~~~~~~~~~~~^~~~ lisp.h:1498:10: note: in expansion of macro 'lisp_h_XCAR' 1498 | return lisp_h_XCAR (c); | ^~~~~~~~~~~ lisp.h:409:38: warning: potential null pointer dereference [-Wnull-dereference] 409 | #define lisp_h_XCAR(c) XCONS (c)->u.s.car | ~~~~~~~~~~~~~~^~~~ And a some other warnings, too -- about half a dozen, I'd say. Is the --enable-check-lisp-object-type build supposed to be without warnings, or has that never been the ambition? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no