From: Lars Ingebrigtsen <larsi@gnus.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 55140@debbugs.gnu.org, "José Júnior" <jjnilton@gmail.com>
Subject: bug#55140: 27.1; Feature request: allow customize holidays list
Date: Wed, 27 Apr 2022 18:50:56 +0200 [thread overview]
Message-ID: <874k2esc5r.fsf@gnus.org> (raw)
In-Reply-To: <18k0ba8p5c.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 27 Apr 2022 12:30:39 -0400")
Glenn Morris <rgm@gnu.org> writes:
> I don't understand this request, nor the solution.
>
> list-holidays allows the list of holidays to be passed as third argument.
That doesn't really help with the interactive spec, which is what's been
changed.
> This argument defaults to the variable calendar-holidays,
> which is a defcustom. So that seems like two ways you can control
> the list of holidays?
calendar-holidays controls the "All" value.
> The solution splits the completion list used by the interactive
> prompting into a separate function. Is the misspelling "holydays"
> intentional?
Nope; fixed.
>
> "you can alter the results by redefining that function, or use
> `add-function' to all values.". The last part of that doesn't make sense.
Typo.
> And you can redefine any function in Emacs, so does this really need stating?
I think it makes sense to state that this is the intended customisation
point for users.
> But how is this any better than defining your own interactive wrapper
> function that just calls list-holidays non-interactively with the
> desired list?
That's a possibility, of course, but somewhat convoluted.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2022-04-27 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 2:22 bug#55140: 27.1; Feature request: allow customize holidays list José Júnior
2022-04-27 12:58 ` Lars Ingebrigtsen
2022-04-27 16:30 ` Glenn Morris
2022-04-27 16:50 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k2esc5r.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=55140@debbugs.gnu.org \
--cc=jjnilton@gmail.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.