From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 5743b74d4b 1/2: Improve mouse dragging
Date: Fri, 13 May 2022 20:45:23 +0800 [thread overview]
Message-ID: <874k1tvbx8.fsf@yahoo.com> (raw)
In-Reply-To: <83wnepmy7q.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 May 2022 15:08:41 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> If we come up with a safe enough fix, we could consider backporting it
> to the release branch.
I think the display issue is not serious enough to backport (and
probably can't be fixed safely).
But the tooltip face overwriting the text completely prevents any
meaningful use of `mouse-drag-and-drop-region'. This is enough to fix
that bug alone:
diff --git a/lisp/mouse.el b/lisp/mouse.el
index 1b9542b9b8..e5ea5475f4 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -3049,7 +3049,7 @@ mouse-drag-and-drop-region
;; Show a tooltip.
(if mouse-drag-and-drop-region-show-tooltip
- (tooltip-show text-tooltip)
+ (tooltip-show (copy-sequence text-tooltip))
(tooltip-hide))
;; Show cursor and highlight the original region.
WDYT?
next prev parent reply other threads:[~2022-05-13 12:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 7:31 master 5743b74d4b 1/2: Improve mouse dragging Eli Zaretskii
2022-05-12 12:03 ` Po Lu
2022-05-12 12:47 ` Eli Zaretskii
2022-05-12 13:02 ` Po Lu
2022-05-12 13:12 ` Eli Zaretskii
2022-05-12 13:20 ` Eli Zaretskii
2022-05-12 13:25 ` Po Lu
2022-05-12 13:23 ` Po Lu
2022-05-12 13:51 ` Eli Zaretskii
2022-05-13 0:27 ` Po Lu
2022-05-13 6:00 ` Eli Zaretskii
2022-05-13 7:05 ` Po Lu
2022-05-13 7:36 ` Eli Zaretskii
2022-05-13 7:49 ` Po Lu
2022-05-13 10:32 ` Eli Zaretskii
2022-05-13 11:10 ` Po Lu
2022-05-13 12:08 ` Eli Zaretskii
2022-05-13 12:45 ` Po Lu [this message]
2022-05-13 12:48 ` Eli Zaretskii
2022-05-13 12:16 ` Eli Zaretskii
2022-05-13 12:46 ` Po Lu
2022-05-12 15:49 ` [External] : " Drew Adams
2022-05-13 0:28 ` Po Lu
2022-05-13 1:49 ` Drew Adams
2022-05-13 3:42 ` Po Lu
2022-05-13 15:30 ` Drew Adams
2022-05-14 0:56 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k1tvbx8.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.