From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#56198: Request to delete window with mouse event Date: Sun, 26 Jun 2022 21:10:35 +0530 Message-ID: <874k07bfgs.fsf@gmail.com> References: <878rpmasxd.fsf@gmail.com-N5LgcGT----2> <83k095b161.fsf@gnu.org> <87k0943k5u.fsf@gmail.com> <87letjeafl.fsf@gnus.org> <878rpjbg50.fsf@gmail.com> <87bkufe91n.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1175"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56198@debbugs.gnu.org, carlmarcos@tutanota.com, eliz@gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 26 17:41:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5UNq-00008h-7E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 17:41:10 +0200 Original-Received: from localhost ([::1]:35950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5UNo-0004UH-R9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jun 2022 11:41:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5UNi-0004Ts-RP for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 11:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54847) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5UNi-0004hh-Io for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 11:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5UNi-0005WE-Bf for bug-gnu-emacs@gnu.org; Sun, 26 Jun 2022 11:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jun 2022 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56198 X-GNU-PR-Package: emacs Original-Received: via spool by 56198-submit@debbugs.gnu.org id=B56198.165625804621185 (code B ref 56198); Sun, 26 Jun 2022 15:41:02 +0000 Original-Received: (at 56198) by debbugs.gnu.org; 26 Jun 2022 15:40:46 +0000 Original-Received: from localhost ([127.0.0.1]:48744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5UNS-0005Vd-Ez for submit@debbugs.gnu.org; Sun, 26 Jun 2022 11:40:46 -0400 Original-Received: from mail-pj1-f67.google.com ([209.85.216.67]:55239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5UNQ-0005VQ-SW for 56198@debbugs.gnu.org; Sun, 26 Jun 2022 11:40:46 -0400 Original-Received: by mail-pj1-f67.google.com with SMTP id cv13so7035724pjb.4 for <56198@debbugs.gnu.org>; Sun, 26 Jun 2022 08:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=D3L6WixVHiKOtvV3W0vXZnn5Uv9xUq6v6aU0/ahekj4=; b=RDo7zALON6oyttEe+7dTi4JmNgc78x60dDDNSClS5OsrtvhoxglUwfD+adGtRPqvqj t2FQawREEeIVgNBls1090nw0jp8M2jqn8NqKZE56IzWxirMTGd1SdJOsIcNPSnYEQ8Td k6+WSHJbAdqrpwcul/sPqzWCM3GSwdezBD1M1YEsW70SIHA/XgGSFJLt2F+3IPS4SdqG JbY3L+N6scRSOiMpIlt0T1J+uGL8zwVummsTwYhdlNbJG7D7XKRp3IE3qwyWu/tqv+sg EV+Jr8ufSFlNWEou63w5JhBY1xI/xwNvMORLYY+8tLaf0C2KTeE3amXpPanHgX8Oe20G Y8yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=D3L6WixVHiKOtvV3W0vXZnn5Uv9xUq6v6aU0/ahekj4=; b=CNLCr31ygToLCFNefoiILpFmB3n/apMWXXNxqEEgYB9YzuwCo1uqxwSC22pwiWey7a gxTTKwjmi3Zciy42vpe2iABNtMLb+bLy2iXja2sIstf/ni9OO0cvGgdq0aA23eAi0f3u fQzIfj9Dh6Aug+NNTpOTeRZb3OtcgStdhsBnSmJuQfdZtrd7hy8QTHyA/YZx/ppXVZdX oAxJh6fC2zkeTlkOhk6fCSOCNRqSShMrVw48/VYMIu97nrD1I7a5Vc+BEuyUW8KmYiW3 1RGH587RqPCBJDE6tYlHzWgwPxZE3Jq/EYo2u1M+6fF9pZm0280hE5sUWFadKQjrDeI6 T9qw== X-Gm-Message-State: AJIora9qT7Z4WDe5rT5nYhKzZdun2jFfEZHwZqpgY4OKnVQ9nTW+fSI3 ArrNMs4/jTEdo0yea07y7D0= X-Google-Smtp-Source: AGRyM1tRbHjVKQPwO2Re/3DEWnZTlvbGyLT8tPzrUXwoOZMHPz4oUXuy7DVuJuTRA3EqpAmJdznP+A== X-Received: by 2002:a17:90a:8d02:b0:1ec:a006:ea13 with SMTP id c2-20020a17090a8d0200b001eca006ea13mr15279363pjo.229.1656258038918; Sun, 26 Jun 2022 08:40:38 -0700 (PDT) Original-Received: from localhost ([49.204.136.42]) by smtp.gmail.com with ESMTPSA id a5-20020a17090a688500b001eca3c66f6asm7387880pjd.43.2022.06.26.08.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Jun 2022 08:40:38 -0700 (PDT) In-Reply-To: <87bkufe91n.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 26 Jun 2022 17:31:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235360 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [=E0=AE=9E=E0=AE=BE=E0=AE=AF=E0=AE=BF=E0=AE=B1=E0=AF=81 =E0=AE=9C=E0=AF=82= =E0=AE=A9=E0=AF=8D 26, 2022] Lars Ingebrigtsen wrote: > Visuwesh writes: > >> I was kind of sloppy with that. If you move the mouse to another >> window, then it won't delete it. But you're right, it should also bail >> out if the end position wasn't the modeline so something like this >> maybe? > > Thanks; that works well for me, too, so I've now pushed your patch to > Emacs 29. How about doing this as well? (On hindsight, I should have included this in the other mail as well but oh well) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Make-mouse-2-in-mode-line-more-careful-as-well.patch >From 6dc4f29dbfcf6c40ef0808bf04987d918df98972 Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Sun, 26 Jun 2022 21:10:09 +0530 Subject: [PATCH] Make in mode line more careful as well * lisp/mouse.el (mouse-delete-other-windows): Only delete other windows if the user didn't move the cursor off the mode-line. (bug#56198) --- lisp/mouse.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lisp/mouse.el b/lisp/mouse.el index 82c8a14693..f7ada4f1ec 100644 --- a/lisp/mouse.el +++ b/lisp/mouse.el @@ -681,10 +681,13 @@ tear-off-window (switch-to-buffer buf) (delete-window window))) -(defun mouse-delete-other-windows () +(defun mouse-delete-other-windows (click) "Delete all windows except the one you click on." - (interactive "@") - (delete-other-windows)) + (interactive "e") + (when (and (eq (posn-area (event-end click)) 'mode-line) + (eq (posn-window (event-start click)) + (posn-window (event-end click)))) + (delete-other-windows (posn-window (event-start click))))) (defun mouse-split-window-vertically (click) "Select Emacs window mouse is on, then split it vertically in half. -- 2.35.1 --=-=-=--