From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master ed84f24a21: Make `signal-process' allow completing over signal names Date: Mon, 27 Jun 2022 08:56:01 +0200 Message-ID: <874k06a932.fsf@gnus.org> References: <165627647702.21409.11158107897633930882@vcs2.savannah.gnu.org> <20220626204757.57AB1C01685@vcs2.savannah.gnu.org> <87ilomewbp.fsf@yahoo.com> <878rpia9yd.fsf@gnus.org> <87a69yegza.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8228"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 27 08:57:31 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5igc-0001yA-WC for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jun 2022 08:57:31 +0200 Original-Received: from localhost ([::1]:38730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5igb-0002Mm-F1 for ged-emacs-devel@m.gmane-mx.org; Mon, 27 Jun 2022 02:57:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5ifL-0000a4-5Q for emacs-devel@gnu.org; Mon, 27 Jun 2022 02:56:12 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:51894) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5ifI-0008D0-3W for emacs-devel@gnu.org; Mon, 27 Jun 2022 02:56:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jfMpJxVpXyfZmxLarGr9Jd/wb+CBw7AI8LY/i4XZzOY=; b=OdOo5KGKzd3OGf4ld9wIX6I79K wYbmOVPtLZkGn5z+yU8fGdeTBm9SJfV/pbQ2wDnZmsSpQqfc84K46u1u8C9GezRWNTVRuC77Xc4+/ ROMiUtGIlOJYUF/RAnjx6Imjh65bvgjEgcQuV34ttBUV6Hgpil8apsXt/hhRlZLQ/4J8=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5ifC-0002pd-0O; Mon, 27 Jun 2022 08:56:04 +0200 In-Reply-To: <87a69yegza.fsf@yahoo.com> (Po Lu's message of "Mon, 27 Jun 2022 14:51:53 +0800") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291643 Archived-At: Po Lu writes: >> I just punt to gnulib. Presumably it gets all this right, and if not, >> it's a bug in gnulib. > > gnulib doesn't specify the largest signal number to be 255, right? Oh, you mean the loop ends one too early? Yes, that's true. Can't have new code without at least one off-by-one error; that's illegal. >> (I guess there are systems with on OS sig2str, too, but the same >> applies there.) > > They don't exist, AFAICT sig2str is a gnulib extension. That was my original assumption, but we apparently check the OS for sig2str via autoconf, I discovered yesterday. config.h: /* Define to 1 if you have the `sig2str' function. */ /* #undef HAVE_SIG2STR */ -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no