From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yoav Marco Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter integration on feature/tree-sitter Date: Tue, 28 Jun 2022 19:08:10 +0300 Message-ID: <874k04lp9x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27250"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Theodor Thornhill , Stefan Monnier , Daniel Colascione , emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 28 18:52:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o6ESB-0006vY-KU for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Jun 2022 18:52:43 +0200 Original-Received: from localhost ([::1]:45010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o6ESA-0003iJ-Oy for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Jun 2022 12:52:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o6EEH-0004SX-Ln for emacs-devel@gnu.org; Tue, 28 Jun 2022 12:38:23 -0400 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:34542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o6EEF-0001Zf-8Y; Tue, 28 Jun 2022 12:38:20 -0400 Original-Received: by mail-wr1-x42d.google.com with SMTP id r20so18542528wra.1; Tue, 28 Jun 2022 09:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version; bh=FBRhtDZxOzQSm8u+UsK/b4RcdkaHvPKx43DdHOFy+rs=; b=MazwmnF+KSB1eToTfA6pFn063DSpA7rSl7i4K9Go5mBg+g0G4b8erOnmakrpUAJPK2 tynDN3PPKiNIPyZBTD/sf5Khq1Bv58WDIi/JuMlB1O5YsVpFg65EQ97DyibUDWPfA0Se B0+dOmjm7v+Av6N3S1IrWHErnuDpyROMs5Ak+bds3CWYazls3EpkPLZtftfKQ1M03P3x jKm9egfOWiHqkjEw1w7Hin6kiJ1EbaQFxKJ3N1+kKKx9xs6L0z/1SxEURBxK5mqIh02/ QGg13o2JWsPOdly6BK741GvZanIe1AWCFeYl4Em171WL94fMbxXG7MXCZlnqbDfX/ZNa Fb2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=FBRhtDZxOzQSm8u+UsK/b4RcdkaHvPKx43DdHOFy+rs=; b=pHOtiCTeR0qzCVRQOdP6IGbSfn12GiEkn9UBeG0PkkR4Vt7nR96vDuji1UdLLrhJD8 a8cio8nnD7JVLAvMNBvyW2c1Odl3dsrmpoJi/3sc8UxfYXOsg9vKL2a/BsWE8DIzSyRu 4uwgQeBe1ZVhSDusEnovcEzibxEmMZNmguG5o7YiEO2JkUXpKKVert4zO1uLW1gH18T0 tUNO/1+wT1iwKNSKKexMiYkCY7UpwQr7WRuVR6cXw9FztnfyzivkODLwRLnTZmDTrOH5 sZCyjVYYaDXFe7LuTwNqvAaXxu+3hjkh0/XTlibtXKhKUe9Pa+pmZ8zze10wqg9r0DE8 DOMA== X-Gm-Message-State: AJIora+VkRcD8LwyrOvqwmigtP31A18ZYG4VJAZ6HL/nRpYNi3iYLZSM Dnp9u2shR6FNtNIzbl+kIBI= X-Google-Smtp-Source: AGRyM1vwyB8ORhy0WNwM6NzTwiL4N/ZdCMcK0/UZVTJIUI67Zntot4a0Ud0Us9QNhWP0qG0UX8xBUQ== X-Received: by 2002:a5d:61cd:0:b0:21b:9939:241 with SMTP id q13-20020a5d61cd000000b0021b99390241mr17754333wrv.581.1656434289901; Tue, 28 Jun 2022 09:38:09 -0700 (PDT) Original-Received: from localhost ([77.126.160.145]) by smtp.gmail.com with ESMTPSA id t8-20020adfdc08000000b0021350f7b22esm14222931wri.109.2022.06.28.09.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 09:38:09 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=yoavm448@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 28 Jun 2022 12:52:03 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291690 Archived-At: References: <5bada349-2f43-4325-b696-70918584cd3d@email.android.com> <83mtfsuluo.fsf@gnu.org> <87sfpjhm33.fsf@thornhill.no> <83a6brufe5.fsf@gnu.org> <87pmkmhp8i.fsf@thornhill.no> <83v8ueuc7i.fsf@gnu.org> <73DE25BA-5EEF-4497-8F98-8C5F20853A61@gmail.com> <87v8uewfuq.fsf@thornhill.no> <87mtfkbt9n.fsf@thornhill.no> <1179E1EC-90EF-4989-BE1D-115498F77F60@gmail.com> <87k0ajygry.fsf@thornhill.no> <6EF70929-5759-4F1A-B878-0C1660FB6831@gmail.com> <87leuy5z46.fsf@thornhill.no> <2E68780C-9923-411E-A5DF-B1A54E2EC38B@gmail.com> <83k09fq0am.fsf@gnu.org> <38C272F6-828C-4478-9D90-326AF14D0C94@gmail.com> <87h74j2lin.fsf@gmail.com> <4C257709-0E3E-46A7-8CEB-569001EEE31D@gmail.com> <87edzm2vk8.fsf@gmail.com> <1CEC92F7-3CB9-48DA-887C-43CD4C58E406@gmail.com> User-agent: mu4e 1.6.3; emacs 29.0.50 In-reply-to: <1CEC92F7-3CB9-48DA-887C-43CD4C58E406@gmail.com> https://github.com/meain/evil-textobj-tree-sitter for example pulls Yuan Fu writes: >>> Also I think it makes more sense if you just fork it rather than making a PR. >> >> Yeah, I don't really expect it to be merged. >> >> My reason for the PR is for it to be more of a talking point about >> collaboration between treesit and tree-sitter-langs. I used >> elisp-tree-sitter before trying the feature/tree-sitter branch, and I >> really like the richness of its highlighting (which comes from the >> highlights.scm files). > > Do you already have the highlighting working for treesit? I only checked a few, but yeah, and the syntax highlighting is very pretty. > If so, maybe you can packages it in a separate package and publish it, > it would be a nice demonstration of treesit features. I'm not comfortable with doing that, the query patterns update frequently upstream (though ubolonton has been busy lately) and all I'm doing is post-process them a little. I could try to make a self-updating repo or something with CI - highlights.scm changes from nvim's repo weeky. Is that worth it? I thought people could just as easily use my PR branch of tree-sitter-langs. That also takes care of fetching grammars. Sorry for the late response, Yoav