Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

[Stefan Monnier]

> +  (if denote-allow-multi-word-keywords
> +      (mapcar #'denote--sluggify keywords)
> +    (mapcar #'denote--sluggify-and-join keywords)))

Aka

    (mapcar (if denote-allow-multi-word-keywords
                #'denote--sluggify
              #'denote--sluggify-and-join)
            keywords))


-- Stefan

Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

[Protesilaos Stavrou]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Wed, 06 Jul 2022 00:30:22 -0400
>
>> +  (if denote-allow-multi-word-keywords
>> +      (mapcar #'denote--sluggify keywords)
>> +    (mapcar #'denote--sluggify-and-join keywords)))
>
> Aka
>
>     (mapcar (if denote-allow-multi-word-keywords
>                 #'denote--sluggify
>               #'denote--sluggify-and-join)
>             keywords))

Better.  Thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com

Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

[Philip Kaludercic]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +  (if denote-allow-multi-word-keywords
>> +      (mapcar #'denote--sluggify keywords)
>> +    (mapcar #'denote--sluggify-and-join keywords)))
>
> Aka
>
>     (mapcar (if denote-allow-multi-word-keywords
>                 #'denote--sluggify
>               #'denote--sluggify-and-join)
>             keywords))

Is there any substantial advantage to pulling the if into the mapcar?

>
> -- Stefan

Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

[Stefan Monnier]

>>     (mapcar (if denote-allow-multi-word-keywords
>>                 #'denote--sluggify
>>               #'denote--sluggify-and-join)
>>             keywords))
>
> Is there any substantial advantage to pulling the if into the mapcar?

It's good for karma because you get to reduce code duplication.


        Stefan

Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org,  Protesilaos Stavrou <info@protesilaos.com>
> Date: Thu, 07 Jul 2022 11:37:30 -0400
> 
> >>     (mapcar (if denote-allow-multi-word-keywords
> >>                 #'denote--sluggify
> >>               #'denote--sluggify-and-join)
> >>             keywords))
> >
> > Is there any substantial advantage to pulling the if into the mapcar?
> 
> It's good for karma because you get to reduce code duplication.

Not if you are being paid by LOC count.

Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

[Robert Pluim]

>>>>> On Thu, 07 Jul 2022 19:04:54 +0300, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Stefan Monnier <monnier@iro.umontreal.ca>
    >> Cc: emacs-devel@gnu.org,  Protesilaos Stavrou <info@protesilaos.com>
    >> Date: Thu, 07 Jul 2022 11:37:30 -0400
    >> 
    >> >>     (mapcar (if denote-allow-multi-word-keywords
    >> >>                 #'denote--sluggify
    >> >>               #'denote--sluggify-and-join)
    >> >>             keywords))
    >> >
    >> > Is there any substantial advantage to pulling the if into the mapcar?
    >> 
    >> It's good for karma because you get to reduce code duplication.

    Eli> Not if you are being paid by LOC count.

Iʼd much rather get paid by number of bugs fixed in my own code.

Robert
-- 

Re: [elpa] externals/denote e24c9ddc12 2/2: Merge pull request #36 from jeanphilippegg/allow-no-keywords

[Dmitry Gutov]

On 10.07.2022 16:25, Robert Pluim wrote:
>>>>>> On Thu, 07 Jul 2022 19:04:54 +0300, Eli Zaretskii<eliz@gnu.org>  said:
>      >> From: Stefan Monnier<monnier@iro.umontreal.ca>
>      >> Cc:emacs-devel@gnu.org,  Protesilaos Stavrou<info@protesilaos.com>
>      >> Date: Thu, 07 Jul 2022 11:37:30 -0400
>      >>
>      >> >>     (mapcar (if denote-allow-multi-word-keywords
>      >> >>                 #'denote--sluggify
>      >> >>               #'denote--sluggify-and-join)
>      >> >>             keywords))
>      >> >
>      >> > Is there any substantial advantage to pulling the if into the mapcar?
>      >>
>      >> It's good for karma because you get to reduce code duplication.
> 
>      Eli> Not if you are being paid by LOC count.
> 
> Iʼd much rather get paid by number of bugs fixed in my own code.

Sounds lucrative!