From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) Date: Thu, 01 Sep 2022 13:45:57 +0200 Message-ID: <874jxrz5ai.fsf@gnus.org> References: <166171593185.16640.41619657947456727@vcs2.savannah.gnu.org> <20220828194533.23A6BC00889@vcs2.savannah.gnu.org> <87r10znm0y.fsf@gnus.org> <83fshfvvyn.fsf@gnu.org> <999d1cb2-6b7f-8020-5202-e919278d895e@yandex.ru> <877d2pnqup.fsf@yahoo.com> <86zgfknc9a.fsf@mail.linkov.net> <87sflc91q7.fsf@gnus.org> <87wnao7l74.fsf@gnus.org> <0d5679a1-7635-53db-51c7-0ac0e35325d8@yandex.ru> <87mtbke7wf.fsf@gnus.org> <87ilm8e5am.fsf@gnus.org> <87k06nz9g8.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37430"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Juri Linkov , Po Lu , "Alfred M. Szmidt" , eliz@gnu.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 01 14:41:29 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTjVf-0009ar-T3 for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 14:41:27 +0200 Original-Received: from localhost ([::1]:38190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oTjAs-0006un-07 for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Sep 2022 08:19:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTie9-0008Ts-EX for emacs-devel@gnu.org; Thu, 01 Sep 2022 07:46:13 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oTie5-0000tk-4j; Thu, 01 Sep 2022 07:46:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JZMjX84i7wfKqagVVs2RQLkyOQG8IkFJnLDDAv0ReYc=; b=FL0RPmuf66m1DlX0VRheYcsb/X HB78oJlGKrVo7PBLXqCSN+j0N8Vd5IkDJXnNzlCD+uYFrly4AF0Cj6oxOD0d1donjPPHvT+KRCRZh DJ/u7gyZoWe7sVkNe8kLJYLL8JyAX5XdjrSQdE2DNriksdTh0wnl40W/97+ZnR0MD70Y=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTidy-0002ZB-E1; Thu, 01 Sep 2022 13:46:00 +0200 In-Reply-To: (Dmitry Gutov's message of "Thu, 1 Sep 2022 14:31:36 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEWeiGPHxKdbUDgy JBpNNCn///9VYhAfAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJAQsrDMr2CYgAAAG6SURBVDjLbZLh lewgCIXR2QKSeQ2wSAF7lAJykP5reqAxk9lZ/iSHzwsXFNJGHrDPAEjrj4pAOR66288m6VG+L2Ad Cvw79vqz1fR4fO/pBF/HF+MT9wQ7pqyvUgSAuH/2QGaEvwBxdUn6BOlpDuAv4E0gO9nSG9hjQMwI G8AvRZcuaoox/w0cpXmYmYbxiG2MCNxGuApn/vQB3COvqITbyCOkFDZ6gK50xCyBxrBusw3QyHSY gkxxgBhmi2Y145YGwJyemBdo4itzkN0c+2QOTCLdRJolz3D4jjtdihjFG5HF9w34JDYjJHoDnjE+ gS1gr1o0ZSeQMkCIIrwqyCzTp8TrESDl0qZC2s0cKWtvr+YX6ZWo3YH0+fUh1YHVcua9Uzjq6gYc SGWhvsqwUmlK0cNX9AKrlitBxNqq9gZinsq3dPXeUcrcud5BrHK4cgt3Rax8KmIzE9RucwlsU2EL xP3F1kjH5LL8SpTxznyuxK5B6Iqp8KNl1aKxdeQFZhM5zzPb+RgmkDZeDuac19VSPG1T9z0V4851 ABtX3uZr4+sxKMderkd1A/5uuvIniKvTcX+/Qfyy8A38B5oAuGg3lTBKAAAAJXRFWHRkYXRlOmNy ZWF0ZQAyMDIyLTA5LTAxVDExOjQzOjEyKzAwOjAwEqVC+wAAACV0RVh0ZGF0ZTptb2RpZnkAMjAy Mi0wOS0wMVQxMTo0MzoxMiswMDowMGP4+kcAAAAASUVORK5CYII= X-Now-Playing: Nina Simone's _Little Girl Blue_: "Good Bait" Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294479 Archived-At: Dmitry Gutov writes: > The step of "applying the saved patch" relies on our Lisp code being > correct and being able to handle any diff. It's not an outrageous > assumption, but an assumption nevertheless. Oh, I was assuming that we were assuming that we had "patch" installed for this to work. I don't think that's unreasonable for new functionality like this.