From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56791: [PATCH] Add window arg to splitting commands, new commands to split root window Date: Mon, 05 Sep 2022 20:56:06 +0200 Message-ID: <874jxl3b21.fsf@gnus.org> References: <87wnbzvveq.fsf@heagren.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26510"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56791@debbugs.gnu.org To: Hugo Heagren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 05 20:57:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVHHV-0006f5-RG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 20:57:13 +0200 Original-Received: from localhost ([::1]:38226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVHHU-0007wx-OV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Sep 2022 14:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVHHK-0007wa-Rm for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 14:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60151) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVHHK-0007Rm-9I for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 14:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVHHK-0007Pb-4F for bug-gnu-emacs@gnu.org; Mon, 05 Sep 2022 14:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Sep 2022 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56791 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56791-submit@debbugs.gnu.org id=B56791.166240417928405 (code B ref 56791); Mon, 05 Sep 2022 18:57:02 +0000 Original-Received: (at 56791) by debbugs.gnu.org; 5 Sep 2022 18:56:19 +0000 Original-Received: from localhost ([127.0.0.1]:48843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHGd-0007O5-69 for submit@debbugs.gnu.org; Mon, 05 Sep 2022 14:56:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVHGa-0007Nq-JP for 56791@debbugs.gnu.org; Mon, 05 Sep 2022 14:56:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lMxX4REZ1ID2YotpA6Y1XrzDuMBipNpzRlJVACWyq9U=; b=lp5/cADWuYVmwD2NwwG/ujHvWX sssWBxtvWYni8htGGA8nab+cUPnH23aZS6yeZTAa10T3gmfQM2/+BiuJ3nknsOsJPzbIgc46OX42Y R9MHF1xzBy0vt52hO8EpcnOVogbAvKbUajtbuTCGaZqhjJrg9cmZq7RyykyEpX4T3yqg=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVHGR-0004OX-As; Mon, 05 Sep 2022 20:56:09 +0200 In-Reply-To: <87wnbzvveq.fsf@heagren.com> (Hugo Heagren's message of "Wed, 27 Jul 2022 08:58:53 +0100") X-Now-Playing: The Rolling Stones's _Black and Blue_: "Memory Motel" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241583 Archived-At: Hugo Heagren writes: > So, I have implemented: > - a new optional argument on `split-window-right' and > `split-window-below' specifying /which/ window is to be split. This > defaults to the selected window. It also has no effect on the > interactive use of these functions, since the prefix argument is > still used for the SIZE arg. > - new commands (implemented using this arg) which split the root window. > - bound these commands to `C-x 7' and `C-x 9'. This seemed > appropriate, considering that these numbers were free, but the other > window-splitting commands are bound to numbers in that map. > - (hopefully?) appropriate documentation changes > > Patches are attached. I don't know if Emacs has conventions for how > large commits should be---mine are very atomic. Hope that works, but I > could squash them down further and combine the messages if necessary. Thanks; looks good to me. I had some merging issues (since the affected files have changed a bit since this patch series was proposed), so it was easier for me to squash them before pushing to Emacs 29.