From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Progress on merging Eglot? Date: Thu, 08 Sep 2022 15:26:30 +0100 Message-ID: <874jxix7qh.fsf@gmail.com> References: <87tu5ihwp0.fsf@gmail.com> <87tu5i55ts.fsf@posteo.net> <878rmux8ux.fsf@gmail.com> <87pmg654xi.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40215"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Payas Relekar , emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 08 16:27:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWIVP-000AJK-5d for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 16:27:47 +0200 Original-Received: from localhost ([::1]:34796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWIVO-0002vq-7x for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 10:27:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWIT5-00089P-T2 for emacs-devel@gnu.org; Thu, 08 Sep 2022 10:25:25 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:46939) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWIT3-0005Cj-RM for emacs-devel@gnu.org; Thu, 08 Sep 2022 10:25:23 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id e20so26347338wri.13 for ; Thu, 08 Sep 2022 07:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=qF2/9gvVgdmdXmIvtQC3HIyyxSUMmskrhHqSM4sK668=; b=D7UbrQC+VSifNQSw70mrdTkiFNRFbSIBcZTlRELdA+pEPu9U7LNpSSejXS/i/qDb5+ e6R/1OOwZn8LcGZSSYWmnzFpgYi5MP8kERlekLz9BStdgV/qN83GBrDgW46r9eQsYuPI XvYNufSo/wfrgmh9B74chfsDpTdAJXauGgugRm2bIBgxqVJSA2CuyHgi9qoKkzia3CG9 GycG3cWK/3+JfOVHcdJFJ7+WRvk3rRR5DluVCnKm9JVjvbRf1Szf0cOid490MfGmkRUN FrUPgf3N1gyEiUVcXGXsfW4Hxl3AAEzKRebPu+0AhpirBcg9HHVKgxFwXVxAGsIo/xoT zK/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=qF2/9gvVgdmdXmIvtQC3HIyyxSUMmskrhHqSM4sK668=; b=DJX8hUqiW8DxsfRJZdqXw2lL7VoX87V3K7VxnvsU1fTUOItBY1VJFj0iHrvJG0DJmZ V0Guk94kDLL+C6Zt5J0SKQ3xLmxayTqE45jpbUI7A0NTEgD6mBH4qoFSznuOHYcqviw/ h3REj+WGb1aPvZoFSc+aNWnFrG9m//7DJ8k5ZBXengZr4VGcxHAHEIWHARVUK4cye3UM Q7W0CEaC06Wr90Zegn4bQr/kWbDb2HUnyG+lhmRtKaYdfLIv0rNGbmGKr731RVZtr6Ec rCMCN9sjBmC4giMxukYN/mW2xuE/FrPVc7zIpVT8oD36XfgUhPdzb4SYQL06mDuRxbuK vy/w== X-Gm-Message-State: ACgBeo2mnfcJcj+qOwraFi/f+IX76MEiGkeZNYVniX9Lp5iXUCEDj1mQ +Wmj3Y22YOx3BZ3Dd3GM0dvramC+6s4= X-Google-Smtp-Source: AA6agR6dl+VDecTR6aU01zdHZ0tX9cUl9nq3ymLbO8nuXOnBwQiCOhH8dSKXEeGswirKtAYqbZbo8A== X-Received: by 2002:a5d:648c:0:b0:22a:2c04:97a5 with SMTP id o12-20020a5d648c000000b0022a2c0497a5mr2790577wri.326.1662647119965; Thu, 08 Sep 2022 07:25:19 -0700 (PDT) Original-Received: from krug (87-196-80-45.net.novis.pt. [87.196.80.45]) by smtp.gmail.com with ESMTPSA id z18-20020a5d6552000000b00228ddd9e1d5sm8692102wrv.98.2022.09.08.07.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 07:25:19 -0700 (PDT) In-Reply-To: <87pmg654xi.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 08 Sep 2022 14:14:33 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294969 Archived-At: Philip Kaludercic writes: > Jo=C3=A3o T=C3=A1vora writes: > >> Philip Kaludercic writes: >> >>> In either case, the main problem is that the (908) commits in the >>> repository don't appear to be in the conventional changelog format, >>> and I don't think there is an easy way to automatically fix that. >> >> Can you point to examples? And why do you say it's a "main problem"?=20 > > I should have been more concrete, a lot of messages appear to reference > issues in the elgot issue tracker, that wouldn't make much sense in > emacs.git. Ah, yes. Well, in that case, I wouldn't mind rewriting the the whole history -- once -- and adding a search and replace. So item 2 can become: ... =20=20=20=20 2. Preserve the full Git history of the eglot.el file after it has been merged. =20=20=20=20 Before merging, it's OK to rewrite commit messages with mechanical replacements as:=20 =20=20=20=20 #[0-9]+ -> https://github.com/joaotavora/eglot/issues/\1 =20=20=20=20 ... In my view, this should catch _most_ of the issue references, but I'm personally OK with missing a few. Many messages start with=20 'Fix #123: Bar kittens' 'Close #123: Blither Foo They can be adapted to be just "Bar kittens" and "Blither foo" with the aforementioned link in some other line of the commit message. Scripts for doing this are appreciated. Jo=C3=A3o