From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Payas Relekar Newsgroups: gmane.emacs.devel Subject: Re: Progress on merging Eglot? Date: Thu, 08 Sep 2022 22:39:57 +0530 Message-ID: <874jxhaizf.fsf@gmail.com> References: <8735d1ajxb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31468"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.9; emacs 29.0.50 Cc: emacs-devel@gnu.org To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 08 19:16:48 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWL8y-00082x-K0 for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 19:16:48 +0200 Original-Received: from localhost ([::1]:44288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWL8x-0003Xt-9Z for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Sep 2022 13:16:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34528) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWL4W-0000fg-DD for emacs-devel@gnu.org; Thu, 08 Sep 2022 13:12:12 -0400 Original-Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:46818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWL4U-0007eR-QG for emacs-devel@gnu.org; Thu, 08 Sep 2022 13:12:12 -0400 Original-Received: by mail-pj1-x1032.google.com with SMTP id j6-20020a17090a694600b00200bba67dadso3113871pjm.5 for ; Thu, 08 Sep 2022 10:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:from:to:cc:subject:date; bh=ZwPeByu8zHvzhhjqJcc5k4yCtGt2o/ZBG6SzX5vdQJA=; b=le066l1KiIu5c+mUn2xlfNOinST2qmhZLljamxJz0yVn3y7WixsyzVUHIPXDsiKlJi TUvAjA2jzIqdMgWgpJXKH6e/obtvkV37FKKRgd3WgN+P3SzXx6gPB85JKPlrJXFPkpxE UEYlasgQVWrTbAonmI7rkl+/kKCuX94Ls5I1169Is+UyzhxwWOVWmeUt1L+7QtlOLHDF m64e7Tn5JZz/frae4u+rmqL/R2pSpxqdI+Ig5B0vtTtFhqFxkmvvLHkhu0Y92/tD7Vmt TwlRNgHV5X9y1RDmojH12Fa4gjuwviDKOtlajuFwTfs5bmQuOSa5G0+HB34lZ5QgN5A8 rpKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:in-reply-to:date :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date; bh=ZwPeByu8zHvzhhjqJcc5k4yCtGt2o/ZBG6SzX5vdQJA=; b=sMWWMMc7jggOIbzzKRKMghEkkZvI3IeP8HbE/GNoTPyHA8US5igVyA93YZxDXeKK83 pMWPz4hWBBMZcZDE6yJYdypnJj5FCLpIlFnblAcb2ccpAy+sOWP0jqwaIG8BtUcO9NA+ C5Y5GG1/ySQi5JVJpS/9T/xnce7StaEeU/PpFxmcJ44eJ/FVdMdg8J68rRHpqAsAmhB7 ByM1ujUhNZtlnWIGyFxjFxVyFGGZlLJNcDtonzaCA4L+4vrUkOa5b+cG4MmQeE5vJpZh 7CplAEBmq33OuNuZkWcZM5eeUlSrrB9H1V8QEe1MbmW4N2VdVWOnN1ZBO3RkPtgQsiaz NTzw== X-Gm-Message-State: ACgBeo1G60vmSbJnxx5Nj0F/bApXvk0snRMfOawmP2yvVh7M7QE9q8qq l/IWWQE2gF0AohO/toBGJik= X-Google-Smtp-Source: AA6agR7/zXnD62I30XWhwVtWLBwa9o47dD/WAvKgwkpJu+GVWnF22EK2/ZLxqZsmN/yLpfsIrknyyQ== X-Received: by 2002:a17:90a:203:b0:200:8df6:84c with SMTP id c3-20020a17090a020300b002008df6084cmr5067006pjc.24.1662657129321; Thu, 08 Sep 2022 10:12:09 -0700 (PDT) Original-Received: from localhost ([150.107.26.19]) by smtp.gmail.com with ESMTPSA id 64-20020a621443000000b0053e669cc845sm4663926pfu.190.2022.09.08.10.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 10:12:08 -0700 (PDT) In-reply-to: Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=relekarpayas@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 08 Sep 2022 13:14:59 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294996 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Thu, Sep 8, 2022 at 6:03 PM Payas Relekar wro= te: > > >> One thing I'm thinking is, is there any possibility of PRs being >> referred in commit messages? If so, the */issues/num won't work, and >> */pulls/num will have to be used. That means probably involving curl. >> > > But I think GitHub automatically redirects "issues" -> "pulls" That's convenient :) > So if you want to be super clean and heroic, yes do the curl scraping. > Could be useful that day GitHub is no more and we need the wayback > machine to read the discussion. I think I'll stay clear of heroics for v0, perhaps stretch goal later.. > But don't let that block you either. > > >> This looks fun :) > > > Thanks a lot for your help! Okay, some dumb questions to boot. I see eglot repo has below relevant file= s: 1. .dir-locals.el 2. Makefile 3. NEWS.md 4. eglot-tests.el 5. eglot.el >From your description above, I see we only care about #4 and #5, is that correct? Any of the files omitted here (gifs and .gitignore etc) relevant? I took a quick skim and there are some commits with `* Makefile', can these be safely ignored? If we are skipping NEWS.md and .dir-locals.el files, can we skip commits that are limited to them as well? Thanks, Payas --