From: Matt Armstrong <matt@rfc20.org>
To: emacs-devel@gnu.org
Subject: Emacs' C: static inline considered useless nowadays?
Date: Sun, 16 Oct 2022 15:08:51 -0700 [thread overview]
Message-ID: <874jw37764.fsf@rfc20.org> (raw)
For Emacs, I would think:
a) In header files, use Emacs' INLINE and NO_INLINE macros.
b) In .c files, use static, EXTERN_INLINE, but never 'inline' since it
does nothing.
I'm seeking confirmation (or refutation) of (a) and (b). I'm not asking
generally, but for Emacs' C code.
Specifically, ignoring the uselesness of the function itself, assuming
the code is in a .c file, is the use of the "inline" keyword redundant
with static, below?
static inline int
add_two_int (int a, int b)
{
return a + b
}
I've spent the last few decades coding with an undersanding that
"inline" is about linkage and allows one to place code in header files
so that it *may* be inlined, but that compilers long ago stopped using
it as a meaningful inlining hint. But this is mostly colored by how gcc
and clang behave with C++, and not much else.
--
matt (sent from an Emacs running the feature/noverlay branch)
next reply other threads:[~2022-10-16 22:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 22:08 Matt Armstrong [this message]
2022-10-17 0:43 ` Emacs' C: static inline considered useless nowadays? Stefan Monnier
2022-10-17 3:13 ` Matt Armstrong
2022-10-17 3:33 ` Óscar Fuentes
2022-10-17 6:10 ` Eli Zaretskii
2022-10-17 19:08 ` Matt Armstrong
2022-10-17 19:12 ` Eli Zaretskii
2022-10-17 20:33 ` Matt Armstrong
2022-10-18 2:30 ` Eli Zaretskii
2022-10-18 13:32 ` Stefan Monnier
2022-10-18 15:09 ` Eli Zaretskii
2022-10-18 17:01 ` tomas
2022-10-18 19:22 ` Stefan Monnier
2022-10-18 19:31 ` Eli Zaretskii
2022-10-18 11:58 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jw37764.fsf@rfc20.org \
--to=matt@rfc20.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.