From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: eglot.el =?utf-8?Q?defcustom=CA=BCs?= Date: Tue, 25 Oct 2022 14:35:53 +0200 Message-ID: <874jvsozbq.fsf@gmail.com> References: <87czagp001.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40066"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel , Stefan Monnier To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 25 14:38:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onJBx-000AEC-KO for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Oct 2022 14:38:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onJAe-0004l4-2N; Tue, 25 Oct 2022 08:36:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onJA1-0002is-0B for emacs-devel@gnu.org; Tue, 25 Oct 2022 08:36:09 -0400 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onJ9w-0001JX-RL for emacs-devel@gnu.org; Tue, 25 Oct 2022 08:35:58 -0400 Original-Received: by mail-wr1-x42c.google.com with SMTP id g12so7786973wrs.10 for ; Tue, 25 Oct 2022 05:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=QFVgFL/0zDJuXBE0/zPG4huwK37Xz5gBJrHAZiR5HPA=; b=ElAqUV8Kh3XHiI3HWUIOEQTF7y3rxj/XHuGvNeSOJDJ9j0ILHUfx9PVAWtfN2RJTBm ycNE7iyhjnxNvGH0/oVxkMV8xMx4zT06fqtUNLEjI/5sE9epd8eQxfl90U39pE7k0g0l bHxRjpaKcjfSJG6jKrHmzvgo5BiI62VGe6CPdgwvKp7dK0q8ljbWWvsCblE/ZonEVvJK 1ifMV+YMYJWE2r+N3/RKmbqcy0V2EhPY71iPsZtfvHpSS8a3oYY2/4Y43Kw9xE9dFveD BEYKbxW/etkgdZ8j7TJbKZY5yVggFIQH2nFgnZWWyP3lbjUHAuk0VzwHrz5vDpSGC/Jp G01g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QFVgFL/0zDJuXBE0/zPG4huwK37Xz5gBJrHAZiR5HPA=; b=axlPGRoqNUd60q4C277Yln4UTBUwqkhox+daQ+nuW3MWr1oU+wD8iq7bOz6cKxxY4Q lwcT+Fk1Iyk+WExZYGrADcLcZXPc/U43nS7gQ89WpwS5q9s/Ic4JZm1SIDCbhB/Xisza ytoc+IexSlM170rzjj3bXXrCufKVyCkzhot9Zq4kD2kcJMJJkXNCqt57UTo6COPjTZM9 VpyCo5Z4nTP0+K8W7xz3ntq6DeXIR5CJommZ4oNaFx/ENx85pquPSc0ZyGqInVVu2Aif Z60GuB4UxeiV9XvQ6du1gQ+XnunIvjZEQ30AgGNT0B+A+EB3C0L2e7w2ITcIzFHl9Ipx 17yw== X-Gm-Message-State: ACrzQf2GRGbm815+t8+tulvoUiUZQ2Acbe5Si2e+Fcig/0xmgI+z5A+A BDvQjX4W/RhHC7bi4kncC6M= X-Google-Smtp-Source: AMsMyM77dBrb2PNyBnD7ExzFCuGwY727j9Q+qKIDalrCF2UAeZ1bh0f9SzwU5VJceYJFtM3gHznWEw== X-Received: by 2002:a05:600c:4e05:b0:3c6:f0bb:3175 with SMTP id b5-20020a05600c4e0500b003c6f0bb3175mr34812965wmq.135.1666701354415; Tue, 25 Oct 2022 05:35:54 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v190-20020a1cacc7000000b003b4868eb6bbsm3223060wme.23.2022.10.25.05.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 05:35:53 -0700 (PDT) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Tue, 25 Oct 2022 13:26:01 +0100") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298459 Archived-At: >>>>> On Tue, 25 Oct 2022 13:26:01 +0100, Jo=C3=A3o T=C3=A1vora said: >> all the defcustom=CA=BCs in eglot.el lack a :version tag. Is that >> intentional? Jo=C3=A3o> No really, probably oversight and the fact that Eglot being a Jo=C3=A3o> GNU ELPA package (presumably easy to upgrade) doesn't usuall= y mean Jo=C3=A3o> such version tags are so important. They=CA=BCre not important until we start changing defaults, and then they offer an easy way for people to identify from when they can start shouting at us :-) Jo=C3=A3o> That and the fact that Eglot doesn't really have that many d= efcustoms. Jo=C3=A3o> So, if you want to add :version tags, go ahead. Note that E= glot Jo=C3=A3o> does GNU ELPA double-duty as a :core package, so not sure wh= at Jo=C3=A3o> you should put there, but others are perhaps better informed= than Jo=C3=A3o> me. I=CA=BCm not sure what the interaction is between :version in defcustom=CA= =BCs and eglot being a :core package, which is why I asked. Maybe Stefan can enlighten us? Robert --=20