From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#58893: 29.0.50; Feedback on Eglot manual Date: Sun, 30 Oct 2022 10:42:45 +0100 Message-ID: <874jvlk5pm.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18524"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) To: 58893@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 10:43:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op4qZ-0004eE-CD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 10:43:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op4qO-0001Sz-U0; Sun, 30 Oct 2022 05:43:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op4qM-0001So-KZ for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 05:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op4qM-0002zA-Cy for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 05:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1op4qM-0007BG-7n for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 05:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 09:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58893 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166712297227583 (code B ref -1); Sun, 30 Oct 2022 09:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Oct 2022 09:42:52 +0000 Original-Received: from localhost ([127.0.0.1]:37352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op4qB-0007Ap-Tv for submit@debbugs.gnu.org; Sun, 30 Oct 2022 05:42:52 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:35334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op4qA-0007Ai-J5 for submit@debbugs.gnu.org; Sun, 30 Oct 2022 05:42:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op4qA-0001SR-Cm for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 05:42:50 -0400 Original-Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op4q8-0002vl-Jv for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 05:42:50 -0400 Original-Received: by mail-ej1-x635.google.com with SMTP id bj12so22663034ejb.13 for ; Sun, 30 Oct 2022 02:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:face:user-agent:message-id:date:subject:to:from:from :to:cc:subject:date:message-id:reply-to; bh=VhGt9HxEuAjcdCc2FXl0Q9d56aNpDoxMx+AwGwOG6iU=; b=HXtr5t2GnPajTJDDWIG73TmO3EPhXb48xvnRdJCF1RGDJtVykHlbeHgk1uh8vRyuss zC9q/Z/CgrT7Uec7ORPqd0UwP9OkxUqDhC5Aby8NIu5EjAS75oTwctWW6MaD3jswni0a BTl0lZp/xh0fuXwMQv5sm9bA1SA9iboRCefeBrmkyOS06PuT8909Qk2j7Rpp7VW4m0FR Wvea7U+u1TJe7aZYtUKrsb3CSXRZhAj80QzYoEj+aI/aj0nqpZFNUd4Q4XexuMCs13SY WXkdiGXhjWDgjPLxmD2F5O3TUPuHpJZb7EH9rmRubn3YNDn60yTvyFP4Hp9wOtf+u9fd pyiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:face:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VhGt9HxEuAjcdCc2FXl0Q9d56aNpDoxMx+AwGwOG6iU=; b=Wkd1Pw7T0hunzSPr4S3/oPmbr19MMF41id1Q1NrwKtrxQFmxvWdelnqfluD8Z7YEkn zDu6Q62JHyG54wDiniQpPJEcg0qq19cATHTYDJKDrY/zSmz++k9/U28cKVFrrTvnuRkJ rXahJKUBd2yY+BhRbx0XNsZh+Y0rA5d4owQhlLp2TUkHm4NGsmirX0PBTUkILL62b6/M E8EEfenPP8yZAAIt9LnbQVDkMaQHsCGRR/1MhUZAg+SUIf/sRwBjNfj8rXVEHETSC/LW TNB6lLdHll7iTT9AIhWxxxzCtJ2PimRqsySWBPGCtrOQJlq9Glkhs3kHi7QMjJdaJN1x ntbQ== X-Gm-Message-State: ACrzQf0GWL/lTC99p/Ok7QiDdipb0mojb21wHuhcLCB6oOowfwTlSjjV EPTCftpnyhg8VUSfQwlgE4uE4mh0peM= X-Google-Smtp-Source: AMsMyM4Xt/Hwu22Pq5nqe7SbQmJDt4mN8u0A93bkiSdtu0aI2zqnxuh/xsDm7U9Z0bYNeGo34qSzjg== X-Received: by 2002:a17:906:eecb:b0:73c:5bcb:8eb3 with SMTP id wu11-20020a170906eecb00b0073c5bcb8eb3mr7567602ejb.284.1667122966823; Sun, 30 Oct 2022 02:42:46 -0700 (PDT) Original-Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id t31-20020a056402241f00b00459cd13fd34sm1829148eda.85.2022.10.30.02.42.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Oct 2022 02:42:46 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=felician.nemeth@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246604 Archived-At: All in all, I think the new eglot.texi is really informative. Nevertheless, having reread Eglot's github page, I've found some information that's missing from the manual. Maybe it's worth including some of them to the manual. * Missing commands I'm not sure whether it is necessary to document all the commands defined by Eglot, but the manual mentions xref-find-definitions, so probably it should call the reader's attention to eglot-find-declaration, eglot-find-implementation, eglot-find-typeDefinition, and xref-find-references as well. * WorkspaceFolders The LSP protocol supports multiple workspace folders. Eglot relies on project-external-roots to get the additional folders (besides project-root). This is not mentioned in the manual. However, (info "(emacs)Projects") doesn't talk about how the user should configure these external roots. Maybe a simple solution is to rework the relevant part from NEWS.md into the eglot.texi. NEWS.md has this: Eglot now advertises project-root and project-external-roots as workspace-folders. (Configuring tags-table-list sets the external roots of a simple git project.) * Snippet completion Yasnippet should be enabled in the current buffer before Eglot connects to the LSP server. Thanks.