From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#58985: 29.0.50; Have auth-source-pass behave more like other back ends Date: Mon, 07 Nov 2022 11:33:58 +0100 Message-ID: <874jvbnje1.fsf__5599.24890273891$1667817349$gmane$org@gmx.de> References: <87wn8cb0ym.fsf@neverwas.me> <874jvdardn.fsf__3771.40490324877$1667692584$gmane$org@neverwas.me> <87pme09vis.fsf@gmx.de> <87a653z7dl.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22875"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Damien Cassou , emacs-erc@gnu.org, 58985@debbugs.gnu.org To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 07 11:35:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1orzTe-0005cb-Ma for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Nov 2022 11:35:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1orzTP-0006kp-Ej; Mon, 07 Nov 2022 05:35:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orzT4-0006ik-GT for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 05:35:22 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1orzT4-0001oJ-7F for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 05:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1orzT3-0001he-Rc for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2022 05:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Nov 2022 10:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58985-submit@debbugs.gnu.org id=B58985.16678172566489 (code B ref 58985); Mon, 07 Nov 2022 10:35:01 +0000 Original-Received: (at 58985) by debbugs.gnu.org; 7 Nov 2022 10:34:16 +0000 Original-Received: from localhost ([127.0.0.1]:33418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orzSH-0001gY-0X for submit@debbugs.gnu.org; Mon, 07 Nov 2022 05:34:16 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:51751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orzSC-0001gH-6B for 58985@debbugs.gnu.org; Mon, 07 Nov 2022 05:34:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1667817239; bh=ZpKSJQxWZrhbFsKdLrRfKoawWjrPrRx0IZgLrKs3gJM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=YbfoxcOc3CEM/EFf9Ilbj/OleXMZl6CbgAUl3EjXzwDrooHrMG2P5suBEN2wM/bog ikyXj66sILnpg9dnZrpu2axcg+yXytfo2W0fJ1u7ekquKFYgcDOQJGdy8ntwWdu+HR zHSIFoCe6XM+bB7w940EolMRkupSMjjmTHLDnZGZjKt2SPTwk8p5MW/yl7kWUqJJn8 y/u6h4j9f06zd0PmKsXOikLH+MSPz6e0xR74W7DMyZDsQlYJtG0tIJGQAYfjOkUOwT x6Id14xXYRvN5mOpCdkOstOhnWeVSNwwx7d9XMFt3WCLjqxnGIRrdyOQ0Bl5M2GZaH Sq/KEoYTOdtxw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([212.91.242.159]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MZCb5-1oWDLS2iJt-00V9QB; Mon, 07 Nov 2022 11:33:59 +0100 In-Reply-To: <87a653z7dl.fsf@neverwas.me> (J. P.'s message of "Sun, 06 Nov 2022 21:00:22 -0800") X-Provags-ID: V03:K1:KDLQrpE8De9PiYwImJ73cg6rdztNNbQ4z5oddv5JSC7XJsa49O0 WfnzSKIPQpcmjxwSfuNmC9AQpIVVM12xHd+ySs7Grt4c5f1XDGJZLu2x68gCB8Xod0P3CHd x/pJkESwBkc6xd0Jy1K/ofhFlMBCh1abM3Vc7V6JiZTE47kmqHE1jlb+weDtZiqUW39G/+o lmI8dklI970ouvuaeODxw== UI-OutboundReport: notjunk:1;M01:P0:4YWEBE7rTMU=;JiRvgatw//12Om15Sr0KKj7UpxG XuhfkbFqS5Yj8i4/qYpCDRACL3j2sZqVDBybyNB8VFuTwIRig922DZ0ETIJam7h+8zZX/PahO dZcFGJg+a9N7cQiX1ifax7IyzXiolIoNSLMDegqO73u9g6jLM+r56DLEGTOxpuLzftFWWFPSX rJoJ94stBAq2tyN5XhPD0WyNJu55z79XMLL4SvnTr0VyDsTvfgLj8v2EcsgoZ0Vc2yfscXKC8 nsc9CAuXBAPCSmOG/kliWSQDCjc6ikuokW6vlPBQK7p+sWmcq7wd44yRIV0+KX6SWssnXGPnJ I87EHDQRl1j0vGA2hzYy1pHRgLmeK53emow4/kD7dgAagDud5an/F1DuXEHkWVxSH3zSXhYml iVS+CyxTBJ17gS2sGOgFsUD3utrWcnI30lNB3QjZVgWxRmiUl0IVSFssYJtQbDOHZjSgk0NXQ 22zJ9cvN1mSWF074nNlfJ1A/GF8/bBz/tvOVKtvR32kg2zBaYa4dRqhPNnNG1uj8qZjPXeAez aBLPBJsMeoBBudBlFizndX6b4/P5jraovXuG6p/k8/w+yATURaVgXtNRBp87HBM7/c2eYxxDd gIQafhIHrv9Ka6eh4QuaglkHVbXV4QlDcjVirJr3Y5QUj7ASR011SXe+QVLUhztVEFb7QGlLT 8AkIj3Hjwun8jU8eGfdU8uDPBve/ZeuTUcrW4kpxG9VRAK842OdaXzZnyALg65xQG1CijZUSr /ApPnTdO3Ljf2gCJBm849niQOkQrsucmBj79ldsFTY577n615Iz6OA5GDDuZIjjU51jMZw1B X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247271 Archived-At: "J.P." writes: > Hi Michael, Hi, >> +(defcustom auth-source-pass-standard-search nil >> + "Whether to use more standardized search behavior. >> +When nil, the password-store backend works like it always has and >> +considers at most one `:user' search parameter and returns at >> +most one result. With t, it tries to more faithfully mimic other >> +auth-source backends." >> + :version "29.1" >> + :type 'boolean) >> >> - The name of this user option as well as its docstring are focussed on >> the current behavior. People won't know what "mimic other auth-source >> backends" would mean. Please describe the effect w/o that comparison, >> and pls give it a name based on its effect, and not "...-standard-search". > > I've changed the name to `auth-source-pass-extra-query-keywords' and > updated the description to something hopefully more adequate. > >> - I'm missing the documentation in doc/misc/auth.texi and etc/NEWS. > > Added. Thanks. > BTW, I was initially thinking it'd be better to wait for a more > comprehensive and maintainable solution, like something based around a > larger set of common functions to be shared among the various back ends > (hence the [POC] qualifier on my patches). However, I suppose such a > thing could be done later, once the desired behavior is all dialed in > (perhaps alongside addressing support for full CRUD operations, which > are still missing, AFIAK). Anyway, I really don't know enough about pass > or auth-source to commit to such an endeavor. But I've reached out to > some folks who may be able to lend a hand. Such a change would be desirable. However, Ted, the author of auth-source.el, isn't active these days. Personally I feel responsible for the secrets backend, and I try bug fixing in the other auth-source parts. That's all. According to admin/MAINTAINERS, nobody else feels responsible for auth-source. So I doubt that such a change will happen soon. >From my pov you could push the changes. But as you said the other message, you'll wait for feeback fron users. That's OK, but pls take into account that later this month an emacs-29 branch will be cut off. Feature changes shall be pushed until then. > Thanks, > J.P. Best regards, Michael.