From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server Date: Sat, 12 Nov 2022 09:04:02 +0000 Message-ID: <874jv47ddp.fsf@gmail.com> References: <8cf8ba5d-c604-b2dc-274a-7597b19fb73f@dfreeman.email> <87ilk5xq01.fsf@gmail.com> <87r0yrwfn3.fsf@gmail.com> <37716e41-5955-99f6-5204-e760a716fbf6@yandex.ru> <9bb290c8-f000-31d8-265d-b5441c33eb38@dfreeman.email> <4d50b820-7053-75eb-5b11-d3d36a02b013@dfreeman.email> <87v8nxsrq6.fsf@gmail.com> <87cza40xgs.fsf@dfreeman.email> <83edubrvf0.fsf@gnu.org> <87cz9v9irh.fsf@gmail.com> <83o7terf9a.fsf@gnu.org> <87k042tqze.fsf@dfreeman.email> <83o7tdq4f2.fsf@gnu.org> <87sfip7rkt.fsf@gmail.com> <83leohpuml.fsf@gnu.org> <87k0417fnp.fsf@gmail.com> <83edu9pn1b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18007"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58790@debbugs.gnu.org, felician.nemeth@gmail.com, stefankangas@gmail.com, danny@dfreeman.email, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 12 10:03:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otmQ2-0004Sj-2z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Nov 2022 10:03:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otmPs-0001iJ-JG; Sat, 12 Nov 2022 04:03:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otmPm-0001gj-GI for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 04:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otmPm-0007WJ-8A for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 04:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otmPl-0002w4-TD for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2022 04:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Nov 2022 09:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58790 X-GNU-PR-Package: emacs Original-Received: via spool by 58790-submit@debbugs.gnu.org id=B58790.166824377911275 (code B ref 58790); Sat, 12 Nov 2022 09:03:01 +0000 Original-Received: (at 58790) by debbugs.gnu.org; 12 Nov 2022 09:02:59 +0000 Original-Received: from localhost ([127.0.0.1]:47296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otmPi-0002vn-Jj for submit@debbugs.gnu.org; Sat, 12 Nov 2022 04:02:58 -0500 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:37524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otmPg-0002va-PJ for 58790@debbugs.gnu.org; Sat, 12 Nov 2022 04:02:57 -0500 Original-Received: by mail-wr1-f49.google.com with SMTP id bs21so9260231wrb.4 for <58790@debbugs.gnu.org>; Sat, 12 Nov 2022 01:02:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jpg4R343JiQr82yvCCw7aAmEQtzpCiB8raAR05MJQ4Y=; b=A59sVbXLZaqUHPToidyVNCkMY7LWtErko+j6tCnuAOI/du2IvdqvwhsNOkYP5thQ7L JofAvvfSrba5p93HG7km0VwYVLO1CcSpANUnW0k/esPXMKUB9zCofywNCdeXXXUZrnd9 rd4/yRCvaBVzFp/+UIH1miUxPy4RHlOz2Kl5Ubq8QJ6VagzNx+ymOwMDAwwO5RgNKT83 BK7o6+bErVKuZjVJOJoo2LOmr6unu9MkOcsAP5p5tI5PUGWOzkIl0vIeRybhDnRRJ648 YOnHBAaT24pT4zE2OB6iraQqNclBvapbIT3WByL741+9LkRglBuVRFD+O1IIQ2kodQOT 5ZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Jpg4R343JiQr82yvCCw7aAmEQtzpCiB8raAR05MJQ4Y=; b=C+ZRbMsn13+nnWvEF6CN4QBXZBLjIPmgP5+mPJ64grM/UXIJPJyTU44HurRNDObkII QbqC9vpauxvgSrQkycjZiAZ/0M0nGFBnsfk8jTjUvXPlbze//T17SIR/j+Y30Og2z3Ct WVbiVaXwS6Sfvk9mH/5F23rLGcMaNFk4d4ZkA1b6uhyFSChwDklaldyEjlrWSkRLiZfH //e0KzXLOXoCW/oOEsjTijMitethSOvtdCbbNTvmZxWtfwFhBam4NbtMoUMaQJEuPNTZ RidCN69ROSwL4wRm9My5eKcxtfyjLWZV6fsQl1MEbm9OXdtWNxR9FAJi318f1E9HFfIE 6nMw== X-Gm-Message-State: ANoB5pk/8TUs8Q3NF64j5l+vRo+d+KggKY8qiprw6flbnc0P8KO9tUJM JYZw/fbpR0OdQuIrma5RUm4= X-Google-Smtp-Source: AA0mqf46duqB+j3D4eG+XNLPT3xBvBGdDN2Da3RTbZXdbFr6opCIToe+8fq23l5AjAgvoA3Foy4Otg== X-Received: by 2002:adf:e78c:0:b0:236:704f:29f4 with SMTP id n12-20020adfe78c000000b00236704f29f4mr3127319wrm.11.1668243769760; Sat, 12 Nov 2022 01:02:49 -0800 (PST) Original-Received: from krug (87-196-81-1.net.novis.pt. [87.196.81.1]) by smtp.gmail.com with ESMTPSA id h11-20020a05600c314b00b003b4fe03c881sm12243276wmo.48.2022.11.12.01.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Nov 2022 01:02:49 -0800 (PST) In-Reply-To: <83edu9pn1b.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Nov 2022 16:45:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247640 Archived-At: Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Cc: danny@dfreeman.email, 58790@debbugs.gnu.org, >> felician.nemeth@gmail.com, stefankangas@gmail.com, dgutov@yandex.ru >> Date: Fri, 11 Nov 2022 14:02:34 +0000 >>=20 >> Eli Zaretskii writes: >>=20 >> >> These are their drawbacks, but they have many many >> >> advantages too, of course. You'll see me using comments very often. >> > >> > So we are in agreement? >>=20 >> You tell me. The repo right now contains the original "jar:" motivation >> story in the commit message and what I think are essential and useful >> comments in the source file. Is there anything you think is missing >> somewhere to aid comprehension of this change? > > I already added what I thought was missing. Thanks, it looks good.