From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Fri, 18 Nov 2022 19:42:16 +0800 Message-ID: <874juwebfr.fsf@yahoo.com> References: <87tu2wlku7.fsf@elite.giraud> <878rk8ee6d.fsf@yahoo.com> <8735agr0g4.fsf@elite.giraud> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59351@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 12:43:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ovzm8-0009tP-1Y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 12:43:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ovzlv-0005S7-EM; Fri, 18 Nov 2022 06:43:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ovzlu-0005Mj-55 for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 06:43:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ovzlt-0004NR-TK for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 06:43:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ovzlt-0002Gy-JP for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 06:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 11:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.16687717598693 (code B ref 59351); Fri, 18 Nov 2022 11:43:01 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 18 Nov 2022 11:42:39 +0000 Original-Received: from localhost ([127.0.0.1]:35448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovzlW-0002G9-L6 for submit@debbugs.gnu.org; Fri, 18 Nov 2022 06:42:38 -0500 Original-Received: from sonic311-23.consmr.mail.ne1.yahoo.com ([66.163.188.204]:34796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovzlT-0002Fq-Sm for 59351@debbugs.gnu.org; Fri, 18 Nov 2022 06:42:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668771748; bh=Pp1b4fzs6AtteumNjJMVFbgDDVWhhx51Th30XQYjgsY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Nyy6XWk3Uvicnl35w+9OC4vzNamAQNYGWx4dRSZOI0poZs/NztB2id1S9PZnT+FSlrdNiC/KbWIKFxjomsacAL8V4cAjXVKVwfZk7BFpAOF+pp1cA+ndUlLrk8Z3hHjJ/Vs32P1Y/pbDHfWKjYkJ/R35U3PdzsrOsdr5aJmkvDuLW8k0BTcpKOMJu6DFlHaeg674kmdodNQQhJe5nvW4+W+ahU8gvJBnA3zujEF5V8bQiaggrs7MsJw4zgV/jlio7M2NCD/E06ivSW46+/z1OiTNHg5Kc9lFbyJOS4Gh22HvysXCUzreK4ahj1ZYky4Ri064cvpn5z7PnKzzPqbF3A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668771748; bh=8K9pBp1rdiA1jh92VgMNTo37+GYubk9w7D0Qr5SXEMf=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=IAnWM0tzMDo8t0eBXYqKAAoVmpCbt+gXkz9sl30vKoOSnZei0OcYJ4cyLOcnwxh4xGiuY06SlWoWsFpT41IvOL+w5C9Me9QSHurQD/hJnHTa3WuHma6DvI+AyCCMk6giw2NAIZGc7S8ftlx5ofshenKHpVTPwOVJuT2PPoqfKefCYu1uFs7Bo0OqkSGaUXydTei1ayZckN8cMT+sPkP63kPDPLEFpc7VjOR+qgPuPa3eoQv38ScrIIRdCPL9TQWcdjk4xkEIej6A+WE4/GG1mlt+tnyXnc4wQFIKT6G9A/KF7QVoW1N9JH9bGLQ9+fyP0KRAKVvJuSMKAMLY7RnV2w== X-YMail-OSG: 8uXtuhAVM1mKvxIIQyuAJsECgt7iyCfrsxag70NG0csRy_uEKDhBeakGMPVzRo. AuRAaY._O8bciZTK_GNUYwQuWepVlh5EFVxR__iAH9wx2iPZ4jt31cVGwVZ0NGJ7DHv8wohTjcjh 8i7Wg_FjxDfEfGQWcJYoCG3haAEHlS.vG8sxNdp9qWdaoe1fnYS3scCi19uVQimYNaGLYg_nqtn7 WUF2mvL8dUFr34qKmU8Fr1WhuF2GZ5xTIZWx2c1HYpo_MKVSfmzv6aeUbj1T_izqWKiXyHOW9ZVG RgWy1FbwsuoAV5zZW7X21RsVOdNyqEn11XbFIbLJbKUycOqHXtPPwa2mFc2U6G84Pn1chyH_3oRi Jvj1QSBhJ00DEyPKHKzXF633qB.7GyREheRc_eUHSAW8XJs2vfB_jg7TI33Z0XODBhCABGX9Xkhg p7cF371YxeqO5vm.Mj_fDjkEcgdjEScRpicqXz7f3zilsUu8xnc5PRhdrbAlC5S0MR2hi6QsxQa5 ywowWIxtt8FFNJIzJiLQrcT2R8xjqVQ10LVV4tzv1CLM.pd7wXXczu4O5DNTyXHFD3L1Bpg1hUUM FalzZJGwO9St9D3BJczWofaeqL.TRtnZs7dTsCXtVTaLHFUxZawQNoMKIizYoQL_A60lHJ0OIvnJ fo_44s9AJF2Pg5xxhUWrK5Gy9E9KdHqdAHMxf2wCCD0ZmJgFZqHlxwYeFXMWiBHYb0r7ee6bUgE8 C6awqX1mHXTwrR3e4N0QZO3XHsQKAEpb8sQnvyo67jcPNum6GSSpWSwuxGVOkyIv2ZK6sWxvS9wr VHHuVHEPJmEXwQMCRJhLhNvzrvTs_mi7DBInUnfK9V X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Fri, 18 Nov 2022 11:42:28 +0000 Original-Received: by hermes--production-sg3-6c8895b545-qz6cd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 64824cc6da9b3fbc0da240c6360408c9; Fri, 18 Nov 2022 11:42:23 +0000 (UTC) In-Reply-To: <8735agr0g4.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 18 Nov 2022 12:01:15 +0100") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248201 Archived-At: Manuel Giraud writes: > +struct glyph *x_y_to_hpos_vpos (struct window *, int, int, int *, int *, > + int *, int *, int *); Shouldn't this be "extern struct glyph *x_y_to_hpos_vpos ...?" > + /* I guess this works because the menu bar is always > + at position (0, 0) in a frame. Should this changed > + and we need a way to calculate the correct position > + into the menu bar from the position of the event in > + the frame. */ I think this comment is unnecessary. Where else would a menu bar be?