From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#60331: 29.0.60; ERC 5.4.1: ERC cannot join channels without the networks module Date: Wed, 28 Dec 2022 07:08:57 -0800 Message-ID: <874jtfftva.fsf__32306.006136217$1672240235$gmane$org@neverwas.me> References: <873592k987.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Lele Gaifax , emacs-erc@gnu.org To: 60331-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 28 16:10:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAY4Z-00051r-2b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Dec 2022 16:10:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAY4D-0004zL-Ov; Wed, 28 Dec 2022 10:10:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAY4B-0004yq-Rh for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 10:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAY4A-0007WN-LE for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 10:10:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAY4A-0005Vv-59 for bug-gnu-emacs@gnu.org; Wed, 28 Dec 2022 10:10:02 -0500 Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Dec 2022 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 60331@debbugs.gnu.org, jp@neverwas.me, jp@neverwas.me Original-Received: via spool by 60331-done@debbugs.gnu.org id=D60331.167224015821127 (code D ref 60331); Wed, 28 Dec 2022 15:10:02 +0000 Original-Received: (at 60331-done) by debbugs.gnu.org; 28 Dec 2022 15:09:18 +0000 Original-Received: from localhost ([127.0.0.1]:58441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAY3S-0005Uh-BD for submit@debbugs.gnu.org; Wed, 28 Dec 2022 10:09:18 -0500 Original-Received: from mail-108-mta198.mxroute.com ([136.175.108.198]:37287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAY3Q-0005UR-Do for 60331-done@debbugs.gnu.org; Wed, 28 Dec 2022 10:09:16 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta198.mxroute.com (ZoneMTA) with ESMTPSA id 1855947a694000011e.001 for <60331-done@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 28 Dec 2022 15:09:06 +0000 X-Zone-Loop: 712e21c80cad6dff4bf0438fd3809f2b4cc1e5ea52a3 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xcYE6gwhSLtaPEBY7BCXmhmZxrMZvNVr0Ig6LM+D1qs=; b=na+QRgRrKwRPJJxeI23/vnyWL8 aTB8tGY8NzD4Tp8rf34r71C3u8vBiGbEYZGtOAAy2YXaVx/HdrpDI9XiXqY92eWLvTOPX6iyLM4Na Xh0KlEmpIJ5BPz11ak9rjXH/jZdmMTbFrGsU51vj6mwJyoFZMEJBZFhI9eQsxCu1WPwBzn/PcOXbN lu5/ryULmT294WM4xSuRGlUWBuXA+lnJrv1vPkFY8rG3se02cCWsy6OwOmZUD47PTq7Ml3cBT21a2 fLdAZ0T/CxcfJNfrTBaBkaiEB2o7fHJjFAkJRHTIW8Du/BZWYeNyir2Vi1sYlcdIn3bypxeJL3A1a 9+qn2DPg==; In-Reply-To: <873592k987.fsf@neverwas.me> (J. P.'s message of "Sun, 25 Dec 2022 21:46:48 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251987 Archived-At: "J.P." writes: > Tags: patch > > This is in reference to > > https://lists.gnu.org/archive/html/help-gnu-emacs/2022-12/msg00651.html > > which affects query buffers as well as channels in what will become ERC > 5.5 (both Emacs 29 and HEAD). To reproduce from emacs -Q: > > (require 'erc) > (setq erc-modules (remq 'networks erc-modules)) ; or delq even (ahem) > (erc :server "127.0.0.1" :port 6667 :nick "tester") > > The attached patch tries to address this in a hopefully agreeable > manner. Thanks. This has been addressed in a slightly more responsible manner than that originally proposed. In a pinch, third-party code can opt out of the scary message by locally removing it from an internal hook during mode or local-module setup (while ideally also alerting us to the need for a public analog). If anyone takes issue with this approach or has a better one in mind, please say so relatively soon. In the meantime, I'm closing this bug report. Thanks.