From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter introduction documentation Date: Fri, 30 Dec 2022 15:54:11 +0000 Message-ID: <874jtc99b0.fsf@posteo.net> References: <83edszjslp.fsf@gnu.org> <87tu1vxs3a.fsf@ledu-giraud.fr> <831qozjob7.fsf@gnu.org> <87cz8jxoat.fsf@ledu-giraud.fr> <83wn6ri7pn.fsf@gnu.org> <5e0a3185-de82-b339-0fa2-956779e63d6f@cornell.edu> <868rj6vfep.fsf@gmail.com> <4895891b-e5ea-9c37-f51b-df2e479ee758@yandex.ru> <83y1qt11xq.fsf@gnu.org> <9eb013da-d0fc-8e17-c6e3-1e8f913aebfa@yandex.ru> <83pmc50xxc.fsf@gnu.org> <71cfe4e8-3bb8-b0a6-9be5-8c0a6d92cfab@yandex.ru> <83h6xg29z3.fsf@gnu.org> <87wn6cyey5.fsf@posteo.net> <787B1EB4-1925-4679-8747-449DCD685432@gmail.com> <83y1qo6h7a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15870"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Yuan Fu , monnier@iro.umontreal.ca, dgutov@yandex.ru, theophilusx@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 30 16:54:44 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBHiW-0003wn-0o for ged-emacs-devel@m.gmane-mx.org; Fri, 30 Dec 2022 16:54:44 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBHi4-0004wa-VF; Fri, 30 Dec 2022 10:54:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHi2-0004wR-0M for emacs-devel@gnu.org; Fri, 30 Dec 2022 10:54:14 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBHhw-0004Js-Rg for emacs-devel@gnu.org; Fri, 30 Dec 2022 10:54:13 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 93FE6240159 for ; Fri, 30 Dec 2022 16:54:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672415646; bh=nGxRx2DZ8SwuV0MrD8cxvepCYjDYtTFBCfWfkzPEBmw=; h=From:To:Cc:Subject:Date:From; b=JXklWIFuUbk1Piygt5fSQJWR88acLjdXelqUqFC7nsaB/xHF5tFr0l8ZLMROBgxNt i3AZAtgvmr+VXqyI+beRTW51rAweyysF1dblLg7PcepCSXv2WQjDpYbJo3iVhFMDM1 cGyOs5iQwdfC5GcKLiUd0BrghQauB+lAhQZpNCQonFzjisG1iGgmeXv8y44SUYwuru GB6nGoT5xIXftCNi5ALl9ZZDQOhqwIcTBNTB+cyvcvLZzkg4Wil26NNgV3WfhQeAeo z69Ev78EacPzpY/NsWEsaBK/iMyXO2KHMF/0c4rXseyqlx+HGUVmPd2b5yW2gOOW2r rl3u5XqovgerQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Nk8vK4DQfz6tnY; Fri, 30 Dec 2022 16:54:05 +0100 (CET) In-Reply-To: <83y1qo6h7a.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 30 Dec 2022 17:31:53 +0200") Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302121 Archived-At: Eli Zaretskii writes: > (message "Cloning repository") > ;; git clone xxx --depth 1 --quiet workdir > (treesit--call-process-signal > "git" nil t nil "clone" url "--depth" "1" "--quiet" > workdir) > > Why "--depth 1"? This should be a defcustom, and the default should > be to clone the full repository, IMO. Also, what about updating the > library when it is already installed, and the Git repository already > exists for it? Or are we going to clone anew each time and them > remove the repository? that could make its cloning be slow in some > cases. I have proposed just downloading a tarball. GitHub provides these for each tag, and the tree-sitter developers appear to tag versions on a regular basis. The file could then be downloaded via url.el instead of using Git. https://github.com/tree-sitter/tree-sitter-c/archive/refs/tags/v0.20.2.tar.gz