From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#60758: 29.0.60; while-let uses if-let* convention in contradiction to the docstring Date: Sat, 14 Jan 2023 14:13:03 -0700 Message-ID: <874jsslt0g.fsf@melete.silentflame.com> References: <87k01r7e3u.fsf@daniel-mendler.de> <87zganl168.fsf@melete.silentflame.com> <87y1q5rv48.fsf@web.de> <878ri5krrd.fsf@melete.silentflame.com> <83h6wt6pmd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28097"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: michael_heerdegen@web.de, mail@daniel-mendler.de, 60758@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 14 22:14:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pGnr2-00074k-Bz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Jan 2023 22:14:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pGnqn-0006Gf-Cz; Sat, 14 Jan 2023 16:14:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGnql-0006GW-Hh for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2023 16:14:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pGnqk-0000e9-E4 for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2023 16:14:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pGnqk-0001QL-6w for bug-gnu-emacs@gnu.org; Sat, 14 Jan 2023 16:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Jan 2023 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60758 X-GNU-PR-Package: emacs Original-Received: via spool by 60758-submit@debbugs.gnu.org id=B60758.16737307975409 (code B ref 60758); Sat, 14 Jan 2023 21:14:02 +0000 Original-Received: (at 60758) by debbugs.gnu.org; 14 Jan 2023 21:13:17 +0000 Original-Received: from localhost ([127.0.0.1]:55643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGnq1-0001PB-AS for submit@debbugs.gnu.org; Sat, 14 Jan 2023 16:13:17 -0500 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:33349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGnpw-0001Oo-70 for 60758@debbugs.gnu.org; Sat, 14 Jan 2023 16:13:15 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 403E832007F9; Sat, 14 Jan 2023 16:13:06 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 14 Jan 2023 16:13:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1673730785; x=1673817185; bh=8c eoRS1tDhLS7OPPXEVaZok5DkzMhKHVSeywwrMDpLY=; b=izXHfJsx4DOcbO+gda QiLenRNx9JNsU15MqM6CwH7kDV6Yb3elCg26ec3VahKgFIJ42SR2/3PLE6PK4CeI 3AiWlbx1sLPyKMAyk1yKIPc8xqizgN4elDGg2tX8kTD8gwUiNMjs97wdmZTaN0yf ENqbvV6VI4A3OlAe897iyD+d451e3y+FLZ8D7tbveKf6I/6CsJK5t9ezErwDL+BS d+gbnRJJ7x9SzrWRR2DwWDsiO58bqnmWmO8ylNhSPSMcrK26t3xDSaYXthsr9S0l 65oXj4bEwT5B5+x2nICQYF+A2C2EnnawNWtdsCouqPvrnE3wIn1HIIVWE249x/9n bfwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1673730785; x=1673817185; bh=8ceoRS1tDhLS7OPPXEVaZok5DkzM hKHVSeywwrMDpLY=; b=eyRqdcKin+ean1rEB6LD31MBd6ScL/JbKuO9+DLOndFo hQWpT09E9Ff/qxB5DXSr10tLX1Yej8kfBHRfAjUD7kQjodP4UbGR1+dM4ghZWpU+ Dfe++MF1rEGLnWFClMKhhxEb6P9XmyR9vXt0PEWcbbJr8+tPWleKkCoclJVODJz9 Y4AeSYipYE1iWqtABKW25LM/kzVzLOLkqN1/xA43ZEfAZJQH57qTs9ABmg6FFMfh 3nZCtIbY5sHSmL2lKMQof8WnQ53SijqoGcevQb7uYdsaA4ecwGvdVMrbL0EBsrZl tJFY2UuvCPMn0qwMIbDmf6QDs164X0XAb/TWrIDTag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddttddgudegiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 14 Jan 2023 16:13:05 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id E31C07F1168; Sat, 14 Jan 2023 14:13:03 -0700 (MST) In-Reply-To: <83h6wt6pmd.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Jan 2023 18:35:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253385 Archived-At: Hello, On Sat 14 Jan 2023 at 06:35PM +02, Eli Zaretskii wrote: >> Cc: Daniel Mendler , 60758@debbugs.gnu.org, >> 60758-done@debbugs.gnu.org >> From: Sean Whitton >> Date: Sat, 14 Jan 2023 09:25:26 -0700 >> >> > So it makes no sense to add this syntax to newly introduced macros. We >> > should fix the docstring of `while-let' instead - unless the goal of >> > getting rid of this syntax has changed. But then we should have a >> > discussion first. Instead it seems you just reverted a change by Lars >> > that was the result of a discussion in emacs-dev. >> >> Are you saying there was a while-let-specific discussion? >> >> I did vc-annotate and saw that the code I was changing was in the first >> commit of the new macro. > > Then something went wrong with vc-annotate, because that code was > modified in commit 0e72d4793c, on Sep 29, the day after the first > commit of this macro. Or, what is more likely, I misread the output :) My apologies for this. We should fix the docstring or the code; there's still a bug if I just revert my change. I haven't reviewed the old thread but it sounds like a decision was already taken to fix the docstring instead. Do you agree? If so, I'll replace my change. -- Sean Whitton