From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map'. Date: Mon, 16 Jan 2023 18:18:47 +0100 Message-ID: <874jsqe6tk.fsf@gmail.com> References: <167346587385.21119.11842722402918987249@vcs2.savannah.gnu.org> <20230111193754.33EF3C00A7F@vcs2.savannah.gnu.org> <87fscaeg5s.fsf@gmail.com> <83lem24kia.fsf@gnu.org> <878ri2ed4h.fsf@gmail.com> <83bkmy4dru.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4067"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jan 16 18:19:38 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHT8z-0000t3-Oi for ged-emacs-devel@m.gmane-mx.org; Mon, 16 Jan 2023 18:19:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHT8O-00044X-0C; Mon, 16 Jan 2023 12:19:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHT8G-0003xg-AA for emacs-devel@gnu.org; Mon, 16 Jan 2023 12:18:58 -0500 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHT8E-0002FA-RS; Mon, 16 Jan 2023 12:18:52 -0500 Original-Received: by mail-wm1-x32d.google.com with SMTP id j34-20020a05600c1c2200b003da1b054057so8378191wms.5; Mon, 16 Jan 2023 09:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=c/A+kAplGgrIqoiIavTK+3HyWfNA4cJjlHAIciWilRo=; b=IHXQ9Jzs1hYYpI2EuREtIjZnAjyzIJpJ865J2GouG8XxJxtwUTDNlWkNI0W1HE2GO8 GXfDMWnEXCCHKToWgSS7OhMNO9+BZL5ht7HI4xEufmN3MMtI5hadlgDNEA7KRvutigz/ V68wkc33fRmVT5ISvDlcHHaUqUyFCLssTBaQ32Gjrse9EpYSXoHWyaT7CTfdMg0IMtqO ROigeibP0SGSgd/cLNrM30ud3uW6XAgoiNRvet+uO7N2clBizDnxXLWG0xwKmoauZUKd LBsys/4CbWT+Vki8iZmLge4xvBITr1kQN42dn52RWtMymxySdqOmXKO0OrhnZbhyd3rL aN4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c/A+kAplGgrIqoiIavTK+3HyWfNA4cJjlHAIciWilRo=; b=wQ7+11CeFCAEbWTAV8fN3azuJbrLaWqdpxYLAsLn8w5CuhTk+qHQeOyXPtlp+obB73 Q9HATXX4bxAOvyKAq+Oh/rxaHjUpYwgygFeF1ho9dJeZWdOvQ81IydNtJdpEnjgpi3Y2 XKuKKx/+OKTwZ7vr9bR+ZQ69ODyM6i8I13zqzd2qCgJqCWiiICuy/T/MJ27hbXciyBYy xo/yO0dpLhAtQ5A6IBzuFPmevHwSMdBz7Bg+fmpUId6+k9KyGDHqz4fA9xBTKVRlcLH0 lyv3YT9D92XXkTyi1zs4YCa0s1ARMU01geuReAyfy2pDdgr3UA63h51C553Np/dkpbPV oTHQ== X-Gm-Message-State: AFqh2kqp9IKBwI705T5pQ7AWg61R7ocUQIeKp1TG6aGAUQt6Lnh6y7H8 mow1yx3CSn73qo4AGCwQJ0BSgtoA/Ew= X-Google-Smtp-Source: AMrXdXtLilpKxCPCYSDsEVA69DXeL2R9a4JKpwtwgDnnAqyLQvLvqNKXd2LCIsgDe2x4A3oc+wwvFQ== X-Received: by 2002:a05:600c:1695:b0:3da:f651:8ccc with SMTP id k21-20020a05600c169500b003daf6518cccmr275015wmn.4.1673889528753; Mon, 16 Jan 2023 09:18:48 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id j20-20020a05600c1c1400b003daf89e01d3sm5530626wms.11.2023.01.16.09.18.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 09:18:48 -0800 (PST) In-Reply-To: <83bkmy4dru.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 16 Jan 2023 18:58:45 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=rpluim@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302463 Archived-At: >>>>> On Mon, 16 Jan 2023 18:58:45 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: emacs-devel@gnu.org, juri@linkov.net >> Date: Mon, 16 Jan 2023 16:02:38 +0100 >>=20 >> >> Juri/Eli, any objection to putting something like the following in >> >> emacs-29? That would make it easier to add heading-specific bindi= ngs >> >> in NEWS mode, which I=CA=BCd do in master. It also avoids creatin= g a >> >> separate keymap for each heading. >>=20 Eli> I don't think I understand the problem you are trying to solve, and Eli> why this particular solution. Please tell more. >>=20 >> In outline-mode and modes derived from it, there are various bindings >> that work at the start of headings (and in buttons that could be >> inserted depending on the value of `outline-minor-mode-use-buttons= =CA=BC), >> such as "RET" for `outline-cycle'. >>=20 >> Adding more bindings there is a pain, since the bindings are done >> using a separate anonymous keymap on each per-heading overlay, which >> means iterating over all the overlays in order to make changes. The >> patch I sent changes that to use a named keymap, so only the named >> keymap needs to be updated or `setq-local'=CA=BCd before invoking >> `outline-mode'. Eli> Ah, okay. Fine with me if Juri (or someone else) doesn't object. >> (and what I really want to do is add 'n' and 'p' into that map, which >> improves the speed at which I can proofread NEWS.) Eli> On master or emacs-29? On master. I=CA=BCm assuming adding bindings would not fall under 'bug fixes only'. Robert --=20