From: Jonas Bernoulli <jonas@bernoul.li>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 60740@debbugs.gnu.org, larsi@gnus.org
Subject: bug#60740: [PATCH 0/2] emoji changes
Date: Sat, 04 Feb 2023 13:05:28 +0100 [thread overview]
Message-ID: <874js1vdo7.fsf@bernoul.li> (raw)
In-Reply-To: <83zg9tu91v.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> Thanks.
>
> Would it make sense to install the first patch on the emacs-29 branch
> and the second on master? Or did I misunderstand your explanations
> above? AFAIU, the first patch solves the immediate issue in this bug,
> right?
That's correct and it would make sense to do it like this. At the same
time I think that it is risky both to install and not install the second
patch on emacs-29. On the one hand past changes to transient did not
break emoji, even though I did not specifically try to prevent that. On
the other the risk of that happening going forward is not zero. If Lars
finds the time to look at the refactoring before the pre-release, I
think it would be best to install it on emacs-29, but if not, I am find
with it going on master instead.
next prev parent reply other threads:[~2023-02-04 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <83leli3nly.fsf@gnu.org>
2023-02-01 23:09 ` bug#60740: [PATCH 0/2] emoji changes Jonas Bernoulli
2023-02-01 23:09 ` bug#60740: [PATCH 1/2] No longer use transient in isearch-emoji-by-name Jonas Bernoulli
2023-02-01 23:09 ` bug#60740: [PATCH 2/2] Rewrite emoji's usage of transient Jonas Bernoulli
2023-02-04 8:30 ` bug#60740: [PATCH 0/2] emoji changes Eli Zaretskii
2023-02-04 12:05 ` Jonas Bernoulli [this message]
2023-02-04 12:29 ` Eli Zaretskii
2023-02-05 14:40 ` Jonas Bernoulli
2023-02-05 14:53 ` Eli Zaretskii
2023-02-05 15:02 ` Eli Zaretskii
2023-02-05 16:29 ` Jonas Bernoulli
2023-02-05 16:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874js1vdo7.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=60740@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.