From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#62027: Subject: 29.0.60; Breaking change in forward-sentence/backward-sentence Date: Tue, 07 Mar 2023 08:31:49 +0100 Message-ID: <874jqxkoey.fsf@runbox.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35970"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Manuel Giraud To: 62027@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 08:33:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZRp1-00093N-HM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 08:33:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZRol-0004FK-QE; Tue, 07 Mar 2023 02:33:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZRok-0004FA-JK for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 02:33:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZRok-000118-6t for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 02:33:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZRok-0008MX-2c for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 02:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 07:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62027 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167817434032088 (code B ref -1); Tue, 07 Mar 2023 07:33:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Mar 2023 07:32:20 +0000 Original-Received: from localhost ([127.0.0.1]:44355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZRo4-0008LU-4P for submit@debbugs.gnu.org; Tue, 07 Mar 2023 02:32:20 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:49286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZRo2-0008LM-TJ for submit@debbugs.gnu.org; Tue, 07 Mar 2023 02:32:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZRo2-0003c1-JO for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 02:32:18 -0500 Original-Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZRnx-0000s9-RT for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 02:32:18 -0500 Original-Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1pZRnp-00CrWX-Sc; Tue, 07 Mar 2023 08:32:05 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=LP+PfqkHiM4J4ByC584Jn91Zt+1EQ9CMHWraHA9xsRA=; b=otl7ORF8oxeasSN+7Y3YUrgez pr5HJzEWKSOUOMyQoSrElGj1k6BL6XUauuGHwI4QeHz9LZSr6/IFzp62rnbZmhB6pjve796F1T1DF RaeE0b0O/r+mzXP7KcQBEw7SID9/jZQWjLNLA4VGTPb0MVx24hn7Gioj4GMSwxvR4qj7hJOayG23t KF19i+9uZyCq+3Qmlr6sDhYd6i69r1QDlq1J67s/wXnAvI48Nmx0fp/TlogskIwKZFG2LBcR519aZ UwsRkoWKoKV4bzBKWevFfHj2nQdeaSReKE45k1lblitKvIi6kkNTxm/7w2dQVjG3Lr3kZAV/wswrA hcOrmMAUQ==; Original-Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1pZRnp-000776-5i; Tue, 07 Mar 2023 08:32:05 +0100 Original-Received: by submission01.runbox with esmtpsa [Authenticated ID (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1pZRnZ-0000xl-8X; Tue, 07 Mar 2023 08:31:49 +0100 Received-SPF: pass client-ip=2a0c:5a00:149::26; envelope-from=simenheg@runbox.com; helo=mailtransmit05.runbox.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257432 Archived-At: Hi. Commit 460d5fd971489ba7b573d71a94cdaac2f9f1a767 introduced a new function `count-sentences', which is nice, but it also silently changed the return value of `forward-sentence' (and thus also `backward-sentence') from returning the new value of point to returning t/nil based on whether point moved or not. I just discovered this because it caused one of my packages to break, since it relies on the previous style return values from `forward-sentence'/`backward-sentence'. It would be easy enough fix on my part, but I'm wondering whether this change was intended, and if so, whether it should be documented somewhere so package authors can adapt more easily? Or could perhaps the change in return values from `forward-sentence'/`backward-sentence' be reverted to old behavior, and the counting logic be left to `count-sentences' instead? -- Simen