all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Simen Heggestøyl" <simenheg@runbox.com>
To: 62027@debbugs.gnu.org
Cc: Manuel Giraud <manuel@ledu-giraud.fr>
Subject: bug#62027: Subject: 29.0.60; Breaking change in forward-sentence/backward-sentence
Date: Tue, 07 Mar 2023 08:31:49 +0100	[thread overview]
Message-ID: <874jqxkoey.fsf@runbox.com> (raw)

Hi.

Commit 460d5fd971489ba7b573d71a94cdaac2f9f1a767 introduced a new
function `count-sentences', which is nice, but it also silently changed
the return value of `forward-sentence' (and thus also
`backward-sentence') from returning the new value of point to returning
t/nil based on whether point moved or not.

I just discovered this because it caused one of my packages to break,
since it relies on the previous style return values from
`forward-sentence'/`backward-sentence'. It would be easy enough fix on
my part, but I'm wondering whether this change was intended, and if so,
whether it should be documented somewhere so package authors can adapt
more easily?

Or could perhaps the change in return values from
`forward-sentence'/`backward-sentence' be reverted to old behavior, and
the counting logic be left to `count-sentences' instead?

-- Simen





             reply	other threads:[~2023-03-07  7:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07  7:31 Simen Heggestøyl [this message]
2023-03-07  9:35 ` bug#62027: Subject: 29.0.60; Breaking change in forward-sentence/backward-sentence Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07 11:03   ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07 13:07     ` Eli Zaretskii
2023-03-07 16:07       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07 16:17         ` Eli Zaretskii
2023-03-07 16:42           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07 17:19             ` Eli Zaretskii
2023-03-07 19:07               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-07 19:32                 ` Eli Zaretskii
2023-03-08  6:50                   ` Simen Heggestøyl
2023-03-08  8:38                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-08 15:52                       ` Drew Adams
2023-03-08 16:52                         ` Eli Zaretskii
2023-03-08 17:52                           ` Drew Adams
2023-03-08 19:46                             ` Eli Zaretskii
2023-03-08 16:51                       ` Eli Zaretskii
2023-03-08 21:02                         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jqxkoey.fsf@runbox.com \
    --to=simenheg@runbox.com \
    --cc=62027@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.