From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#62250: 29.0.60; Allow context menu from text properties to not override everything Date: Sun, 19 Mar 2023 19:21:21 +0100 Message-ID: <874jqgzjoe.fsf@gmail.com> References: <87ttyixzt2.fsf@gmail.com> <865yaxq5xh.fsf@mail.linkov.net> <87cz55rjir.fsf@gmail.com> <86fsa0r60v.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28630"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62250@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 19 19:22:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdxfa-0007L0-Q5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Mar 2023 19:22:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdxfR-00051w-09; Sun, 19 Mar 2023 14:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdxfO-000507-DC for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 14:22:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdxfO-0003BP-59 for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 14:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdxfO-0003NZ-07 for bug-gnu-emacs@gnu.org; Sun, 19 Mar 2023 14:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Mar 2023 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62250 X-GNU-PR-Package: emacs Original-Received: via spool by 62250-submit@debbugs.gnu.org id=B62250.167925009112953 (code B ref 62250); Sun, 19 Mar 2023 18:22:01 +0000 Original-Received: (at 62250) by debbugs.gnu.org; 19 Mar 2023 18:21:31 +0000 Original-Received: from localhost ([127.0.0.1]:52717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdxet-0003Mr-Ag for submit@debbugs.gnu.org; Sun, 19 Mar 2023 14:21:31 -0400 Original-Received: from mail-ed1-f50.google.com ([209.85.208.50]:41916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdxer-0003Mb-RI for 62250@debbugs.gnu.org; Sun, 19 Mar 2023 14:21:30 -0400 Original-Received: by mail-ed1-f50.google.com with SMTP id h8so38726948ede.8 for <62250@debbugs.gnu.org>; Sun, 19 Mar 2023 11:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679250083; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KoVdR5Qmz1uDV9rh82OvunorwLFtGgMxS3LM0F32VS0=; b=S0+e77b6ZRjJDyxcuMlQGSWV+Xrw9JSCdoqWZXHSXl43GySyPxQ0npe1zZUseDA6EC fbQ+yfiFoOt7WFLRg7W6A06Ab1zUZDuhlbfzQr9OK7lImrIl4ZM7Fp1PWfz/e0c9SDlQ gPIkBM7YGe6/j5ASGNg0w5qtmIzIK1U7/JvPmd7UyMxz57dIqxtWfYiPHhVLjZzYnB4d QAXpWibSCTGTjSWrxP81XaujoN8ldeIPV296Q2wyquF1hb1xvYy+QDjtywiFIJC06yo8 Pjpfo4HdGMTpaKYTLw+btLn5QzeEOGDt/VJIItEDc+qGsPfRmVEhbL/nr327tze+PKGt S3/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679250083; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KoVdR5Qmz1uDV9rh82OvunorwLFtGgMxS3LM0F32VS0=; b=0YQu6rY+UWmVXUQlswzmTMbGMa8Tftevs0rPQEZda43jW+HQot2FCiy8ltAHmsh1RL 72OqEi3bS4eYIz2cUbIbWQ3j9wJIh5vglbbdFvZOAXDhSEZrFs13vexlndK3IS2kEZT0 9URq5E7M9R1VjuaSLs9yMIdhJPTNVfGh9xm7ZKdoAyLBHhxBBaq2OEZVMNmq7MybOGmO oVAnvpJCj5PMXqe4kil2vsDpzMgseK2qO/gcXALGRxXL57fFnJety/6E0HZEluBVrnt0 CKGqes3hXgnT34Yr8K7WEYXGh6yLN2t0p3D8tv1JnQDag+8kKBidqP54Bhush9zk1kqm Kiew== X-Gm-Message-State: AO0yUKXfNt/nFU8HgyRXcq05urGMphhyruEvKpJ8XCaXQc2k0Butq3dS Wfn8HTlEBmvGhuyc7wLOIEUUIpDPlBQ= X-Google-Smtp-Source: AK7set8g+F4aUIValp/wDmtxYdpBq/Vd0kgJF6SoOVGLE2qHWic3DPUiYzzW2roF0fcl+OSpgwOITg== X-Received: by 2002:a17:907:212b:b0:92f:8353:2aaf with SMTP id qo11-20020a170907212b00b0092f83532aafmr6647456ejb.70.1679250083445; Sun, 19 Mar 2023 11:21:23 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8ca4]) by smtp.gmail.com with ESMTPSA id z24-20020a17090674d800b009289de993e2sm3509320ejl.216.2023.03.19.11.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 11:21:23 -0700 (PDT) In-Reply-To: <86fsa0r60v.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 19 Mar 2023 19:43:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258252 Archived-At: On Sun, 19 Mar 2023 at 19:43, Juri Linkov wrote: > The patch below will allow using the text property like > > 'context-menu-functions '(image-context-menu) I didn't test the patch (I don't understand click events very well), but does it find the context-menu-functions property of overlays as well? And would those override the context-menu-functions text property or get merged? > (run-hook-wrapped 'context-menu-functions > (lambda (fun) > (setq menu (funcall fun menu click)) > - nil))) > + nil)) > + (dolist (fun funs) > + (setq menu (funcall fun menu click)))) > > ;; Remove duplicate separators as well as ones at the beginning or > ;; end of the menu. I believe this makes the menu entries coming from a text property appear after the regular hook ones, while I would expect the opposite (stuff specific to the point is more "urgent").