From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Sun, 09 Apr 2023 14:21:43 +0100 Message-ID: <874jppb388.fsf@tcd.ie> References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile5gv0c.fsf@tcd.ie> Reply-To: Basil Contovounesios Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15920"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62694@debbugs.gnu.org, Michael Albinus To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 09 15:22:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plUzn-0003wK-Jr for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Apr 2023 15:22:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plUzd-0005Mh-03; Sun, 09 Apr 2023 09:22:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plUza-0005MV-WE for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 09:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plUza-0000lH-O1 for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 09:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plUza-0000Ip-6c for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 09:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Basil Contovounesios Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Apr 2023 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.16810465141148 (code B ref 62694); Sun, 09 Apr 2023 13:22:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 9 Apr 2023 13:21:54 +0000 Original-Received: from localhost ([127.0.0.1]:60374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plUzS-0000IS-8J for submit@debbugs.gnu.org; Sun, 09 Apr 2023 09:21:54 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:41711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plUzP-0000ID-Pq for 62694@debbugs.gnu.org; Sun, 09 Apr 2023 09:21:53 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id n19-20020a05600c501300b003f064936c3eso6535408wmr.0 for <62694@debbugs.gnu.org>; Sun, 09 Apr 2023 06:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1681046506; x=1683638506; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l3KD1mEX65ML15hWMpBguIMYM+masEGFMUwYsD9UTYo=; b=VUp2GX8wPgVy5EtFjdWKtMpA7vAviEE4WyaPxmVDS5A7TCiaIPvHK86xfhhALPPbVT ivHRoERqBrXkzfvjc4IOkUuMU6x32KC8KiXoI7BQwT3+bxvpdztHn9CED4p481Ef8QOu SGx6QmbkPJ594Lu+9E52MmTPx0BMMUW+XaaV4w/OJciqhz9pcewv+J346CtEqHmihavm ac4KkK7ntAHfVFmJg9BxRnfgpI6E7VfkU4piMBvdR/Zqjt/1+iORUq3ORKiUzk0ej4Ze AgX6G1HHLWFBa4tWaoUUG07pBL1+sDhDdVieGqkCTcv9Apsx+tRVvt4H3ddqR20qOolv rMxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681046506; x=1683638506; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=l3KD1mEX65ML15hWMpBguIMYM+masEGFMUwYsD9UTYo=; b=DbgqjusMfZPmM3hnVj0cf9PvvmS/YhrHFWtt6/D/gM7WwS2CNwQHT2NZudVtDH0H7O de4kwO1Za9ApqzuWv9QbrpggjTXVpjug3xiVaYrOT9fpQ2anmK90MUigD1y50nydLhDe otAsy92pv5h0mSOOQFJHTCNyObMxx4EHqOqYW5vub1+r8qL5erJv4L07Zgu/E5T00iFP X7wqnnBChZVke4akxQa81UDVycwq27aO/A3yC9mJYvVgRAcrrT95hAWlRL/vcgfuFFjP Alxr+umrF0ReAZ9tNovyQVkiCRSIHoS9PAYLGPV6Ry8DEQNvAUG7D+ZNkyDE7IzUHf8X W3pQ== X-Gm-Message-State: AAQBX9cDOZ7wno+cdYFEfNz544+LmUwxobHjIeVu7awADwR6R0TiExdC td8SKYF6KgnHfGhxDRK3XOq3Zw== X-Google-Smtp-Source: AKy350a0/injjcOKyDmPnSRK+plCYbeSO1pDHdeuJSk3wnLMYDRQpobSbSu7Kw9U5CntwN9GVtIO1w== X-Received: by 2002:a1c:4c08:0:b0:3ed:33a1:ba8e with SMTP id z8-20020a1c4c08000000b003ed33a1ba8emr5480199wmf.1.1681046505786; Sun, 09 Apr 2023 06:21:45 -0700 (PDT) Original-Received: from localhost ([146.70.133.115]) by smtp.gmail.com with ESMTPSA id w24-20020a05600c099800b003ee74c25f12sm14249313wmp.35.2023.04.09.06.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 06:21:45 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 9 Apr 2023 13:41:33 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259520 Archived-At: Jo=C3=A3o T=C3=A1vora [2023-04-09 13:41 +0100] wrote: > On Sun, Apr 9, 2023, 12:22 Basil Contovounesios wrote: > > Jo=C3=A3o T=C3=A1vora [2023-04-06 13:49 +0100] wrote: > > > On Thu, Apr 6, 2023, 12:22 Michael Albinus wr= ote: > > > >> > Instead of using your distribution package manager, I recommend > >> > installing pylsp via the official Python package manager, pip, and > >> > doing it like so: > >> > > >> > pip install "python-lsp-server[all]" > > IME this may not be sufficient to get the latest version of pylsp's > dependencies, such as autopep8, which I presume is the component > responsible for the differences in formatting across development > environments. > > IOW it may be necessary to explicitly 'pip install -U autopep8'. > > If that were true, GitHub CI would be failing, since it used this > command, and it's not. The CI probably installs anew each time it runs, whereas I was hinting (sorry for not making it clearer) at the case where a local user updates pip packages over time. > >> I disagree. Running regression tests towards bleeding edge development > >> version of pylsp is not the intention. You cannot expect, that everyb= ody > >> running Emacs tests has installed pylsp like this. But she could have > >> installed the Debian pylsp package. > > > > Sure, or she has a 'pylsp' that prints the complete works of > > Shakespeare. But these tests are designed for the number one > > recommended pylsp installation method. It's AFAIK not the > > "bleeding edge" (which would be a Git installation). And tests > > have been running fine with that installation method for a > > number of months now, maybe even years. > > FWIW the autopep failure in bug#61637 was with latest pip-installed > pylsp and autopep8, and the patch in that report worked around it by > accepting one of a number of possible formattings. > > A version check for autopep8 (rather than pylsp) may have been an > alternative solution > > Who knows? Did you try it? I only tried the aforementioned patch at the time. I was just clarifying for posterity that the issue may well have lain with a component of pylsp rather than the version of the server itself, which is what this discussion focused on. > If it works i would have been happy to accept it Noone proposed > it. Instead, some truly vague and complex vapourware things were > proposed. That earlier proposals were not complete, optimal, or up to yours or anyone's standards does not warrant degrading them, IMO. Like you, we're all here just trying to improve Emacs in whatever way we can. Thanks, --=20 Basil