From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#63541: [PATCH] ; Fix use-package :vc keyword when byte-compiled Date: Sun, 21 May 2023 11:32:00 +0200 Message-ID: <874jo6owrz.fsf@hyperspace> References: <20230516231204.40043-1-steven@stebalien.com> <87a5y1za7p.fsf@posteo.net> <87wn14wdvf.fsf@hyperspace> <87wn137xrp.fsf@posteo.net> Reply-To: Tony Zorman Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21525"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63541@debbugs.gnu.org, Steven Allen To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 21 11:33:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q0fRP-0005JX-7C for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 May 2023 11:33:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q0fR3-00067c-Q2; Sun, 21 May 2023 05:33:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q0fR1-00067G-JH for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 05:33:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q0fR0-00020I-1D for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 05:33:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q0fQz-0004CC-TO for bug-gnu-emacs@gnu.org; Sun, 21 May 2023 05:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tony Zorman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 May 2023 09:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63541-submit@debbugs.gnu.org id=B63541.168466153916077 (code B ref 63541); Sun, 21 May 2023 09:33:01 +0000 Original-Received: (at 63541) by debbugs.gnu.org; 21 May 2023 09:32:19 +0000 Original-Received: from localhost ([127.0.0.1]:60031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0fQJ-0004BB-0N for submit@debbugs.gnu.org; Sun, 21 May 2023 05:32:19 -0400 Original-Received: from mout-p-103.mailbox.org ([80.241.56.161]:57880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q0fQG-0004An-BZ for 63541@debbugs.gnu.org; Sun, 21 May 2023 05:32:18 -0400 Original-Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4QPFhz6NJnz9sTL; Sun, 21 May 2023 11:32:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1684661523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NtQOyiZRaET4CQFQ96A8RYgx1wlqqykiQWPmCavAP0Y=; b=B+WqltQnlk9Yki96AjOQL3f1jCmFqPnoBwA5P0gS/LRleIcOZXzjhf04CNuR8WtaTGaY7n dLZLrnGzJa/Yh5La1PDnb/pnb8WfR60WPtHNiSWxtQw1JTfKgUCu6Lji4BR9Bzd5JmeC1O nhKCd0jorfUobAb89tJsD2t0VA5zbPSbnfC5eKVbIqPfi1KKSl7F9UP0I6tGddqeUMEuYu q+UTwyYDE8ehZqVuVOSNwiNrbxRaEvTwmYjODl+D//kb7QbegOR9ERMCRyfbxTmAsPS00c nlKaoEDG5UMgy9X3RskfMhxw3e8Va9TvUQn7r2Nf8A3RGfoKZA6hGsbKEVZ4yg== In-Reply-To: <87wn137xrp.fsf@posteo.net> X-MBO-RS-META: rnc7d6cfanpthkryubuxxojwhb4b1efg X-MBO-RS-ID: 01b4f0c07eb1738066e X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262099 Archived-At: On Sat, May 20 2023 16:50, Philip Kaludercic wrote: >> I'm not super familiar with the testing infrastructure here, but I >> wonder whether there is an easy way to write a quick regression test for >> this? > > I'm not a professional software engineer, Me neither, so don't worry about it :) > so I don't know what this means :/ Basically, I was wondering whether it'd be possible to write a test that byte compiles some statement and then checks the relevant expansion of the macro. This way, whenever the (now correct) code changes in the future (for whatever reason=E2=80=94most likely a refactor, I guess), one c= ould verify that the functionality wasn't inadvertently broken again. --=20 Tony Zorman | https://tony-zorman.com/