From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63916: 30.0.50; use-package: changes do not propagate to elpa-devel Date: Sat, 10 Jun 2023 09:03:31 +0000 Message-ID: <874jnf3d0c.fsf@posteo.net> References: <4b1ff1660351348f3d5f1bc848965d59@orthen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9767"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63916@debbugs.gnu.org, Stefan Monnier To: Benjamin Orthen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 11:04:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7uWI-0002Kq-9e for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 11:04:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7uW5-0005xI-Ma; Sat, 10 Jun 2023 05:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7uW3-0005xA-Rw for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 05:04:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7uVu-00005K-2k for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 05:04:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7uVt-0002f9-Ul for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 05:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 09:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63916 X-GNU-PR-Package: emacs Original-Received: via spool by 63916-submit@debbugs.gnu.org id=B63916.168638782310207 (code B ref 63916); Sat, 10 Jun 2023 09:04:01 +0000 Original-Received: (at 63916) by debbugs.gnu.org; 10 Jun 2023 09:03:43 +0000 Original-Received: from localhost ([127.0.0.1]:33277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7uVa-0002eY-Rv for submit@debbugs.gnu.org; Sat, 10 Jun 2023 05:03:43 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:47663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7uVX-0002eJ-Dp for 63916@debbugs.gnu.org; Sat, 10 Jun 2023 05:03:41 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 19AE4240103 for <63916@debbugs.gnu.org>; Sat, 10 Jun 2023 11:03:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1686387813; bh=FPdj5rPXL+5pmg3QRKZnY6D27Codwi/AEloSbtH/e2Q=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=KILQ/UF+x2ust9WzARi/Qjro04SYZ3p5hO9bKcQrWjYCC1CkK8qWax6nk8uWNZbm5 toDq9TQOby6d76Hse2PhV0lgQjdrtMuxE0ZeLDoJyEgXEUSZQpWscAL8hNZGgdvdIo MrbJRfBGJIM7DMI1a0ob3tTKDnH15QLHL1MyB02b+T+uJLr+t3KS4AxSiMn0R4N+1d lDS4zJLq8CwOCzJBFPohCuoVN7DfjgL6g4YfXR7XtuG/mKlf6J7SIE83HcRKMomp/A co4OCES8iNfPQSpgcSBsio5Hy6I5X595PQkrGadG3MM4GLqxP6ejjyNJyq/o45IYR9 BxYnXtCd4q39Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QdX6r35kyz9rxD; Sat, 10 Jun 2023 11:03:32 +0200 (CEST) In-Reply-To: <4b1ff1660351348f3d5f1bc848965d59@orthen.net> (Benjamin Orthen's message of "Mon, 05 Jun 2023 23:21:54 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263203 Archived-At: --=-=-= Content-Type: text/plain Benjamin Orthen writes: > Recent changes in use-package (i.e., commit > 2ce279680bf9c1964e98e2aa48a03d6675c386fe) have not propagated to > emacs-devel (https://elpa.gnu.org/devel/use-package.html) even though > use-package is designated as a :core package in elpa. > > My understanding is that changes in emacs for :core packages are > automatically propagated to elpa(-devel). I was however not able to > find documentation on how this propagation/sync works. I noticed that > use-package.el does not have the disclaimer ";; This is a GNU ELPA > :core package. Avoid adding functionality [...]" in its header. I > suppose this is unrelated to the elpa-devel sync, but could be fixed > as well. Unless I broke something on my local end, there seems to be a general problem with the ELPA build system. When trying to build use-package, I get these error messages: --8<---------------cut here---------------start------------->8--- $ make build/use-package emacs --batch -Q -l admin/elpa-admin.el \ -f elpaa-batch-pkg-spec-make-dependencies .pkg-descs.mk emacs --batch -l /home/philip/Source/elpa/admin/elpa-admin.el \ -f elpaa-batch-make-one-package use-package Linking files for package: use-package lisp/use-package/use-package.el -> use-package.el lisp/use-package/use-package-lint.el -> use-package-lint.el lisp/use-package/use-package-jump.el -> use-package-jump.el lisp/use-package/use-package-ensure.el -> use-package-ensure.el lisp/use-package/use-package-ensure-system-package.el -> use-package-ensure-system-package.el lisp/use-package/use-package-diminish.el -> use-package-diminish.el lisp/use-package/use-package-delight.el -> use-package-delight.el lisp/use-package/use-package-core.el -> use-package-core.el lisp/use-package/use-package-bind-key.el -> use-package-bind-key.el lisp/use-package/bind-key.el -> bind-key.el doc/emacs/doclicense.texi -> doclicense.texi doc/emacs/docstyle.texi -> docstyle.texi doc/misc/use-package.texi -> use-package.texi ======== Building tarball archive-devel/use-package-2.4.5.0.20230115.133305.tar... Build error for archive-devel/use-package-2.4.5.0.20230115.133305.tar: (error "Error-indicating exit code in elpaa--call-sandboxed: could not open use-package.texi: No such file or directory ") ######## Build of package archive-devel/use-package-2.4.5.0.20230115.133305.tar FAILED!! ======== Building tarball archive/use-package-2.4.5.tar... Build error for archive/use-package-2.4.5.tar: (error "Error-indicating exit code in elpaa--call-sandboxed: could not open use-package.texi: No such file or directory ") ######## Build of package archive/use-package-2.4.5.tar FAILED!! --8<---------------cut here---------------end--------------->8--- But if I disable sandboxing, then it works. The issue appears to be that the files under package/use-package are linked in using symlinks, but the directory (the emacs checkout) that is being linked to is not exposed via bwarp. If I add that to the ro-binds, then I can build the package. This diff might be enough to resolve the issue: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/elpa-admin.el b/elpa-admin.el index 24dd16d3cb..81467aa628 100644 --- a/elpa-admin.el +++ b/elpa-admin.el @@ -1262,7 +1262,8 @@ The INFILE and DISPLAY arguments are fixed as nil." "--tmpfs" "/tmp")) =20 (defvar elpaa--sandbox-ro-binds - '("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu")) + `("/lib" "/lib64" "/bin" "/usr" "/etc/alternatives" "/etc/emacs" "/gnu" + ,(file-truename (expand-file-name "emacs")))) =20 (defun elpaa--call-sandboxed (destination &rest args) "Like =E2=80=98elpaa--call=E2=80=99 but sandboxed. --=-=-= Content-Type: text/plain CC: Stefan, does this look OK to you? > > Best regards, > Benjamin --=-=-=--