[BUG] Failing tests for ob-clojure

[BUG] Failing tests for ob-clojure

[Ihor Radchenko]

Hi,

I am now going through all the babel tests that are disabled by default.

ob-clojure tests appear to be completely broken:

1. (org-test-for-executable "cider") assertion is strange as cider
   package does not have any executable.

2. All the tests seems to assert that ob-clojure supports sessions,
   while it does not seem to be the case.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Failing tests for ob-clojure

[Daniel Kraus]

Hi!

Ihor Radchenko <yantar92@posteo.net> writes:

> I am now going through all the babel tests that are disabled by default.
>
> ob-clojure tests appear to be completely broken:
>
> 1. (org-test-for-executable "cider") assertion is strange as cider
>    package does not have any executable.
>
> 2. All the tests seems to assert that ob-clojure supports sessions,
>    while it does not seem to be the case.

Unfortunately you're right and I would even say we can completely
remove `test-ob-clojure.el`.
There seems to be only tests for session support which currently
doesn't exist anymore and another one which tests plain tangle
and is not really Clojure specific.

I would love to write new tests but as I just started a new job
and got a new baby at the same time, I don't think I'll find the
time for it the next 3-4 month :(

Thanks,
  Daniel

Re: [BUG] Failing tests for ob-clojure

[Ihor Radchenko]

Daniel Kraus <daniel@kraus.my> writes:

> Unfortunately you're right and I would even say we can completely
> remove `test-ob-clojure.el`.
> There seems to be only tests for session support which currently
> doesn't exist anymore and another one which tests plain tangle
> and is not really Clojure specific.

Done.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fcca76274

> I would love to write new tests but as I just started a new job
> and got a new baby at the same time, I don't think I'll find the
> time for it the next 3-4 month :(

Understood. We are not in rush.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] Failing tests for ob-clojure

[Daniel Kraus]

Ihor Radchenko <yantar92@posteo.net> writes:

>> Unfortunately you're right and I would even say we can completely
>> remove `test-ob-clojure.el`.
>> There seems to be only tests for session support which currently
>> doesn't exist anymore and another one which tests plain tangle
>> and is not really Clojure specific.
>
> Done.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=fcca76274

Thanks!

Re: [BUG] Failing tests for ob-clojure

[Ihor Radchenko]

Ihor Radchenko <yantar92@posteo.net> writes:
>> I would love to write new tests but as I just started a new job
>> and got a new baby at the same time, I don't think I'll find the
>> time for it the next 3-4 month :(
>
> Understood. We are not in rush.

It has been a while since the last activity in this thread.
Daniel, have you had a chance to look into writing new tests?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>