From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner Newsgroups: gmane.emacs.devel Subject: Re: compat.el and Emacs unstable master branch features (was: bug#63513: [PATCH] Make persist-defvar work with records and hash tables) Date: Sat, 09 Sep 2023 09:52:06 -0700 Message-ID: <874jk3cmns.fsf@breatheoutbreathe.in> References: <87wn1axgh6.fsf@breatheoutbreathe.in> <87a5xubwoo.fsf@breatheoutbreathe.in> <87v8csku60.fsf@breatheoutbreathe.in> <83cyyz94c6.fsf@gnu.org> <87a5u2ydzg.fsf@breatheoutbreathe.in> <83msy25g0s.fsf@gnu.org> <624CBB7F-1442-400D-8D4D-1B26EBE9DACB@breatheoutbreathe.in> <877cp5bmig.fsf@breatheoutbreathe.in> <871qvz4kdw.fsf@localhost> <8734zoaolv.fsf@localhost> <87fs3o8uil.fsf@localhost> <87msxwa8kd.fsf@breatheoutbreathe.in> <87il8j7ji9.fsf@localhost> <80479897-500e-fe60-6586-0a44ccb5993b@daniel-mendler.de> <877coz7f6h.fsf@localhost> <86d6e412-9e5b-9086-56ce-e3794085096a@daniel-mendler.de> <874jk37dgh.fsf@localhost> <3f6176d5-ccc9-ec37-8adc-4e221388e164@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22879"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Ihor Radchenko , Stefan Monnier , Adam Porter , Eli Zaretskii , phillip.lord@russet.org.uk, emacs-devel@gnu.org, ~pkal/compat-devel@lists.sr.ht To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 09 19:02:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qf1MF-0005gc-4N for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Sep 2023 19:02:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qf1LE-0007vD-JA; Sat, 09 Sep 2023 13:01:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qf1EI-0005gM-8b for emacs-devel@gnu.org; Sat, 09 Sep 2023 12:54:45 -0400 Original-Received: from out-228.mta1.migadu.com ([95.215.58.228]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qf1EF-00057L-9a for emacs-devel@gnu.org; Sat, 09 Sep 2023 12:54:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1694278475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y6SXmLCaV2iLPcl7DjuKlTaRrsiipG33CzIMpQxE+u8=; b=GNIK5GrY8iCt1wckUwUyxZxMpJlYQH0DJBFP+hiD457fq0HeGttXjOve4s4caGmzrBby7u iSneVvaZvoaudEEEKq5Sdi4q9/s5R2wdej7bH8ZCzgJL6eRjMb5Xx8gIm/y/X4mjKQsKT0 e1OYAeHULN13JYjB8y1r6+zJLxSTkOU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <3f6176d5-ccc9-ec37-8adc-4e221388e164@daniel-mendler.de> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=95.215.58.228; envelope-from=joseph@breatheoutbreathe.in; helo=out-228.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 09 Sep 2023 13:01:48 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310415 Archived-At: Daniel Mendler writes: > I suggest to copy new functions temporarily to the package in question > with an fboundp check, with an additional TODO comment. We can > synchronize with Compat afterwards. Providing a public API won't work > since Compat is not included in Emacs itself. A design criterion of > Compat is also to keep the public API surface as small as possible. fboundp won't work here because copy-tree is available in earlier versions of Emacs. Since its behavior changed in 30, we could do a version check + TODO comment?