From: Robert Pluim <rpluim@gmail.com>
To: Eshel Yaron <me@eshelyaron.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
mail@titusmueller.de, philipk@posteo.net, 68762@debbugs.gnu.org
Subject: bug#68762: 30.0.50; thing-at-point for an e-mail adress stops at "."
Date: Mon, 29 Jan 2024 10:05:17 +0100 [thread overview]
Message-ID: <874jewy0fm.fsf@gmail.com> (raw)
In-Reply-To: <m1y1c9zyoq.fsf@dazzs-mbp.home> (Eshel Yaron's message of "Sun, 28 Jan 2024 08:47:49 +0100")
>>>>> On Sun, 28 Jan 2024 08:47:49 +0100, Eshel Yaron <me@eshelyaron.com> said:
Eshel> Eli Zaretskii <eliz@gnu.org> writes:
>>> From: Eshel Yaron <me@eshelyaron.com>
>>> Cc: Titus Müller <mail@titusmueller.de>, Philip Kaludercic
>>> <philipk@posteo.net>, 68762@debbugs.gnu.org
>>> Date: Sun, 28 Jan 2024 06:58:19 +0100
>>>
>>> FWIW, AFAICT this is introduced by 03cfede8f0 (which fixed Bug#61519).
>>>
>>> I think the real issue resides in `thing-at-point-looking-at`, though:
>>> It stops extending the match backwards when it first encounters a
>>> non-match. The following change solves this for me, and keeps all the
>>> tests happy:
>>
>> Thanks. Can you describe the main ideas of the change?
Eshel> Sure: the current implementation searches forward first, and then back,
Eshel> until it finds a match that contains point. It then extends the match
Eshel> backward character by character until it reaches a non-match. My change
Eshel> reverses the direction: start from some position before point and search
Eshel> forward until you find a match that contains point. This works better
Eshel> since "matching a regular expression at a given spot always works from
Eshel> beginning to end" (from Info node "(elisp) Regexp Search").
>> Robert, any comments?
Not really. It would be nice if the test suite could be extended to
catch this.
Robert
--
next prev parent reply other threads:[~2024-01-29 9:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 13:25 bug#68762: 30.0.50; thing-at-point for an e-mail adress stops at "." Titus Müller
2024-01-27 18:39 ` Eli Zaretskii
2024-01-27 20:42 ` Titus Müller
2024-01-28 5:58 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 7:11 ` Eli Zaretskii
2024-01-28 7:47 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-29 9:05 ` Robert Pluim [this message]
2024-01-29 12:41 ` Eli Zaretskii
2024-02-01 10:26 ` Eli Zaretskii
2024-02-01 11:10 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-08 11:47 ` Eli Zaretskii
2024-02-10 16:48 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jewy0fm.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=68762@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mail@titusmueller.de \
--cc=me@eshelyaron.com \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.