From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: john muhl Newsgroups: gmane.emacs.devel Subject: Re: master 40629706b1f 1/2: Avoid unnecessary escaping in 'url-build-query-string' Date: Thu, 18 Apr 2024 11:01:56 -0500 Message-ID: <874jbxy073.fsf@pub.pink> References: <171343493172.17932.11313573194838208920@vcs2.savannah.gnu.org> <20240418100853.D8466C1FB57@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27528"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.8; emacs 30.0.50 Cc: Eli Zaretskii , emacs-devel@gnu.org To: Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 19 16:36:49 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxpM8-0006uN-CE for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Apr 2024 16:36:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxpLZ-0008Bh-Bx; Fri, 19 Apr 2024 10:36:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxntR-0003rN-HN for emacs-devel@gnu.org; Fri, 19 Apr 2024 09:03:07 -0400 Original-Received: from fout7-smtp.messagingengine.com ([103.168.172.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxntN-0007YX-K6; Fri, 19 Apr 2024 09:03:05 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id B4F0D1380092; Fri, 19 Apr 2024 09:02:58 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 19 Apr 2024 09:02:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pub.pink; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1713531778; x=1713618178; bh=FDLa1wofZ0 i7/wMS+y+w5LtOXKP+9V02CYMVo37D7g0=; b=U8eVuRDuvs2iH9uM4SkBJpgLFh yGyP4bNoPzwTS+XpiW13PVhQmUfCi/mpRnoriRIRRmk5OvyPBQHq2PYYo4swq70W 6GqGGOZwLfbx5tfvt5nO3oXO1iv2cJvjuYGWLE5BeqldTYgVC4kpVb+LPvNgNXJ5 ii46bEpfpAVggFUsaWZAFzwf38YKcPhdrUrDkHiRafF9gmC5zqK4Sb6XvHxoYy3G CUPR7TOSExuPG2dYf5RzGPXrVMzSYu++CSonCwBpRI0zLQprxYhU0rGW5INL+m5O U3XXnufF/3tRZZZHpDRbWrI02u4VBX2hkVD06QDrW+LqCbw+fZXJ2QW98NUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1713531778; x=1713618178; bh=FDLa1wofZ0i7/wMS+y+w5LtOXKP+ 9V02CYMVo37D7g0=; b=Es7JltbEez6Xabmvuij+HQxIpc/E0bIn+roBuZvWUCbS Gc0jQNdIAktdM+q13TXSrd6CyHe2QzjMjRmTM7Qq9Mj1HtetovZgCbI4/Fy3sYUc FjaCdsTXgCcKdXGw2kTvau18uDCq6ijFU1Kh3EuqeAledWGxMn1nEXrphkgsTprt rItxagNrPAPZ9ESRuP43nlmqxuwRICm2ClO3Fz82ZawGIbW93hpA4zwv5boutLGD cHOYkAzC1PyG1SYKqEghoJ6qouHIdHJnmKn36PCIXax193ev3idlU//zVvqA0kxR oBuR5zVYpfMepeJTKx9jxOMjyzNlV1W7wcGRYTcsCQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudekvddgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesmhdtreertdertdenucfhrhhomhepjhhohhhn uchmuhhhlhcuoehjmhesphhusgdrphhinhhkqeenucggtffrrghtthgvrhhnpedufedtte eludegledvfefhhfeileetkeelhffhheekuefggffftdejgfehgfelhfenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjmhesphhusgdrphhinh hk X-ME-Proxy: Feedback-ID: i74194916:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 19 Apr 2024 09:02:57 -0400 (EDT) In-reply-to: <20240418100853.D8466C1FB57@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=103.168.172.150; envelope-from=jm@pub.pink; helo=fout7-smtp.messagingengine.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_12_24=1.049, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 19 Apr 2024 10:36:10 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317843 Archived-At: --=-=-= Content-Type: text/plain Bisect says this commit caused the gravatar tests to start failing. make test/lisp/image/gravatar-tests.log --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=gravatar-tests.log Running 5 tests (2024-04-19 07:59:37-0500, selector `(not (or (tag :unstable) (tag :nativecomp)))') passed 1/5 gravatar-build-url (0.000094 sec) Test gravatar-default-image backtrace: signal(ert-test-failed (((should (equal (gravatar--query-string) "r= ert-fail(((should (equal (gravatar--query-string) "r=g&d=https%3A%2F (if (unwind-protect (setq value-47 (apply fn-45 args-46)) (setq form (let (form-description-49) (if (unwind-protect (setq value-47 (apply (let ((value-47 'ert-form-evaluation-aborted-48)) (let (form-descrip (let* ((fn-45 #'equal) (args-46 (condition-case err (list (gravatar- (let ((gravatar-default-image "https://foo/bar.png")) (let* ((fn-45 (let ((gravatar-force-default nil) (gravatar-size nil)) (let ((grava (closure (t) nil (let ((gravatar-force-default nil) (gravatar-size n #f(compiled-function () #)() handler-bind-1(#f(compiled-function () #