From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71576: 30.0.50; [PATCH] Improve performance of Comint/Eshell password prompt handling Date: Sun, 16 Jun 2024 14:29:05 +0200 Message-ID: <874j9t6pgu.fsf@gmx.de> References: Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12576"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , 71576@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 16 14:30:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIp1Y-00037l-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jun 2024 14:30:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIp1H-0004kH-RD; Sun, 16 Jun 2024 08:30:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIp1F-0004hU-Cv for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 08:30:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIp1F-0007ll-4v for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 08:30:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sIp1G-00040e-9A for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2024 08:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2024 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71576 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71576-submit@debbugs.gnu.org id=B71576.171854095815271 (code B ref 71576); Sun, 16 Jun 2024 12:30:02 +0000 Original-Received: (at 71576) by debbugs.gnu.org; 16 Jun 2024 12:29:18 +0000 Original-Received: from localhost ([127.0.0.1]:52479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIp0X-0003yF-Ut for submit@debbugs.gnu.org; Sun, 16 Jun 2024 08:29:18 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:43405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIp0V-0003xt-Vq for 71576@debbugs.gnu.org; Sun, 16 Jun 2024 08:29:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1718540948; x=1719145748; i=michael.albinus@gmx.de; bh=B7tjTAxv9hPLRO0adzRftNiAvm7Sopa5JUYPdge3Z/I=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=imS6X41k4P1NAYrVUkWqH9gF0bRP+OvyR0lEvcw1wYRLm1EoSV8qf8v/NKI54DTf GihLu347vixm6BvxE3Vb2xNFp+vd8F29bvbWIP4d30Fo9Q+CjEsuGEzgbVb4CVCLb QHiQaZzyOxZoe4aP04oAHIN8sj2OGh1e17nTnQI7QdcLcHSuM39FVCtQentIU933W u170tifraTBgGQrLHxF72zLRmz3+klCkVwacFRDEf1hKLj85Fht74aaodGQy7S1b0 KPRcMcgR+FceUkodpkufTPC2gwB2yEQSBXciDQ78fHSMVhxt4WwLTFoh4RBL//o1v 9gczQNT8utIo8jPnZA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6sn7-1sSFeW3cdD-016VsZ; Sun, 16 Jun 2024 14:29:07 +0200 In-Reply-To: (Stefan Kangas's message of "Sun, 16 Jun 2024 03:53:46 -0700") X-Provags-ID: V03:K1:88TpcWWZTA+qZGo0JzMfLhLcpthcYz0c0s7blZnXv+D1FWuRTjj BdyNJAuQ/vaCraeA0iiZBypXucTp0KssyVxAIlb6f5lwROE+p59Z2VKGtYG7A4Zz5bo7rJN 26oGF0xxf/pUH6NMLRKU0VFSkHxL5geHLIOAgI09n2IFNRLFVji7y/5mvEsS35Z5TSqiOdc 9Hg5rtCDeld+0HHUfvt7A== UI-OutboundReport: notjunk:1;M01:P0:BezDVfZWf08=;s3Sqn5YJEIR3DPEsz4AjxIHzl4R HlKUb6dlsSHIxJyRQpQuzpd1lAEror4VhBHodYHASdM9vSbSbEs4fv1JGo8v1+qEH2svu7Ji+ /VqbKRL8H/DVfZYCoYLms0SRrDnxiZdIKkzti1yR1qtK/Ey6Jb0ial9m7xfMlnord2JYciD/0 l3AVW/zzUkpYi2PJf70I3fUgpAL8yJsQ8LgqixkX9JU9DZ18xMoQ89inwjW0Y9cctUHWfn2We CKue0bPDlhgzN2eCp1troYiVKdrOjiSjm4dzRwDqTI3ipHSGSHwFkP4QQoYMshZyeuM37jcP+ 18C8WC2Q0UChUZWrvuKzsqqVJu827dxu9lJiftdzOChzGSPweS0MaXP1c57fiAOhi6VcutCw+ W5p05v5R5AkYT5+4OL2jfMz/IiZ2/15jQpxeRuxWubGc4WbxmMStiFupE6PPXWM1td5hdfsVA szTnmaDYEMhiC9CQjmtqgLLawblgwd5PG4lm2IyHmvk8iqpsV1AQDYH1HmpE3QALCHF2tD9Hr ze3ZJ3KIV5KBDH6eCftXf19F0Bwfdzv+1N4yelbCxtFroE76qwwkRb3Rt41wtNQCR8SkSqCrc ZzKZz9E9ufWusfV5sHWpgSSSyP5pBZmmxkqOhR8FmmFybCtwFL7EG0P3vDzg0IgA4otPJ90WM f3ly0wezOROe9qyYhkVAKdz4wna3yd2gBA9EcuZbw79wX51nRK8ssom7vuHAn7m4ecU08SlJ6 VwY8aLSZKsHNAYjaIMlpiFF1CFdVjjDVs0021zVobmMr3WVbIioFTvsmrIMx44da8UAivh2i X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287333 Archived-At: Stefan Kangas writes: Hi Stefan, >> +(defcustom comint-password-prompt-max-length 256 >> + "The maximum amount of text to examine when matching password prompts. >> +When non-nil, only examine the last N characters of a block of output. >> +If nil, examine all the output. >> + >> +This is used by `comint-watch-for-password-prompt' to reduce the amount >> +of time spent searching for password prompts." >> + :version "30.1" >> + :type '(choice natnum >> + (const :tag "Examine all output" nil)) >> + :group 'comint) > > If this is hardcoded in Tramp, are we sure that we need this as an > option? I'd suggest making it into a defconst or defvar instead. Tramp uses this value just "by experience", and to be on the safe side. I can imagine, that people know that prompts are much shorter in their case, say 25 bytes. A defcustom is OK in my eyes. (apply #'max (mapcar #'length password-word-equivalents)) => 14 Best regards, Michael.