From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 15:32:05 +0200 Message-ID: <874j95706i.fsf@gmx.net> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> <86v81l8gnj.fsf@gnu.org> Reply-To: Stephen Berman Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jpw@gnu.org, juri@linkov.net, me@eshelyaron.com, basil@contovou.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 15:33:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPMac-0001OF-CJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 15:33:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPMa8-0007zi-4W; Thu, 04 Jul 2024 09:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPMa5-0007z9-6A for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 09:33:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPMa4-0007CX-EX for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 09:33:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPMa6-0001Lm-Jo for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 09:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.17200999505149 (code B ref 71927); Thu, 04 Jul 2024 13:33:02 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 13:32:30 +0000 Original-Received: from localhost ([127.0.0.1]:41792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPMZZ-0001Kz-6B for submit@debbugs.gnu.org; Thu, 04 Jul 2024 09:32:29 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:53239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPMZW-0001Kk-4N for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 09:32:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1720099928; x=1720704728; i=stephen.berman@gmx.net; bh=5UtMufHETCERyh108rqmLl82FY/05TjyxDvbVsRh2bo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=tNKjyJHvkAKjuiboMCmZDIPZZjddx7NTljCxE+rPdVM39KVJ2i7iXuBlvpLI7Jr6 a5Cgr6srWHCmRjitI1NQdDQ9go4taWfisMPXbKOrfXASPGHOJZ7LYBh+hDTK3FZWd z8aGjRKR9MeWrTrspzBkdfi5m1W5RV1vsmE8zQ95u+8O8WWuprq9wSg42+MXyMniz 9NCecrZNySZXAbtbKFmMO47493/i9FK0qQBaFud4cZF0BEoK4X35kNgFESgahRDZ/ RKzJPNkpeDV2lY/i4+f16Vftn/ej8AxlLmfv6qwu+65pLCJmoLmTtLYS2OKf0XgBm RO9EnoH55LaqLQrqnA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from strobelfs ([88.130.48.103]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MtfJX-1s8Wnw47aR-014Lh3; Thu, 04 Jul 2024 15:32:08 +0200 In-Reply-To: <86v81l8gnj.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jul 2024 15:50:56 +0300") X-Provags-ID: V03:K1:pGTYbG8Le170R34FJFVur2dStenU3L0CVQKLuru7Ddmtihn1HE2 On5AlZCY+zOb7jY69Ghjje0U8Rxcmd8eM9S4duK+FlIsoiDWGMdSM3t4gLDwpdeuEb9m9en UizO8kbBQJyYPnRfaYLYbWy+VAYryFeBljdNrOMmBRkcXhkwVfOhaNvyQYlJM4YjKMxw5gl ii7UHaUXnkClZ12mHgm7A== UI-OutboundReport: notjunk:1;M01:P0:mqs57Vr0YSs=;DPd4eI8HVblA6FMZogRuOqW6uWV 6xcRwNwjmXT7HtmA4DDPgV0ceA1ShTnBsdn76Ak3VSOC/eJhC1djXm1QozFqi6LdRPkfTp4xw K73aWytBz3HCchqDrek7tTjVBOM95GAVJgXiOMYrdbPs0ZVBGA9f5bWy9QPrpK2zZSFpCirw7 T+4B68zSMCV2nb0D3r9RstqBOXpPNEt1QeVAwwUVZTSP0FQNwn/CxK0e9O/hLRkzi6TUaJ2At EDFYHDauNWgicBejMIjEGELOZYuMMESLOIR2qMMde0o4ceXotSGbOaO9OBXf+FqDGxVqN1Acg ggAnvqf1C+ombYT07WvJknnYJNm//yFLxYI/uQPdO+pkDSODBurWpotErFrIuNR8OLQT7f6ae 2Tj0bHEx8Qhln1M3/J3blLbIxWQvIO8BrhqLrNp6fOT2c6t6QC4xnufzDZDOy/BFM7oK+Fnev R0beOVwgNOl3m2qwxBIsv83wR8JP2ifEbw2Ef1ylO3R7fUJGwMypGa10eBEKAkvmaKSnjSJG2 d5C8lp2daVZZsw+Ov7W9r+Oc2alTu4PNQztbqaSrJUqT5kWnGKYV7FvDCyph/9NBhwxHL5+T4 b5XfH5qpxWl7ok87gYB3uX71xOz6HOoj91ZsFBHOplVZOGuzdn6Bb04LdvnB9ax2rSsfzoRIo f3mPl7swLf0nVaZIaRzOET9gNZWYJL8L3CL1tYzrZUCVtvNOIMJltNHkRTzsNRQYVsze9Q5xe lDHS/SDzh2J9XlD/UYwzgYQIjUiw/AGfoQ7JH1ci1cNoJ0Qw1uvS/XAucWvYgh9y6U2tvIIO X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288370 Archived-At: On Thu, 04 Jul 2024 15:50:56 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: Eshel Yaron , kickingvegas@gmail.com, >> 71927@debbugs.gnu.org, basil@contovou.net, jpw@gnu.org, >> juri@linkov.net >> Date: Thu, 04 Jul 2024 12:06:40 +0200 >> >> >> FWIW, AFAICT everything is working correctly, it's just that the >> >> "Operation finished" message hides the prompt. ibuffer-do-isearch >> >> should tell define-ibuffer-op not to display that message, somehow. >> > >> > I don't see how this could be considered "correct": the "Operation >> > finished" message is supposed to be shown only after the Isearch is >> > finished in all the marked buffer, not before. It looks like we need >> > a function that will not return until all the buffers where searched, >> > because that's what define-ibuffer-op expects. Don't you agree? >> >> The attached patch appears to DTRT, but I only tested it briefly. > > Thanks, but does it really make sense to change define-ibuffer-op to > fix the functions which (evidently) use it incorrectly? I think the > fix needs to be in the same place where the bug is. That's what I thought, too, but I don't see a way to do that, because define-ibuffer-op hard-codes displaying a message at the end of the body. But in this case that message seems superfluous, in addition to hiding the isearch prompt, because when isearch goes through the marked buffers, it then displays its own message that the operation is complete. So this looks like a case when define-ibuffer-op is currently too rigid. However, I acknowledge that I don't really grok the interaction with isearch, i.e., why the "Operation finished" message is shown although isearch hasn't even begun. But AFAICS suppressing the message as in the patch does allow isearch to proceed and complete as usual. Steve Berman