From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id cNVEIGeA1GZxUAAA62LTzQ:P1 (envelope-from ) for ; Sun, 01 Sep 2024 14:55:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id cNVEIGeA1GZxUAAA62LTzQ (envelope-from ) for ; Sun, 01 Sep 2024 16:55:35 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; none Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 717526E730 for ; Sun, 1 Sep 2024 16:55:35 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sklyW-0007AR-VP; Sun, 01 Sep 2024 10:54:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sklyU-0007A9-Ck for emacs-orgmode@gnu.org; Sun, 01 Sep 2024 10:54:43 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sklyP-0007uE-0F for emacs-orgmode@gnu.org; Sun, 01 Sep 2024 10:54:42 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 539D7240027 for ; Sun, 1 Sep 2024 16:54:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1725202471; bh=irmA7uobp81lBRzVMDKsrz8+bg03cz6dqwRSkaIs6cY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=XAa70EzJa2F/EsaDjsfT2S31XW4nhZqW3mOHjmnOtnn7d0PokRzPJL7KhEHcVs+/D cteyoAoLu1vBcMTcEYQ2YpxsPLai19di71vFujS74+Cu2q7lGLJWoaJE7RqCN8YgEF xYglBlpr+4MVsL14WTaTn/M45JTGSEZalYQObeTsbD2LA0IMRKe1roVUZkVHMU35r5 dEiaqYir34FRJQLHzqZv4IVay3dL/I3tiu82ApIQIGOc6OyQd+geQOK5Tag7BZIsUK 3PVrxX2z8FoFs7mskphsKmtVoC7Bvaw6PbCMYrZBjyTwy3nwE49aAzDuboQEKqd2yx T8caGLDXO0Iyw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WxZfZ5FN5z9rxS; Sun, 1 Sep 2024 16:54:30 +0200 (CEST) From: Ihor Radchenko To: Joseph Turner Cc: Org Mode Mailing List Subject: Re: [PATCH] lisp/org.el: Fix removing timestamp overlays In-Reply-To: <87y14j7u51.fsf@breatheoutbreathe.in> References: <874j779ali.fsf@breatheoutbreathe.in> <87y14j7u51.fsf@breatheoutbreathe.in> Date: Sun, 01 Sep 2024 14:55:55 +0000 Message-ID: <874j6zqv7o.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 717526E730 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.00 X-Spam-Score: -4.00 X-TUID: yMmcL9Ep089D Joseph Turner writes: > Subject: [PATCH] lisp/org.el: Fix removing timestamp overlays Thanks, although I believe that we can fix things even better. (If I understand the problem you are trying to solve correctly; just in case, please explain what you are trying to solve ;]) > (when (and (get-text-property p 'display) > - (eq (get-text-property p 'face) 'org-date)) > + (memq 'org-date (ensure-list (get-text-property p 'face)))) Rather than relying upon fontification settings, we may modify `org-display-custom-time' to put a special text property to mark the overlayed timestamps. Then, searching for that property will give reliable info on what is and what is not a time overlay. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at