From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.devel Subject: Re: Accidental change of behaviour for electric-layout-mode? Date: Thu, 03 Oct 2024 17:22:53 +0100 Message-ID: <874j5tkvfm.fsf@ice9.digital> References: <87wmj2dr4q.fsf@ice9.digital> <86v7yle1ma.fsf@gnu.org> <86cyktdx68.fsf@gnu.org> <871q18op24.fsf@ice9.digital> <86msjwdgcq.fsf@gnu.org> <87r098n8n5.fsf@ice9.digital> <86jzf0c6rw.fsf@gnu.org> <87h6a37sh0.fsf@ice9.digital> <86tte3bu9x.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33174"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 03 18:24:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swOcq-0008RJ-CQ for ged-emacs-devel@m.gmane-mx.org; Thu, 03 Oct 2024 18:24:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swObt-0004Mv-Gv; Thu, 03 Oct 2024 12:23:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swObk-0004MW-AE for emacs-devel@gnu.org; Thu, 03 Oct 2024 12:23:17 -0400 Original-Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swObe-00038U-JH; Thu, 03 Oct 2024 12:23:15 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id D777640003; Thu, 3 Oct 2024 16:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1727972575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v/0iSJdRkB5NGylz5QynfDaDq9T6vDsG2Kz3w9mFycw=; b=D2/MHo72zMRbMTfdsJ8bhDIuH5BFC/l4UsRaZGKCzvKI9BTE8TRO9NTrRFRvPC/Jprize9 oQVUSKElh78rJHpLlbkCysbcD4mc6DuHylbxxi+rQNLx6aTwkn6oEExvNdb/kGTyNVIjPh 8TH9nyS6PyBfQwIvfzXZTssrJBjbOFofz9h3/UyUYJwS1dMjaS4/p8zFcJCi5lLc72i73a TO/qGaPJLt8GS1lnIwZZvLCB/44Uy/MknUZPjpqW2xyrvKUKRYPCUr5/ReFfvGNQty9RnG 3BUeSTHLjrWTfVtc0c9AZeUj2EyszRV1w5DLY2dIe77QKtgOXH2GgzUhbnuydQ== In-Reply-To: <86tte3bu9x.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 25 Sep 2024 18:57:46 +0300") X-GND-Sasl: morgan@ice9.digital Received-SPF: pass client-ip=2001:4b98:dc4:8::222; envelope-from=morgan@ice9.digital; helo=relay2-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324289 Archived-At: Eli Zaretskii writes: >> From: Morgan Willcock >> Cc: emacs-devel@gnu.org >> Date: Wed, 25 Sep 2024 14:50:19 +0100 >> >> Just to make sure everything works in Emacs 30, I'd rather just revert >> the accidental change than get further involved in the development of >> this feature (at least in the short term). >> >> I've attached a patch which just reverts the change that was >> accidentally applied. This should be all that is needed unless you >> specifically want to accommodate features which accidentally worked in >> an unreleased version of Emacs. > > Actually, having the variable is better, because we have run with this > code for quite some time, and someone might rely on the unintended > feature. So I think your original patch is better. Possibly it depends on whether there will be an additional pretest release or not? If there was going to be one and it was accompanied by a note to re-test any changes which were made to electric-layout-mode rules, that might be enough. -- Morgan Willcock