Recent isearch changes in eshell

Recent isearch changes in eshell

[Colin Baxter]

Recently, isearch in eshell was changed. According to NEWS, the
following will revert the changes:

--8<---------------cut here---------------start------------->8---
(keymap-set eshell-hist-mode-map "M-r"
             #'eshell-previous-matching-input)
(keymap-set eshell-hist-mode-map "M-s"
             #'eshell-next-matching-input)
--8<---------------cut here---------------end--------------->8---

It seems that the above will only work if they are evaluated after
calling eshell, otherwise they give "void variable eshell-hist-mode-map"
error.

Can anyone suggest how I might revert the changes without having to eval
the above keymap-set in a scratch buffer after "M-x eshell <RET>"? I have
tried eval after load in my ~/.emacs but that appears to have no effect.

Thank you.

Colin Baxter.

Re: Recent isearch changes in eshell

[Andreas Schwab]

On Dez 16 2024, Colin Baxter wrote:

> Recently, isearch in eshell was changed. According to NEWS, the
> following will revert the changes:
>
> (keymap-set eshell-hist-mode-map "M-r"
>              #'eshell-previous-matching-input)
> (keymap-set eshell-hist-mode-map "M-s"
>              #'eshell-next-matching-input)
>
> It seems that the above will only work if they are evaluated after
> calling eshell, otherwise they give "void variable eshell-hist-mode-map"
> error.

(with-eval-after-load 'em-hist ...)

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: Recent isearch changes in eshell

[Colin Baxter]

>>>>> Andreas Schwab <schwab@suse.de> writes:

    > On Dez 16 2024, Colin Baxter wrote:
    >> Recently, isearch in eshell was changed. According to NEWS, the
    >> following will revert the changes:
    >> 
    >> (keymap-set eshell-hist-mode-map "M-r"
    >> #'eshell-previous-matching-input) (keymap-set
    >> eshell-hist-mode-map "M-s" #'eshell-next-matching-input)
    >> 
    >> It seems that the above will only work if they are evaluated
    >> after calling eshell, otherwise they give "void variable
    >> eshell-hist-mode-map" error.

    > (with-eval-after-load 'em-hist ...)

Thank you! That worked.

I wonder if perhaps NEWS could be amended to include this?

Colin Baxter.

Re: Recent isearch changes in eshell

[Jim Porter]

On 12/16/2024 6:25 AM, Andreas Schwab wrote:
> On Dez 16 2024, Colin Baxter wrote:
> 
>> Recently, isearch in eshell was changed. According to NEWS, the
>> following will revert the changes:
>>
>> (keymap-set eshell-hist-mode-map "M-r"
>>               #'eshell-previous-matching-input)
>> (keymap-set eshell-hist-mode-map "M-s"
>>               #'eshell-next-matching-input)
>>
>> It seems that the above will only work if they are evaluated after
>> calling eshell, otherwise they give "void variable eshell-hist-mode-map"
>> error.
> 
> (with-eval-after-load 'em-hist ...)

Thanks (and thanks for Colin for reporting this). Now fixed in 43fcda0c8ea.

Re: Recent isearch changes in eshell

[Colin Baxter]

>>>>> Jim Porter <jporterbugs@gmail.com> writes:

    > On 12/16/2024 6:25 AM, Andreas Schwab wrote:
    >> On Dez 16 2024, Colin Baxter wrote:
    >> 
    >>> Recently, isearch in eshell was changed. According to NEWS, the
    >>> following will revert the changes:
    >>> 
    >>> (keymap-set eshell-hist-mode-map "M-r"
    >>> #'eshell-previous-matching-input) (keymap-set
    >>> eshell-hist-mode-map "M-s" #'eshell-next-matching-input)
    >>> 
    >>> It seems that the above will only work if they are evaluated
    >>> after calling eshell, otherwise they give "void variable
    >>> eshell-hist-mode-map" error.
    >> (with-eval-after-load 'em-hist ...)

    > Thanks (and thanks for Colin for reporting this). Now fixed in
    > 43fcda0c8ea.

Thank you. I very much appreciate your addition to the NEWS item.

Best wishes,

Colin Baxter.