From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Colin Baxter Newsgroups: gmane.emacs.devel Subject: Re: Recent isearch changes in eshell Date: Wed, 18 Dec 2024 18:02:22 +0000 Message-ID: <874j30lvip.fsf@yandex.com> References: <874j339162.fsf@yandex.com> <87cfd588-a2e0-dd39-9fde-3c9350260e56@gmail.com> Reply-To: m43cap@yandex.com Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5161"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (gnu/linux) Cc: Andreas Schwab , emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 18 19:03:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNyO4-000170-Qy for ged-emacs-devel@m.gmane-mx.org; Wed, 18 Dec 2024 19:03:08 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNyNe-0004QY-6a; Wed, 18 Dec 2024 13:02:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNyNX-0004QC-OJ for emacs-devel@gnu.org; Wed, 18 Dec 2024 13:02:35 -0500 Original-Received: from forward500d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:d500]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNyNV-0003hd-Of for emacs-devel@gnu.org; Wed, 18 Dec 2024 13:02:35 -0500 Original-Received: from mail-nwsmtp-smtp-production-main-77.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-77.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:4caf:0:640:9790:0]) by forward500d.mail.yandex.net (Yandex) with ESMTPS id B8FD2613FD; Wed, 18 Dec 2024 21:02:25 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-77.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id N2WI4GOOl4Y0-0Qo3vi7o; Wed, 18 Dec 2024 21:02:25 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1734544945; bh=dRd912mhLmCluEcT52sVNH2X6s/5JZOL3u+mN//d6Ao=; h=Message-ID:References:Date:Reply-To:Cc:In-Reply-To:Subject:To: From; b=WvbXbxA3jK5kiTCcyPtYbw5yLFMTc5RoeTRsz+McGGTBZRm1vVGKHxP6s3g/Tkj1Q KWAjqf6LYetFZv2Zvjftgu6AUbGbvfAqsrmzz9iRe1sOCTXFwgiL9RJt2r83z/XGIQ h0BcIY7I/H7pnLugJLvQFI+lKuHGxkggc30lUNUw= Authentication-Results: mail-nwsmtp-smtp-production-main-77.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.com In-Reply-To: <87cfd588-a2e0-dd39-9fde-3c9350260e56@gmail.com> (Jim Porter's message of "Tue, 17 Dec 2024 21:25:18 -0800") X-Face: BHjiJOg/Qmj'BQgsAKL@])L)e62P)C"Y=6T Face: iVBORw0KGgoAAAANSUhEUgAAAEkAAAATAgMAAAChCMjeAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAACVBMVEX/zAABCWP///8I RHjYAAAAAWJLR0QCZgt8ZAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB+UFEAk5BvqS634A AAAbSURBVBjTY2BgCA1hYA0FAxDDgQEERsXoIAYA2F9Eb3cpB+AAAAAldEVYdGRhdGU6Y3JlYXRl ADIwMjEtMDUtMTZUMTA6NTY6MTcrMDE6MDCh/kkpAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTA1 LTE2VDA5OjU3OjA2KzAxOjAwTyZ6HwAAAABJRU5ErkJggg== Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:d500; envelope-from=m43cap@yandex.com; helo=forward500d.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326679 Archived-At: >>>>> Jim Porter writes: > On 12/16/2024 6:25 AM, Andreas Schwab wrote: >> On Dez 16 2024, Colin Baxter wrote: >> >>> Recently, isearch in eshell was changed. According to NEWS, the >>> following will revert the changes: >>> >>> (keymap-set eshell-hist-mode-map "M-r" >>> #'eshell-previous-matching-input) (keymap-set >>> eshell-hist-mode-map "M-s" #'eshell-next-matching-input) >>> >>> It seems that the above will only work if they are evaluated >>> after calling eshell, otherwise they give "void variable >>> eshell-hist-mode-map" error. >> (with-eval-after-load 'em-hist ...) > Thanks (and thanks for Colin for reporting this). Now fixed in > 43fcda0c8ea. Thank you. I very much appreciate your addition to the NEWS item. Best wishes, Colin Baxter.