From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.bugs Subject: bug#75291: Redisplay not updating fringe when face filter changes Date: Thu, 02 Jan 2025 12:30:16 -0500 Message-ID: <874j2h3yzb.fsf@dancol.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16664"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.12.8; emacs 31.0.50 To: 75291@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 18:31:30 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTP2f-00049C-D0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 18:31:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTP2J-0006PY-9R; Thu, 02 Jan 2025 12:31:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTP2E-0006KC-Mz for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:31:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTP2E-0007Zy-F6 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:31:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=lQfAAvpv9kgxmwg5X9f+1DBPyY0T4OmfD3K6ViA01Tg=; b=COxyOc1JGqSh3J6KXI6m+qtT6xaMRwVsTRTkGd+5dqjycllwOuUGFe9mt13SH0ntBBKxYoEME0358rYItMEzEBWDSc6sWMo1HVqhsKMd1km0ZjsEpGMYQwaNIZERCBwDLYgjJgoTtaqYs8cO17nKH0h/KCD7ccmd8TN7W2e8eDiiS1xdKqVQo+RN3iqdGMj1Codl+gxOwkdRFLcbcTo11P0DQrEb0El/nSJTA5SrdS/w4G0Wt8Jnd+mJFjWiVdSmlYbeenbhxAjS0Pv4Wr9kkMl3rBsuATSd00BI7lhG8y80Dj+WLSqd+1vsymyEp8rfk7+1ORRm7MwTpBpqr1qQ+g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTP2E-0004yU-6h for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Colascione Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 17:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75291 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.173583903819078 (code B ref -1); Thu, 02 Jan 2025 17:31:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jan 2025 17:30:38 +0000 Original-Received: from localhost ([127.0.0.1]:46466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTP1q-0004xd-EL for submit@debbugs.gnu.org; Thu, 02 Jan 2025 12:30:38 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:54210) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tTP1o-0004xA-IF for submit@debbugs.gnu.org; Thu, 02 Jan 2025 12:30:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTP1c-0005mF-SE for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:30:28 -0500 Original-Received: from dancol.org ([2600:3c01:e000:3d8::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTP1Z-0007UD-Tl for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:30:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lQfAAvpv9kgxmwg5X9f+1DBPyY0T4OmfD3K6ViA01Tg=; b=T+2odeivbqO0qzH59V8RKAaGYU CLi9u2i8Zo1wCnW8DfwINxNJRjFXQWMtw+N6mvLwlVr8YQBKX5mK8MI8p1HIbKWuLzyfx9HcaX2rb g3ULcE1mbjLFuiZ/qqaG8T+24jQRtxHTD5SgZVcRyDtDBzbnYXR0pcxyH6B5iLg3vDjGCJh4ViX9N wmooDcqGf7OnF7FtDQ1ijUzvnMbINDiWqd1+cPHvQOuBlt4ah5L1F7phJCaHZmyDhmxOBw8kERIGS 69A/RVhRrc8QYL7BKh0P06pGMgm2FN2+2BcR+iJ7fun7Cjc8BAC+9z49RKKwOP+4e7RtEnlzfa9U8 aHoVcAEg==; Original-Received: from 2603-9001-4203-1ab2-bd9e-ad89-4d97-f163.inf6.spectrum.com ([2603:9001:4203:1ab2:bd9e:ad89:4d97:f163]:48858 helo=localhost) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tTP1V-0000yB-1D for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 12:30:17 -0500 Received-SPF: pass client-ip=2600:3c01:e000:3d8::1; envelope-from=dancol@dancol.org; helo=dancol.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298205 Archived-At: Sometimes we don't redraw when its effective face changes indirectly due to a face filter condition evaluating differently. An explicit redraw-display works around the problem, but it shouldn't be necessary and is an efficiency hit. See the code below: ;; -*- lexical-binding: t -*- ;; emacs -Q (setf my-window (selected-window)) (dolist (face '(default fringe)) (face-remap-add-relative face `(:filtered (:window foo t) (:background "green")))) (set-window-parameter my-window 'foo t) ;; During this sit-for, background and fringe should be green (sit-for 1) (set-window-parameter my-window 'foo nil) ;; Enable to work around bug (when nil (redraw-display)) ;; During this sit-for, background and fringe should be their original ;; color (probably white), but only the background changes. ;; Without redraw-display, the fringe remains green. (sit-for 1)