From: Rob Browning <rlb@defaultvalue.org>
Cc: emacs-devel@gnu.org
Subject: Re: Building emacs with and without X -- packaging question.
Date: Sat, 14 Sep 2002 16:16:13 -0500 [thread overview]
Message-ID: <873cscw9uq.fsf@raven.i.defaultvalue.org> (raw)
In-Reply-To: <200208040252.g742qam02724@aztec.santafe.edu> (Richard Stallman's message of "Sat, 3 Aug 2002 20:52:36 -0600 (MDT)")
Richard Stallman <rms@gnu.org> writes:
> Sure I can try. I presume you're talking about this diff:
>
> -(put 'frames 'custom-loads '( "desktop" "ediff-wind" "faces" "frame" "imenu" "menu-bar" "rsz-mini" "scroll-bar" "two-column"))
> +(put 'frames 'custom-loads '( "desktop" "ediff-wind" "faces" "frame" "imenu" "menu-bar" "rsz-mini" "two-column"))
>
> That one and the other one, both.
>
> Is this one related, or likely something else?
>
> -(custom-put-if-not 'gnus-article-x-face-command 'custom-version "21.1")
> -(custom-put-if-not 'gnus-article-x-face-command 'standard-value t)
>
> There is no way of knowing a priori whether they are related.
I finally had time to work on this, and I think I've tracked it down.
In cus-dep.el we have:
(let ((expr (read (current-buffer))))
(condition-case nil
(progn
(eval expr)
(put (nth 1 expr) 'custom-autoloaded is-autoloaded)
(put (nth 1 expr) 'custom-where name))
(error nil))))
Note that the condition-case ignores errors. However, if you rewrite
the above to actually catch the signalled-condition data and print it
via message, you will find that when compiling --with-x=no, there's an
error while handling both the scroll-bar-mode and
gnus-article-x-face-command defcustoms. In the scroll-bar-mode case
this appears to be because set-scroll-bar-mode-1 is undefined, even
though it's used as the :set value in the relevant defcustom:
(defcustom scroll-bar-mode
(if (eq system-type 'windows-nt) 'right 'left)
"*Specify whether to have vertical scroll bars, and on which side.
Possible values are nil (no scroll bars), `left' (scroll bars on left)
and `right' (scroll bars on right).
To set this variable in a Lisp program, use `set-scroll-bar-mode'
to make it take real effect.
Setting the variable with a customization buffer also takes effect."
:type '(choice (const :tag "none (nil)")
(const left)
(const right))
:group 'frames
:set 'set-scroll-bar-mode-1)
The actual condition-case signalled-condition data for this error is
(void-function set-scroll-bar-mode-1), and removing the :set line from
the defcustom fixes the problem, at least to the extent that the
scroll-bar related diff in cus-dep.el goes away. For
gnus-article-x-face-command, the condition-case signalled-condition
data is (void-variable gnus-article-compface-xbm).
If my analysis is right, is this something that should be fixed, and
if so, what would be the right way to fix it?
Thanks
--
Rob Browning
rlb @defaultvalue.org, @linuxdevel.com, and @debian.org
Previously @cs.utexas.edu
GPG=1C58 8B2C FB5E 3F64 EA5C 64AE 78FE E5FE F0CB A0AD
next prev parent reply other threads:[~2002-09-14 21:16 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-31 17:25 Building emacs with and without X -- packaging question Rob Browning
2002-05-31 18:41 ` Eli Zaretskii
2002-05-31 19:08 ` Alan Shutko
[not found] ` <7999-Sat01Jun2002102420+0300-eliz@is.elta.co.il>
2002-06-01 16:42 ` Alan Shutko
2002-06-01 16:50 ` Eli Zaretskii
2002-06-10 19:13 ` Rob Browning
2002-06-10 19:45 ` Alan Shutko
2002-06-10 19:52 ` Stefan Monnier
2002-06-10 20:17 ` Alan Shutko
2002-06-11 5:36 ` Eli Zaretskii
2002-06-11 12:37 ` Alan Shutko
2002-06-12 13:49 ` Juanma Barranquero
2002-06-13 5:21 ` Eli Zaretskii
2002-06-13 10:23 ` Juanma Barranquero
2002-06-13 11:42 ` Eli Zaretskii
2002-06-13 13:51 ` Juanma Barranquero
2002-06-13 14:03 ` Eli Zaretskii
2002-06-13 15:06 ` Juanma Barranquero
2002-06-13 15:16 ` Eli Zaretskii
2002-06-13 16:33 ` Juanma Barranquero
2002-06-14 15:47 ` Richard Stallman
2002-06-15 15:55 ` Eli Zaretskii
2002-06-13 21:47 ` Richard Stallman
2002-06-14 7:08 ` Juanma Barranquero
2002-06-15 15:54 ` Eli Zaretskii
2002-06-20 21:45 ` Rob Browning
2002-06-21 15:33 ` Eli Zaretskii
2002-06-21 17:16 ` Rob Browning
2002-06-22 16:02 ` Rob Browning
2002-06-23 18:13 ` Richard Stallman
2002-06-24 6:00 ` Rob Browning
2002-06-24 14:55 ` Rob Browning
2002-06-24 19:39 ` Richard Stallman
2002-06-24 19:44 ` Rob Browning
2002-06-24 20:16 ` Stefan Monnier
2002-06-25 4:23 ` Eli Zaretskii
2002-06-25 15:24 ` Rob Browning
2002-06-25 15:52 ` Eli Zaretskii
2002-06-26 22:24 ` Richard Stallman
2002-06-26 22:53 ` Rob Browning
2002-06-25 23:32 ` Richard Stallman
2002-07-31 20:03 ` Rob Browning
2002-08-01 16:52 ` Richard Stallman
2002-08-01 17:01 ` Rob Browning
2002-08-02 17:43 ` Richard Stallman
2002-08-02 6:11 ` Richard Stallman
2002-08-02 15:46 ` Rob Browning
2002-08-04 2:52 ` Richard Stallman
2002-09-14 21:16 ` Rob Browning [this message]
2002-09-17 15:32 ` Rob Browning
2002-09-20 4:18 ` Rob Browning
2002-08-09 6:54 ` Stefan Monnier
2002-06-10 20:01 ` Rob Browning
2002-06-01 21:04 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873cscw9uq.fsf@raven.i.defaultvalue.org \
--to=rlb@defaultvalue.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.